)]}'
{"id":"openstack%2Fpython-swiftclient~312998","triplet_id":"openstack%2Fpython-swiftclient~master~Ifa10cd2b8bf81c082d5e3fa846f993871194fea0","project":"openstack/python-swiftclient","branch":"master","topic":"option-parsing","hashtags":[],"change_id":"Ifa10cd2b8bf81c082d5e3fa846f993871194fea0","subject":"Tighten up testing for sloppy auth version","status":"MERGED","created":"2016-05-05 14:29:12.000000000","updated":"2016-05-08 22:21:10.000000000","submitted":"2016-05-08 22:21:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"477e954296b90ea850c8c39c4e6c20deb5efd1c3","_number":312998,"virtual_id_number":312998,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":2,"date":"2016-05-08 22:21:10.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":2,"date":"2016-05-08 21:30:32.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-05 19:51:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":1,"date":"2016-05-08 21:30:32.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-05 19:51:37.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-05-08 21:30:32.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"},{"updated":"2016-05-08 22:21:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f585fca492525ef51bc398d0dd7d77735ffb1bc5","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2016-05-05 14:29:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d07cfca9e6ffe7c56cf87c88e89f8598a4fa468b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-05 15:41:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/98/312998/1/check/gate-python-swiftclient-docs/c6ab1d3//doc/build/html/ : SUCCESS in 1m 22s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/98/312998/1/check/gate-python-swiftclient-pep8/962aee4/ : SUCCESS in 59s\n- gate-python-swiftclient-python27 http://logs.openstack.org/98/312998/1/check/gate-python-swiftclient-python27/f1cfd63/ : SUCCESS in 58s\n- gate-python-swiftclient-python34 http://logs.openstack.org/98/312998/1/check/gate-python-swiftclient-python34/8194e90/ : SUCCESS in 1m 35s\n- gate-python-swiftclient-pypy http://logs.openstack.org/98/312998/1/check/gate-python-swiftclient-pypy/f5d7d74/ : SUCCESS in 1m 25s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/98/312998/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/11c5b05/ : SUCCESS in 58m 51s\n- gate-swift-dsvm-functional http://logs.openstack.org/98/312998/1/check/gate-swift-dsvm-functional/887ce75/ : SUCCESS in 12m 54s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/98/312998/1/check/gate-swiftclient-dsvm-functional/8f53169/ : SUCCESS in 15m 44s","accounts_in_message":[],"_revision_number":1},{"id":"fa78089b3985dd7cadd006e0ddd5f96eb2e29af6","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-05-05 19:51:37.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nMakes sense enough, and test breaks when I comment out the `elif options.get(\u0027auth_version\u0027) \u003d\u003d \u00272\u0027:` block in service.py. One question, but I\u0027m happy with this as-is.","accounts_in_message":[],"_revision_number":1},{"id":"5697a393dc6cd33f16dd8df802297f47816a7779","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2016-05-06 07:43:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"07a677deeeb7964bbdf2ea8d2302acb9c0dbc528","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-05-08 21:30:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nGood spot :)","accounts_in_message":[],"_revision_number":1},{"id":"0579d60e03c03662035c606c9f13c38dfd30e6f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-08 21:30:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"08aa02c11fd0090b0c3f4ae6390d055505f47ef0","date":"2016-05-08 22:21:10.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"14d8cdfccb37c87e71e832cfdf1c36d5fc75b6c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-08 22:21:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/98/312998/1/gate/gate-python-swiftclient-docs/6774bcc//doc/build/html/ : SUCCESS in 3m 32s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/98/312998/1/gate/gate-python-swiftclient-pep8/5188504/ : SUCCESS in 1m 52s\n- gate-python-swiftclient-python27 http://logs.openstack.org/98/312998/1/gate/gate-python-swiftclient-python27/2009d9e/ : SUCCESS in 1m 50s\n- gate-python-swiftclient-python34 http://logs.openstack.org/98/312998/1/gate/gate-python-swiftclient-python34/36440d2/ : SUCCESS in 3m 06s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/98/312998/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/adf37e9/ : SUCCESS in 50m 31s\n- gate-swift-dsvm-functional http://logs.openstack.org/98/312998/1/gate/gate-swift-dsvm-functional/c213b92/ : SUCCESS in 24m 59s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/98/312998/1/gate/gate-swiftclient-dsvm-functional/1f643a8/ : SUCCESS in 17m 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a0d65e4ccddffbf2b1596332ef67733583554bbc","revisions":{"a0d65e4ccddffbf2b1596332ef67733583554bbc":{"kind":"REWORK","_number":1,"created":"2016-05-05 14:29:12.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/98/312998/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/98/312998/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/98/312998/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/98/312998/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/98/312998/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/98/312998/1"}}},"commit":{"parents":[{"commit":"c3766319b93d60e30f55747f6cfc9ca915ff603c","subject":"Pull option processing out to service.py","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c3766319b93d60e30f55747f6cfc9ca915ff603c"}]}],"author":{"name":"Alistair Coles","email":"alistair.coles@hpe.com","date":"2016-05-05 14:25:16.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistair.coles@hpe.com","date":"2016-05-05 14:25:16.000000000","tz":60},"subject":"Tighten up testing for sloppy auth version","message":"Tighten up testing for sloppy auth version\n\nThe existing test that os-identity-api-version\u003d2 would\nresult in the correct auth_version\u003d2.0 (note 2 -\u003e 2.0)\ndoes not verify the sloppy version handling code path.\nWhen auth, key and user options are all missing the\nauth version is always set to 2.0 so the test will always\npass. Adding auth, key and user options to the test command\nwill cause the test to verify that the os-identity-api-version\noption was used and mapped to 2.0.\n\nChange-Id: Ifa10cd2b8bf81c082d5e3fa846f993871194fea0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a0d65e4ccddffbf2b1596332ef67733583554bbc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a0d65e4ccddffbf2b1596332ef67733583554bbc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}