)]}'
{"swiftclient/service.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"573a0ddb622d3eda25fb28403f48ee0ef3ed6167","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    specified separately for each individual object."},{"line_number":322,"context_line":"    \"\"\""},{"line_number":323,"context_line":"    def __init__(self, object_name, options\u003dNone):"},{"line_number":324,"context_line":"        if not (isinstance(object_name, string_types) and object_name):"},{"line_number":325,"context_line":"            raise SwiftError("},{"line_number":326,"context_line":"                \"Object names must be specified as non-empty strings\""},{"line_number":327,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e550c7d6","line":324,"updated":"2016-07-11 15:06:50.000000000","message":"well it seems like this would be even better as `if object_name and not \u003ctype-check\u003e`?","commit_id":"f86871f94946a2dc9aafc80750674a20e80ae287"},{"author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"change_message_id":"e413bdfe25fcb9b8afb499073952cdca7d892178","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    specified separately for each individual object."},{"line_number":322,"context_line":"    \"\"\""},{"line_number":323,"context_line":"    def __init__(self, object_name, options\u003dNone):"},{"line_number":324,"context_line":"        if not (isinstance(object_name, string_types) and object_name):"},{"line_number":325,"context_line":"            raise SwiftError("},{"line_number":326,"context_line":"                \"Object names must be specified as non-empty strings\""},{"line_number":327,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_5724aa5e","line":324,"in_reply_to":"1aa78d24_e550c7d6","updated":"2016-07-20 22:04:22.000000000","message":"I like your comment suggestion best!","commit_id":"f86871f94946a2dc9aafc80750674a20e80ae287"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6366de7b7d9d15c357763378616936fff35c8a5c","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    specified separately for each individual object."},{"line_number":322,"context_line":"    \"\"\""},{"line_number":323,"context_line":"    def __init__(self, object_name, options\u003dNone):"},{"line_number":324,"context_line":"        if not (isinstance(object_name, string_types) and object_name):"},{"line_number":325,"context_line":"            raise SwiftError("},{"line_number":326,"context_line":"                \"Object names must be specified as non-empty strings\""},{"line_number":327,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b5f6875a","line":324,"in_reply_to":"dada55a8_378656db","updated":"2016-07-21 19:58:06.000000000","message":"I have no idea what this is trying to say?  why did I even touch this code?\n\nIt\u0027s trying to be a guard check on the type?  only strings are allowed, and not empty strings... seems un-pythonic to explicitly disallow string-likes?\n\nBut assuming this code is working for us and doing what we want @tim is right about the boolean logic, and I apparently thought the code was more obvious with if not (and\u0027d set of check that *must all* be true) - maybe we can play with order, but type check followed by value check seems ok to me...","commit_id":"f86871f94946a2dc9aafc80750674a20e80ae287"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d138dcd17bc0cc23069bee90499ebdb1828403d6","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    specified separately for each individual object."},{"line_number":322,"context_line":"    \"\"\""},{"line_number":323,"context_line":"    def __init__(self, object_name, options\u003dNone):"},{"line_number":324,"context_line":"        if not (isinstance(object_name, string_types) and object_name):"},{"line_number":325,"context_line":"            raise SwiftError("},{"line_number":326,"context_line":"                \"Object names must be specified as non-empty strings\""},{"line_number":327,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_378656db","line":324,"in_reply_to":"dada55a8_5724aa5e","updated":"2016-07-20 22:09:34.000000000","message":"I think you guys mean\n\n if not (object_name and \u003ctype-check\u003e):\n\nor\n\n if not object_name or not \u003ctype-check\u003e:\n\nno? I don\u0027t find any of them especially more- or less-readable, personally.","commit_id":"f86871f94946a2dc9aafc80750674a20e80ae287"}]}