)]}'
{"id":"openstack%2Fpython-swiftclient~323150","triplet_id":"openstack%2Fpython-swiftclient~master~I9ad389dd691942dea6db470ca3f0543eb6e9703e","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1581147","hashtags":[],"change_id":"I9ad389dd691942dea6db470ca3f0543eb6e9703e","subject":"Add an option: disable etag check on downloads","status":"MERGED","created":"2016-05-31 06:40:25.000000000","updated":"2016-06-06 10:33:25.000000000","submitted":"2016-06-06 10:33:25.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c44d1313caa73f95657f86894745bd909a83664b","_number":323150,"virtual_id_number":323150,"owner":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":2,"date":"2016-06-06 10:33:25.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"all":[{"value":2,"date":"2016-06-06 06:46:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-02 16:31:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"all":[{"value":1,"date":"2016-06-06 06:46:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-02 16:31:08.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-06-06 06:46:22.000000000","updated_by":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"reviewer":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"state":"REVIEWER"},{"updated":"2016-06-06 10:33:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"61e0fc88c0c860bc5ba389c225f537399603113f","author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"date":"2016-05-31 06:40:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3f437f1796428db8b0a09d05183fa76d6196b938","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-31 07:38:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/50/323150/1/check/gate-python-swiftclient-docs/b779a30//doc/build/html/ : SUCCESS in 3m 07s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/50/323150/1/check/gate-python-swiftclient-pep8/8e584c9/ : SUCCESS in 2m 42s\n- gate-python-swiftclient-python27 http://logs.openstack.org/50/323150/1/check/gate-python-swiftclient-python27/3f36e57/ : SUCCESS in 2m 52s\n- gate-python-swiftclient-python34 http://logs.openstack.org/50/323150/1/check/gate-python-swiftclient-python34/3eafdd2/ : SUCCESS in 2m 03s\n- gate-python-swiftclient-pypy http://logs.openstack.org/50/323150/1/check/gate-python-swiftclient-pypy/d5b3820/ : SUCCESS in 1m 55s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/50/323150/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/9003d57/ : SUCCESS in 56m 07s\n- gate-swift-dsvm-functional http://logs.openstack.org/50/323150/1/check/gate-swift-dsvm-functional/a4d68e5/ : SUCCESS in 14m 01s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/50/323150/1/check/gate-swiftclient-dsvm-functional/3d7640f/ : SUCCESS in 14m 33s","accounts_in_message":[],"_revision_number":1},{"id":"4daa70e63dda20b23c424d65432fb2df8d2985fe","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-06-01 17:47:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(6 comments)\n\nTests make sense, and code looks good. -1 mainly for two things:\n\n- I\u0027d rather present the same interface on download that we have on upload. This means --ignore-checksum instead of --no-md5check (for the CLI), and checksum instead of no_md5check (for the API).\n- Docs need updating, for both the CLI and API. It\u0027d be nice if the man pages and rst/html docs got updated, too, but I really want\n\n swift download --help\n\nand\n\n help(SwiftService.download)\n\nto include the new capability.","accounts_in_message":[],"_revision_number":1},{"id":"4b3f34d68c5d3d28b5bf2d6865ba3dc1bb496a93","author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"date":"2016-06-02 14:54:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"210ddc73114a5f9c14987262bf59e50c836a9aeb","author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"date":"2016-06-02 15:00:35.000000000","message":"Patch Set 2:\n\n\u003e (6 comments)\n \u003e \n \u003e Tests make sense, and code looks good. -1 mainly for two things:\n \u003e \n \u003e - I\u0027d rather present the same interface on download that we have on\n \u003e upload. This means --ignore-checksum instead of --no-md5check (for\n \u003e the CLI), and checksum instead of no_md5check (for the API).\n \u003e - Docs need updating, for both the CLI and API. It\u0027d be nice if the\n \u003e man pages and rst/html docs got updated, too, but I really want\n \u003e \n \u003e swift download --help\n \u003e \n \u003e and\n \u003e \n \u003e help(SwiftService.download)\n \u003e \n \u003e to include the new capability.\n\nThanks for your review, the second patch renamed\nthe option and updated the doc","accounts_in_message":[],"_revision_number":2},{"id":"f2b687f4bd2359e8b65c70f5af9bf81673883aaa","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-06-02 16:31:08.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nThanks for including the other docs!","accounts_in_message":[],"_revision_number":2},{"id":"86e795c61d462b2f06eecbbcee08cf89b46e0ef4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-02 17:49:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/50/323150/2/check/gate-python-swiftclient-docs/8787a87//doc/build/html/ : SUCCESS in 2m 28s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/50/323150/2/check/gate-python-swiftclient-pep8/828c984/ : SUCCESS in 2m 25s\n- gate-python-swiftclient-python27 http://logs.openstack.org/50/323150/2/check/gate-python-swiftclient-python27/9a9581d/ : SUCCESS in 3m 25s\n- gate-python-swiftclient-python34 http://logs.openstack.org/50/323150/2/check/gate-python-swiftclient-python34/b0ac282/ : SUCCESS in 3m 51s\n- gate-python-swiftclient-pypy http://logs.openstack.org/50/323150/2/check/gate-python-swiftclient-pypy/af57593/ : SUCCESS in 3m 32s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/50/323150/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/5f9a51c/ : SUCCESS in 1h 02m 23s\n- gate-swift-dsvm-functional http://logs.openstack.org/50/323150/2/check/gate-swift-dsvm-functional/787141c/ : SUCCESS in 34m 42s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/50/323150/2/check/gate-swiftclient-dsvm-functional/809078a/ : SUCCESS in 30m 45s","accounts_in_message":[],"_revision_number":2},{"id":"5e05501e1615dfea82639c48f085eeb7cd385640","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-06-06 06:46:22.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(2 comments)\n\nLooks good to me. I confirmed this option works in my local environment with an object whose etag mangled by hand. (it was quarantined, when I tested it though)","accounts_in_message":[],"_revision_number":2},{"id":"640610ed446dacbd4d2ab37205d232f02e6f5810","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-06 06:46:27.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ccfda1b04a81f4ca30d839f2f45948d946f6d477","date":"2016-06-06 10:33:25.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"0277647f18b8ab31e07698953cb8d29a8399c74c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-06 10:33:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/50/323150/2/gate/gate-python-swiftclient-docs/5664124//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/50/323150/2/gate/gate-python-swiftclient-pep8/5a31e6d/ : SUCCESS in 1m 15s\n- gate-python-swiftclient-python27 http://logs.openstack.org/50/323150/2/gate/gate-python-swiftclient-python27/b8dd476/ : SUCCESS in 1m 13s\n- gate-python-swiftclient-python34 http://logs.openstack.org/50/323150/2/gate/gate-python-swiftclient-python34/72f5005/ : SUCCESS in 1m 47s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/50/323150/2/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/b3fbe97/ : SUCCESS in 53m 34s\n- gate-swift-dsvm-functional http://logs.openstack.org/50/323150/2/gate/gate-swift-dsvm-functional/3d9945e/ : SUCCESS in 24m 41s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/50/323150/2/gate/gate-swiftclient-dsvm-functional/30a8a52/ : SUCCESS in 11m 46s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"69bf4634b972ef2ee0ec1f015d71223203f0bb1a","revisions":{"c60f32aa75144541a988cb087e30862c08839759":{"kind":"REWORK","_number":1,"created":"2016-05-31 06:40:25.000000000","uploader":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"ref":"refs/changes/50/323150/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/50/323150/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/323150/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/323150/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/323150/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/50/323150/1"}}},"commit":{"parents":[{"commit":"f9d0657e70e9511a2d7b4c63bbf06b138dd0be5e","subject":"Merge \"Support client certificate/key\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f9d0657e70e9511a2d7b4c63bbf06b138dd0be5e"}]}],"author":{"name":"Cheng Li","email":"shcli@cn.ibm.com","date":"2016-05-31 06:32:58.000000000","tz":480},"committer":{"name":"Cheng Li","email":"shcli@cn.ibm.com","date":"2016-05-31 06:32:58.000000000","tz":480},"subject":"Add an option: disable etag check on downloads","message":"Add an option: disable etag check on downloads\n\nThis patch is to add an option of disable etag\ncheck on downloads.\n\nChange-Id: I9ad389dd691942dea6db470ca3f0543eb6e9703e\nCloses-bug: #1581147\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c60f32aa75144541a988cb087e30862c08839759"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c60f32aa75144541a988cb087e30862c08839759"}]},"branch":"refs/heads/master"},"69bf4634b972ef2ee0ec1f015d71223203f0bb1a":{"kind":"REWORK","_number":2,"created":"2016-06-02 14:54:08.000000000","uploader":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"ref":"refs/changes/50/323150/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/50/323150/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/323150/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/323150/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/50/323150/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/50/323150/2"}}},"commit":{"parents":[{"commit":"f9d0657e70e9511a2d7b4c63bbf06b138dd0be5e","subject":"Merge \"Support client certificate/key\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f9d0657e70e9511a2d7b4c63bbf06b138dd0be5e"}]}],"author":{"name":"Cheng Li","email":"shcli@cn.ibm.com","date":"2016-05-31 06:32:58.000000000","tz":480},"committer":{"name":"Cheng Li","email":"shcli@cn.ibm.com","date":"2016-06-02 14:53:18.000000000","tz":480},"subject":"Add an option: disable etag check on downloads","message":"Add an option: disable etag check on downloads\n\nThis patch is to add an option of disable etag\ncheck on downloads.\n\nChange-Id: I9ad389dd691942dea6db470ca3f0543eb6e9703e\nCloses-bug: #1581147\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/69bf4634b972ef2ee0ec1f015d71223203f0bb1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/69bf4634b972ef2ee0ec1f015d71223203f0bb1a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}