)]}'
{"setup.py":[{"author":{"_account_id":22449,"name":"Chaitanya","email":"cshastri@redhat.com","username":"cshastri"},"change_message_id":"2e997f602989a9f0e5b481f275344c8adf6f715c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# THIS FILE IS MANAGED BY THE GLOBAL REQUIREMENTS REPO - DO NOT EDIT"},{"line_number":18,"context_line":"import setuptools, sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if sys.version_info[0] \u003d\u003d 2 and sys.version_info[1] \u003c 7:"},{"line_number":21,"context_line":"    sys.exit(\u0027Sorry, Python \u003c 2.7 is not supported\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6959775a","line":18,"updated":"2016-07-05 08:48:29.000000000","message":"Why are you adding the constraint in setup.py file? AFAIK setup.py file is used only while installing python package.\nReference: https://docs.python.org/2/distutils/setupscript.html#installing-package-data \nAlso, you mentioned in the bug that \"dependency on python\u003e\u003d2.7 should be specified in the setup.cfg\".","commit_id":"d22503120f611936e305e0ad3089c5b1b90bdfa7"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"85a5ac73e379c78f8bb2178f8e18ecdf1e65bafe","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# THIS FILE IS MANAGED BY THE GLOBAL REQUIREMENTS REPO - DO NOT EDIT"},{"line_number":18,"context_line":"import setuptools, sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if sys.version_info[0] \u003d\u003d 2 and sys.version_info[1] \u003c 7:"},{"line_number":21,"context_line":"    sys.exit(\u0027Sorry, Python \u003c 2.7 is not supported\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_8a3903f5","line":18,"in_reply_to":"1aa78d24_6959775a","updated":"2016-07-06 01:49:28.000000000","message":"I tried to find a configuration item to limit python version, but I didn\u0027t find one. Could you please provide a sample, if you know about this?","commit_id":"d22503120f611936e305e0ad3089c5b1b90bdfa7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"494ef202f2d6d26ebcd84ca65fa9872557fe01b4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import setuptools, sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if sys.version_info[0] \u003d\u003d 2 and sys.version_info[1] \u003c 7:"},{"line_number":21,"context_line":"    sys.exit(\u0027Sorry, Python \u003c 2.7 is not supported\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"setuptools.setup("},{"line_number":24,"context_line":"    setup_requires\u003d[\u0027pbr\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_5c909b43","line":21,"updated":"2016-07-05 19:42:09.000000000","message":"Maybe better as\n\n if sys.version_info \u003c (2, 7):\n\n?\n\nFWIW, boto also does a sys.exit [1], while numpy raises a RuntimeError [2]. Both approaches seem reasonable; I\u0027m not sure whether there\u0027s an accepted best-practice in OpenStack.\n\n[1] https://github.com/boto/boto/blob/2.41.0/setup.py#L42\n[2] https://github.com/numpy/numpy/blob/v1.11.1/setup.py#L27","commit_id":"d22503120f611936e305e0ad3089c5b1b90bdfa7"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"86744519db5c7678fd25bec7c4b207e977a44ae1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import setuptools, sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if sys.version_info[0] \u003d\u003d 2 and sys.version_info[1] \u003c 7:"},{"line_number":21,"context_line":"    sys.exit(\u0027Sorry, Python \u003c 2.7 is not supported\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"setuptools.setup("},{"line_number":24,"context_line":"    setup_requires\u003d[\u0027pbr\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_d528cce4","line":21,"in_reply_to":"1aa78d24_55605ca5","updated":"2016-07-06 02:11:03.000000000","message":"Good idea, I am going to add this info in the next patch.","commit_id":"d22503120f611936e305e0ad3089c5b1b90bdfa7"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"85a5ac73e379c78f8bb2178f8e18ecdf1e65bafe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import setuptools, sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if sys.version_info[0] \u003d\u003d 2 and sys.version_info[1] \u003c 7:"},{"line_number":21,"context_line":"    sys.exit(\u0027Sorry, Python \u003c 2.7 is not supported\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"setuptools.setup("},{"line_number":24,"context_line":"    setup_requires\u003d[\u0027pbr\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6ab93779","line":21,"in_reply_to":"1aa78d24_5c909b43","updated":"2016-07-06 01:49:28.000000000","message":"\"sys.version_info \u003c (2, 7)\", this looks more comfortable. I have to say Python is so flexible.\n\nAnd I would keep the current exit format, which is same with boto.\nhttps://docs.python.org/2/library/sys.html#sys.exit","commit_id":"d22503120f611936e305e0ad3089c5b1b90bdfa7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"79b63fde462e69432fd42bb691773ef45310b3fc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import setuptools, sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if sys.version_info[0] \u003d\u003d 2 and sys.version_info[1] \u003c 7:"},{"line_number":21,"context_line":"    sys.exit(\u0027Sorry, Python \u003c 2.7 is not supported\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"setuptools.setup("},{"line_number":24,"context_line":"    setup_requires\u003d[\u0027pbr\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_55605ca5","line":21,"in_reply_to":"1aa78d24_6ab93779","updated":"2016-07-06 01:54:11.000000000","message":"Oh, one comment (in case you\u0027re going to do another patchset anyway): we might want to include something like \"as of version 3.0\" in the error? This would give 2.6 users a clue that they may want something like\n\n pip install \u0027python-swiftclient\u003c\u003d3.0\u0027\n\nwhich should still work. Worst case, I can do it as a follow-up later.","commit_id":"d22503120f611936e305e0ad3089c5b1b90bdfa7"}]}