)]}'
{"tests/unit/test_service.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                responses \u003d [x for x in resp_iter]"},{"line_number":868,"context_line":"                for resp in responses:"},{"line_number":869,"context_line":"                    self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":870,"context_line":"                    self.assertTrue(resp[\u0027success\u0027])"},{"line_number":871,"context_line":"                self.assertEqual(2, len(responses))"},{"line_number":872,"context_line":"                create_container_resp, upload_obj_resp \u003d responses"},{"line_number":873,"context_line":"                self.assertEqual(create_container_resp[\u0027action\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_3cd692c3","line":870,"updated":"2016-07-25 13:25:36.000000000","message":"This is not a cosmetic change. If resp[\u0027success\u0027] \u003d\u003d 1 the test failed before but now passes.","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"dd11d4fd2d98e34d75933e6386d0add8dfd62713","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                responses \u003d [x for x in resp_iter]"},{"line_number":868,"context_line":"                for resp in responses:"},{"line_number":869,"context_line":"                    self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":870,"context_line":"                    self.assertTrue(resp[\u0027success\u0027])"},{"line_number":871,"context_line":"                self.assertEqual(2, len(responses))"},{"line_number":872,"context_line":"                create_container_resp, upload_obj_resp \u003d responses"},{"line_number":873,"context_line":"                self.assertEqual(create_container_resp[\u0027action\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_62ba1825","line":870,"in_reply_to":"dada55a8_3cd692c3","updated":"2016-07-25 16:11:21.000000000","message":"That\u0027s right; however I think resp[\u0027success\u0027] is never 1, always True or False so it should be ok? Same in all other cases?","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"710c49776494dc4f66f24e8cdb19dfaf858ff020","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                responses \u003d [x for x in resp_iter]"},{"line_number":868,"context_line":"                for resp in responses:"},{"line_number":869,"context_line":"                    self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":870,"context_line":"                    self.assertTrue(resp[\u0027success\u0027])"},{"line_number":871,"context_line":"                self.assertEqual(2, len(responses))"},{"line_number":872,"context_line":"                create_container_resp, upload_obj_resp \u003d responses"},{"line_number":873,"context_line":"                self.assertEqual(create_container_resp[\u0027action\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_6cee8a8c","line":870,"in_reply_to":"dada55a8_62ba1825","updated":"2016-07-25 17:04:07.000000000","message":"As I understood it, the test wants to assert that resp[\u0027success\u0027] is a boolean. So if a regression caused resp[\u0027success\u0027] to be  0 or 1 the test would fail (on master).","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"51956b22f7dd4938c9e603d2e946a1e2719228bc","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                responses \u003d [x for x in resp_iter]"},{"line_number":868,"context_line":"                for resp in responses:"},{"line_number":869,"context_line":"                    self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":870,"context_line":"                    self.assertTrue(resp[\u0027success\u0027])"},{"line_number":871,"context_line":"                self.assertEqual(2, len(responses))"},{"line_number":872,"context_line":"                create_container_resp, upload_obj_resp \u003d responses"},{"line_number":873,"context_line":"                self.assertEqual(create_container_resp[\u0027action\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_dbcf4e7d","line":870,"in_reply_to":"dada55a8_6cee8a8c","updated":"2016-07-26 08:10:21.000000000","message":"Thanks Alistair, got it. I was wondering if I missed something. Good point about being regression safe.","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"change_message_id":"5a29eebe466e6058a4f52e07805fe4e2925f80ec","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                responses \u003d [x for x in resp_iter]"},{"line_number":868,"context_line":"                for resp in responses:"},{"line_number":869,"context_line":"                    self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":870,"context_line":"                    self.assertTrue(resp[\u0027success\u0027])"},{"line_number":871,"context_line":"                self.assertEqual(2, len(responses))"},{"line_number":872,"context_line":"                create_container_resp, upload_obj_resp \u003d responses"},{"line_number":873,"context_line":"                self.assertEqual(create_container_resp[\u0027action\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_cd031941","line":870,"in_reply_to":"dada55a8_6cee8a8c","updated":"2016-07-26 04:37:41.000000000","message":"The question now is whether resp[\u0027success\u0027] can be 0 or 1","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"51956b22f7dd4938c9e603d2e946a1e2719228bc","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                responses \u003d [x for x in resp_iter]"},{"line_number":868,"context_line":"                for resp in responses:"},{"line_number":869,"context_line":"                    self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":870,"context_line":"                    self.assertTrue(resp[\u0027success\u0027])"},{"line_number":871,"context_line":"                self.assertEqual(2, len(responses))"},{"line_number":872,"context_line":"                create_container_resp, upload_obj_resp \u003d responses"},{"line_number":873,"context_line":"                self.assertEqual(create_container_resp[\u0027action\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_fb705242","line":870,"in_reply_to":"dada55a8_cd031941","updated":"2016-07-26 08:10:21.000000000","message":"As of today it can\u0027t; however that could change in the future, and in that case it would\u0027nt be detected by these tests anymore.","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1227,"context_line":"                                              \u0027segment_size\u0027: 0,"},{"line_number":1228,"context_line":"                                              \u0027checksum\u0027: True})"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"            self.assertFalse(r[\u0027success\u0027])"},{"line_number":1231,"context_line":"            self.assertIn(\u0027md5 mismatch\u0027, str(r.get(\u0027error\u0027)))"},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":"            self.assertEqual(mock_conn.put_object.call_count, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_1c6d8e04","line":1230,"updated":"2016-07-25 13:25:36.000000000","message":"If r[\u0027success\u0027] is 0 the test failed before but now passes","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"                                              \u0027segment_size\u0027: 0})"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"            self.assertIsNone(r.get(\u0027error\u0027))"},{"line_number":1267,"context_line":"            self.assertTrue(r[\u0027success\u0027])"},{"line_number":1268,"context_line":"            self.assertEqual(r.get(\u0027status\u0027), \u0027skipped-identical\u0027)"},{"line_number":1269,"context_line":"            self.assertEqual(mock_conn.put_object.call_count, 0)"},{"line_number":1270,"context_line":"            self.assertEqual(mock_conn.head_object.call_count, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_5c7706d4","line":1267,"updated":"2016-07-25 13:25:36.000000000","message":"ditto","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"                                              \u0027segment_size\u0027: 10})"},{"line_number":1307,"context_line":""},{"line_number":1308,"context_line":"            self.assertIsNone(r.get(\u0027error\u0027))"},{"line_number":1309,"context_line":"            self.assertTrue(r[\u0027success\u0027])"},{"line_number":1310,"context_line":"            self.assertEqual(\u0027skipped-identical\u0027, r.get(\u0027status\u0027))"},{"line_number":1311,"context_line":"            self.assertEqual(0, mock_conn.put_object.call_count)"},{"line_number":1312,"context_line":"            self.assertEqual([mock.call(\u0027test_c\u0027, \u0027test_o\u0027)],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_1c446e72","line":1309,"updated":"2016-07-25 13:25:36.000000000","message":"ditto","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"                                                  \u0027segment_size\u0027: 10})"},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"            self.assertIsNone(r.get(\u0027error\u0027))"},{"line_number":1356,"context_line":"            self.assertTrue(r[\u0027success\u0027])"},{"line_number":1357,"context_line":"            self.assertEqual(\u0027skipped-identical\u0027, r.get(\u0027status\u0027))"},{"line_number":1358,"context_line":"            self.assertEqual(0, mock_conn.put_object.call_count)"},{"line_number":1359,"context_line":"            self.assertEqual(1, mock_conn.head_object.call_count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_bc33a212","line":1356,"updated":"2016-07-25 13:25:36.000000000","message":"ditto","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1849,"context_line":"                                                       self.opts)"},{"line_number":1850,"context_line":""},{"line_number":1851,"context_line":"        self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":1852,"context_line":"        self.assertTrue(resp[\u0027success\u0027])"},{"line_number":1853,"context_line":"        self.assertEqual(resp[\u0027action\u0027], \u0027download_object\u0027)"},{"line_number":1854,"context_line":"        self.assertEqual(resp[\u0027object\u0027], \u0027test\u0027)"},{"line_number":1855,"context_line":"        self.assertEqual(resp[\u0027path\u0027], \u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_fc3d1ade","line":1852,"updated":"2016-07-25 13:25:36.000000000","message":"ditto","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1884,"context_line":"                                                       options)"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"        self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":1887,"context_line":"        self.assertTrue(resp[\u0027success\u0027])"},{"line_number":1888,"context_line":"        self.assertEqual(resp[\u0027action\u0027], \u0027download_object\u0027)"},{"line_number":1889,"context_line":"        self.assertEqual(resp[\u0027object\u0027], \u0027example/test\u0027)"},{"line_number":1890,"context_line":"        self.assertEqual(resp[\u0027path\u0027], \u0027temp_dir/example/test\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_5c2546c0","line":1887,"updated":"2016-07-25 13:25:36.000000000","message":"ditto","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1904,"context_line":"                                                       options)"},{"line_number":1905,"context_line":""},{"line_number":1906,"context_line":"        self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":1907,"context_line":"        self.assertTrue(resp[\u0027success\u0027])"},{"line_number":1908,"context_line":"        self.assertEqual(resp[\u0027action\u0027], \u0027download_object\u0027)"},{"line_number":1909,"context_line":"        self.assertEqual(resp[\u0027object\u0027], \u0027example/test\u0027)"},{"line_number":1910,"context_line":"        self.assertEqual(resp[\u0027path\u0027], \u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_bc1a827a","line":1907,"updated":"2016-07-25 13:25:36.000000000","message":"ditto","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1924,"context_line":"                                                       options)"},{"line_number":1925,"context_line":""},{"line_number":1926,"context_line":"        self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":1927,"context_line":"        self.assertTrue(resp[\u0027success\u0027])"},{"line_number":1928,"context_line":"        self.assertEqual(resp[\u0027action\u0027], \u0027download_object\u0027)"},{"line_number":1929,"context_line":"        self.assertEqual(resp[\u0027object\u0027], \u0027example/test\u0027)"},{"line_number":1930,"context_line":"        self.assertEqual(resp[\u0027path\u0027], \u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_5c0c2642","line":1927,"updated":"2016-07-25 13:25:36.000000000","message":"ditto","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":1945,"context_line":"                                                       options)"},{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"        self.assertIsNone(resp.get(\u0027error\u0027))"},{"line_number":1948,"context_line":"        self.assertTrue(resp[\u0027success\u0027])"},{"line_number":1949,"context_line":"        self.assertEqual(resp[\u0027action\u0027], \u0027download_object\u0027)"},{"line_number":1950,"context_line":"        self.assertEqual(resp[\u0027object\u0027], \u0027example/test\u0027)"},{"line_number":1951,"context_line":"        self.assertEqual(resp[\u0027path\u0027], \u0027new/dir/test\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_9c069e1e","line":1948,"updated":"2016-07-25 13:25:36.000000000","message":"ditto","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"}],"tests/unit/test_utils.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9f6d37211dfbd5b49e89faa6aaa54799ab3d4893","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @mock.patch.object(u, \u0027TRUE_VALUES\u0027, \u0027hello world\u0027.split())"},{"line_number":32,"context_line":"    def test_config_true_value(self):"},{"line_number":33,"context_line":"        for val in \u0027hello world HELLO WORLD\u0027.split():"},{"line_number":34,"context_line":"            self.assertTrue(u.config_true_value(val))"},{"line_number":35,"context_line":"        self.assertTrue(u.config_true_value(True))"},{"line_number":36,"context_line":"        self.assertFalse(u.config_true_value(\u0027foo\u0027))"},{"line_number":37,"context_line":"        self.assertFalse(u.config_true_value(False))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_5741a138","line":34,"updated":"2016-07-25 13:25:36.000000000","message":"Same as other module - the original author has perhaps intended to verify that the tested value reallt is an instance of the boolean \u0027True\u0027 or \u0027False\u0027","commit_id":"7e6307ebbf20e5afeb43d4b0eb473ee48b869fa2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9276c2e79abeba3bb5ace0a2c6845d798b3db5cb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            self.assertIs(u.config_true_value(val), True)"},{"line_number":35,"context_line":"        self.assertTrue(u.config_true_value(True))"},{"line_number":36,"context_line":"        self.assertFalse(u.config_true_value(\u0027foo\u0027))"},{"line_number":37,"context_line":"        self.assertFalse(u.config_true_value(False))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class TestPrtBytes(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c1cdc6b8","line":37,"updated":"2016-07-25 15:15:52.000000000","message":"you need to revert the remaining 3 changes in this module too","commit_id":"76977115cef89eed4d1cd9744a0aec55cdf8fb87"}]}