)]}'
{"id":"openstack%2Fpython-swiftclient~360725","triplet_id":"openstack%2Fpython-swiftclient~master~I6c2f451009cb03cb78812f54e4ed8566076de821","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1614932","hashtags":[],"change_id":"I6c2f451009cb03cb78812f54e4ed8566076de821","subject":"Convert numeric and boolean header values to strings","status":"MERGED","created":"2016-08-25 18:33:31.000000000","updated":"2016-08-31 00:58:02.000000000","submitted":"2016-08-31 00:58:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a3db779d7a9d0a87b4a109150c6638cc5724c403","_number":360725,"virtual_id_number":360725,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":2,"date":"2016-08-31 00:58:02.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":2,"date":"2016-08-30 21:12:33.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":2,"date":"2016-08-30 23:52:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":1,"date":"2016-08-30 23:52:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-30 21:12:33.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"},{"updated":"2016-08-30 23:52:24.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"},{"updated":"2016-08-31 00:58:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1abab0169be2e286b215602cae91b719a7735282","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-08-25 18:33:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"71d61b725ecec8b5ccfe487389624b7d0d2668c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-25 20:34:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/25/360725/1/check/gate-python-swiftclient-docs-ubuntu-xenial/485f385//doc/build/html/ : SUCCESS in 1m 30s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/25/360725/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/4aaf2a0/ : SUCCESS in 1m 43s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/25/360725/1/check/gate-python-swiftclient-python27-ubuntu-xenial/37d26e0/ : SUCCESS in 1m 29s\n- gate-python-swiftclient-python34 http://logs.openstack.org/25/360725/1/check/gate-python-swiftclient-python34/d799489/ : SUCCESS in 4m 25s\n- gate-python-swiftclient-python35 http://logs.openstack.org/25/360725/1/check/gate-python-swiftclient-python35/88fde4a/ : SUCCESS in 6m 40s\n- gate-python-swiftclient-pypy http://logs.openstack.org/25/360725/1/check/gate-python-swiftclient-pypy/467d583/ : SUCCESS in 7m 06s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/25/360725/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/fcb2748/ : SUCCESS in 1h 15m 49s\n- gate-swift-dsvm-functional http://logs.openstack.org/25/360725/1/check/gate-swift-dsvm-functional/4d8e9e7/ : SUCCESS in 15m 51s\n- gate-swift-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/25/360725/1/check/gate-swift-dsvm-functional-identity-v3-only-nv/cb32fd3/ : SUCCESS in 27m 04s (non-voting)\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/25/360725/1/check/gate-swiftclient-dsvm-functional/e711550/ : SUCCESS in 23m 38s\n- gate-swiftclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/25/360725/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-nv/4645781/ : SUCCESS in 24m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"56e277bba753a18d902c27668c986a3487642021","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-08-30 21:12:33.000000000","message":"Patch Set 1: Code-Review+2\n\nThis seems like a reasonable compromise to me.","accounts_in_message":[],"_revision_number":1},{"id":"0c295098f9227367c525f05e9d51b6bd9cf87ade","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2016-08-30 23:52:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nNice one Tim, and this should also make ironic happy.","accounts_in_message":[],"_revision_number":1},{"id":"7da87b81c2ef28251eac1eea80621f652525b837","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-30 23:52:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d97aeac834dd89d925f4dcabbbee6ebc3a043416","date":"2016-08-31 00:58:02.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"98c7f88ba7ceff609fd72161dadd671526654ca2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-31 00:58:02.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/25/360725/1/gate/gate-python-swiftclient-docs-ubuntu-xenial/7dbf4a9//doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/25/360725/1/gate/gate-python-swiftclient-pep8-ubuntu-xenial/5139a84/ : SUCCESS in 2m 02s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/25/360725/1/gate/gate-python-swiftclient-python27-ubuntu-xenial/03ee0c9/ : SUCCESS in 1m 38s\n- gate-python-swiftclient-python34 http://logs.openstack.org/25/360725/1/gate/gate-python-swiftclient-python34/dd63dfe/ : SUCCESS in 3m 23s\n- gate-python-swiftclient-python35 http://logs.openstack.org/25/360725/1/gate/gate-python-swiftclient-python35/663a55e/ : SUCCESS in 2m 52s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/25/360725/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/cd792d9/ : SUCCESS in 1h 05m 01s\n- gate-swift-dsvm-functional http://logs.openstack.org/25/360725/1/gate/gate-swift-dsvm-functional/53dafae/ : SUCCESS in 15m 47s\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/25/360725/1/gate/gate-swiftclient-dsvm-functional/73acc66/ : SUCCESS in 16m 49s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ab60e08e2e34ac4a87bc6c1701c6ace69bb392cf","revisions":{"ab60e08e2e34ac4a87bc6c1701c6ace69bb392cf":{"kind":"REWORK","_number":1,"created":"2016-08-25 18:33:31.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/25/360725/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/25/360725/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/25/360725/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/25/360725/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/25/360725/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/25/360725/1"}}},"commit":{"parents":[{"commit":"5acefd27e4e4de01414cc67f6652cc946b51957b","subject":"Merge \"Strip leading/trailing whitespace from headers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/5acefd27e4e4de01414cc67f6652cc946b51957b"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2016-08-25 17:51:29.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2016-08-25 18:32:08.000000000","tz":-420},"subject":"Convert numeric and boolean header values to strings","message":"Convert numeric and boolean header values to strings\n\nRecently, requests got a bit more picky about what types of data it will\naccept as header values [1]. The reasons for this are generally sound;\nstr()ing arbitrary objects just before pushing them out a socket may not\ndo what the developer wanted/expected.\n\nHowever, there are a few standard types that developers may be sending\nthat we should convert for them as a convenience. Now, we\u0027ll convert all\nint, float, and bool values to strings before sending them on to\nrequests.\n\nChange-Id: I6c2f451009cb03cb78812f54e4ed8566076de821\nCloses-Bug: 1614932\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ab60e08e2e34ac4a87bc6c1701c6ace69bb392cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ab60e08e2e34ac4a87bc6c1701c6ace69bb392cf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}