)]}'
{"id":"openstack%2Fpython-swiftclient~365834","triplet_id":"openstack%2Fpython-swiftclient~master~I9c8a5b41e2c3212bd8b1ada9b4b7127786bf200a","project":"openstack/python-swiftclient","branch":"master","topic":"cleancode","hashtags":[],"change_id":"I9c8a5b41e2c3212bd8b1ada9b4b7127786bf200a","subject":"Clean imports in code","status":"ABANDONED","created":"2016-09-06 03:40:46.000000000","updated":"2016-09-27 00:56:46.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4f62e8ed9f580e9cfa5b50c30cf0c460ca67a0d5","_number":365834,"virtual_id_number":365834,"owner":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-09-07 03:25:32.000000000","_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},{"value":1,"date":"2016-09-06 09:04:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-07 06:51:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":-2,"date":"2016-09-26 19:00:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-06 09:04:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-07 06:51:02.000000000","updated_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"reviewer":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"state":"REVIEWER"},{"updated":"2016-09-26 19:00:13.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"}],"messages":[{"id":"c41690f756a06d9db8bb28d8e44e9ac826c3b55a","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-09-06 03:40:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aed1735e48988958f82b90e8f9797c4ba0823c2f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 04:56:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/34/365834/1/check/gate-python-swiftclient-docs-ubuntu-xenial/70fa030//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/34/365834/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/fd90210/ : SUCCESS in 2m 08s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/34/365834/1/check/gate-python-swiftclient-python27-ubuntu-xenial/b588482/ : SUCCESS in 2m 07s\n- gate-python-swiftclient-python34 http://logs.openstack.org/34/365834/1/check/gate-python-swiftclient-python34/e3ae873/ : SUCCESS in 3m 02s\n- gate-python-swiftclient-python35 http://logs.openstack.org/34/365834/1/check/gate-python-swiftclient-python35/416c6e2/ : SUCCESS in 3m 10s\n- gate-python-swiftclient-pypy http://logs.openstack.org/34/365834/1/check/gate-python-swiftclient-pypy/667b725/ : SUCCESS in 1m 42s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/34/365834/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/54ac0a7/ : SUCCESS in 1h 15m 09s\n- gate-swift-dsvm-functional http://logs.openstack.org/34/365834/1/check/gate-swift-dsvm-functional/532a157/ : SUCCESS in 15m 45s\n- gate-swift-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/34/365834/1/check/gate-swift-dsvm-functional-identity-v3-only-nv/f680331/ : SUCCESS in 15m 11s (non-voting)\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/34/365834/1/check/gate-swiftclient-dsvm-functional/182cb5b/ : SUCCESS in 21m 38s\n- gate-swiftclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/34/365834/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-nv/5bbd009/ : SUCCESS in 21m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d038dbc61829b0bc6087b944fddefc05281064cb","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2016-09-06 07:37:02.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)\n\nBummer that the H302 hacking check has been removed: https://review.openstack.org/#/c/142586/1/HACKING.rst,cm\n\nTherefore there is no style-check on this patch.","accounts_in_message":[],"_revision_number":1},{"id":"f41d2b1cb1de74a11f4b4245d30236ccee90650c","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-09-06 07:49:20.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nThanks for reviewing this patch :-)","accounts_in_message":[],"_revision_number":1},{"id":"916d1416e5fee9b49c448661b9eff6bab0734a80","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-09-06 07:49:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e0c7f128454ce894e8c4eef89b923923f8776a9d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 09:04:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/34/365834/2/check/gate-python-swiftclient-docs-ubuntu-xenial/6908798//doc/build/html/ : SUCCESS in 2m 11s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/34/365834/2/check/gate-python-swiftclient-pep8-ubuntu-xenial/314999f/ : SUCCESS in 1m 13s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/34/365834/2/check/gate-python-swiftclient-python27-ubuntu-xenial/f6510c7/ : SUCCESS in 2m 04s\n- gate-python-swiftclient-python34 http://logs.openstack.org/34/365834/2/check/gate-python-swiftclient-python34/3ec85c4/ : SUCCESS in 1m 43s\n- gate-python-swiftclient-python35 http://logs.openstack.org/34/365834/2/check/gate-python-swiftclient-python35/c784f01/ : SUCCESS in 1m 59s\n- gate-python-swiftclient-pypy http://logs.openstack.org/34/365834/2/check/gate-python-swiftclient-pypy/ef7c033/ : SUCCESS in 1m 38s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/34/365834/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/a75611c/ : SUCCESS in 1h 11m 30s\n- gate-swift-dsvm-functional http://logs.openstack.org/34/365834/2/check/gate-swift-dsvm-functional/f136834/ : SUCCESS in 27m 13s\n- gate-swift-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/34/365834/2/check/gate-swift-dsvm-functional-identity-v3-only-nv/d40f27e/ : SUCCESS in 28m 33s (non-voting)\n- gate-swiftclient-dsvm-functional http://logs.openstack.org/34/365834/2/check/gate-swiftclient-dsvm-functional/8944b56/ : SUCCESS in 12m 28s\n- gate-swiftclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/34/365834/2/check/gate-swiftclient-dsvm-functional-identity-v3-only-nv/bada442/ : SUCCESS in 26m 29s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9666a3f6b1dc6fd7c0aa8be40bc8b453adf56208","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2016-09-06 20:11:50.000000000","message":"Patch Set 2:\n\nI hadn\u0027t realized that H302 was removed?  I hope that everyone agrees that we lint or don\u0027t care.\n\nthere was a discussion about this topic on https://review.openstack.org/#/c/361952/","accounts_in_message":[],"_revision_number":2},{"id":"0f0a8c09a13620559ac1cae6138dba02b16ed3f0","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-09-07 03:25:32.000000000","message":"Patch Set 2:\n\n\u003e I hadn\u0027t realized that H302 was removed?  I hope that everyone\n \u003e agrees that we lint or don\u0027t care.\n \u003e \n \u003e there was a discussion about this topic on https://review.openstack.org/#/c/361952/\n\nHi Clay (Swift core-review),\nThe question is why didn\u0027t you give -2 for this patch?\nAs I mentioned in the commit message that this is just Openstack *guide lines* not requires all projects to follow. I contribute the same thing (topic:cleancode AND status:merged) to others project and they are almost followed the guide line. So, It is up to your decision.","accounts_in_message":[],"_revision_number":2},{"id":"86ce6680ed150c6f17fa5bec1f9671f96fc43719","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2016-09-07 06:51:02.000000000","message":"Patch Set 2: Code-Review+1\n\n@Clay: the hacking check itself has been removed a while ago due to problems with the test itself (https://review.openstack.org/#/c/142586/), but the guideline still asks to import modules, not objects.\n\nI agree with you, normally I wouldn\u0027t care because it\u0027s annoying, but I still think it\u0027s an good idea to follow the guidelines. On the other hand, we could also postpone this and someone re-adds a H302 check before merging it.\n\n+1 for now because the code itself LGTM, but this might need more discussions.","accounts_in_message":[],"_revision_number":2},{"id":"34cc461eaaa805ff5822b0dbb0ae4b998bce876d","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-09-08 06:50:13.000000000","message":"Patch Set 2:\n\n\u003e @Clay: the hacking check itself has been removed a while ago due to\n \u003e problems with the test itself (https://review.openstack.org/#/c/142586/),\n \u003e but the guideline still asks to import modules, not objects.\n \u003e \n \u003e I agree with you, normally I wouldn\u0027t care because it\u0027s annoying,\n \u003e but I still think it\u0027s an good idea to follow the guidelines. On\n \u003e the other hand, we could also postpone this and someone re-adds a\n \u003e H302 check before merging it.\n \u003e \n \u003e +1 for now because the code itself LGTM, but this might need more\n \u003e discussions.\n\nThanks for your info and confirmation, Christian.\nI totally agree about that. So, please perform next steps that you feel it is reasonable. Thanks again!","accounts_in_message":[],"_revision_number":2},{"id":"25ba07b22d0f37a574ddd8808a3afc163d2661e8","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-09-24 14:12:10.000000000","message":"Patch Set 2:\n\n@Christian, Clay:\nHow is about status of this patch?","accounts_in_message":[],"_revision_number":2},{"id":"ba941b3fe71737f172d2bb6512aa4541175d6b43","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2016-09-26 18:41:56.000000000","message":"Patch Set 2: Code-Review+1\n\nI recuse myself from any further opinions on this change\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2016-September/104173.html","accounts_in_message":[],"_revision_number":2},{"id":"d2f89d1aa8ff6e431f37ba5a1c4daa584ebdeeaa","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2016-09-26 18:41:58.000000000","message":"Removed the following votes:\n\n* Code-Review+1 by Clay Gerrard \u003cclay.gerrard@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"cc0f85e494574f9747ecf61621188ec612170084","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2016-09-26 19:00:13.000000000","message":"Patch Set 2: Code-Review-2\n\nI\u0027d prefer that this not merge. Many of my reasons are captured in the thread that Clay linked. This is not a comment on the author\u0027s code quality.\n\nWithout any lint checking on this, it\u0027s not something we can validate or keep consistent, so I\u0027d prefer to keep the code churn down.","accounts_in_message":[],"_revision_number":2},{"id":"cc3fe4ac46b7b47af682c88819feedc62c76cfe0","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-09-27 00:56:46.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a6cea3272f55d0d98959f8399ad70df3aafca243","revisions":{"bbc4ce827d27384794ba9f1c726d154ff0637f44":{"kind":"REWORK","_number":1,"created":"2016-09-06 03:40:46.000000000","uploader":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"ref":"refs/changes/34/365834/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/34/365834/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/34/365834/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/34/365834/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/34/365834/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/34/365834/1"}}},"commit":{"parents":[{"commit":"0feb83a00cd9b54efab2fcf4043d65112d06f95c","subject":"Merge \"Change Examples from headings to topics\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0feb83a00cd9b54efab2fcf4043d65112d06f95c"}]}],"author":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-09-06 03:37:48.000000000","tz":420},"committer":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-09-06 03:37:48.000000000","tz":420},"subject":"Clean imports in code","message":"Clean imports in code\n\nThis patch set modifies lines which are importing objects\ninstead of modules. As per openstack import guide lines, user should\nimport modules in a file not objects.\n\nhttp://docs.openstack.org/developer/hacking/#imports\n\nChange-Id: I9c8a5b41e2c3212bd8b1ada9b4b7127786bf200a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/bbc4ce827d27384794ba9f1c726d154ff0637f44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/bbc4ce827d27384794ba9f1c726d154ff0637f44"}]},"branch":"refs/heads/master"},"a6cea3272f55d0d98959f8399ad70df3aafca243":{"kind":"REWORK","_number":2,"created":"2016-09-06 07:49:48.000000000","uploader":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"ref":"refs/changes/34/365834/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/34/365834/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/34/365834/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/34/365834/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/34/365834/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/34/365834/2"}}},"commit":{"parents":[{"commit":"0feb83a00cd9b54efab2fcf4043d65112d06f95c","subject":"Merge \"Change Examples from headings to topics\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0feb83a00cd9b54efab2fcf4043d65112d06f95c"}]}],"author":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-09-06 03:37:48.000000000","tz":420},"committer":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-09-06 07:47:03.000000000","tz":420},"subject":"Clean imports in code","message":"Clean imports in code\n\nThis patch set modifies lines which are importing objects\ninstead of modules. As per openstack import guide lines, user should\nimport modules in a file not objects.\n\nhttp://docs.openstack.org/developer/hacking/#imports\n\nChange-Id: I9c8a5b41e2c3212bd8b1ada9b4b7127786bf200a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a6cea3272f55d0d98959f8399ad70df3aafca243"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a6cea3272f55d0d98959f8399ad70df3aafca243"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}