)]}'
{"swiftclient/utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"865494f492d6448ced8a451b8000cfcfb447e215","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    :param absolute: if True then the seconds parameter is interpreted as an"},{"line_number":81,"context_line":"        absolute Unix time, otherwise seconds is interpreted as a relative time"},{"line_number":82,"context_line":"        offset from current time."},{"line_number":83,"context_line":"    :raises: ValueError if seconds is not a whole number or path is not to"},{"line_number":84,"context_line":"        an object."},{"line_number":85,"context_line":"    :return: the path portion of a temporary URL"},{"line_number":86,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_4531e3eb","line":83,"updated":"2016-09-09 18:41:11.000000000","message":"I\u0027m actually not opposed to enforcing a positive integer here; I\u0027m not sure I see much value in allowing the creation of an already-invalid tempurl (ignoring for a moment possible clock-skew between client and server).","commit_id":"07e8f288b13f7c5e67fd073f2bfba7b7a810cdfc"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"865494f492d6448ced8a451b8000cfcfb447e215","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    if not absolute:"},{"line_number":116,"context_line":"        expiration \u003d int(time.time() + seconds)"},{"line_number":117,"context_line":"    else:"},{"line_number":118,"context_line":"        expiration \u003d seconds"},{"line_number":119,"context_line":"    hmac_body \u003d u\u0027\\n\u0027.join([method.upper(), str(expiration), path_for_body])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # Encode to UTF-8 for py3 compatibility"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_25621fd9","line":118,"updated":"2016-09-09 18:41:11.000000000","message":"I wonder whether it would be worth emitting a warning if seconds \u003c time.time()...","commit_id":"07e8f288b13f7c5e67fd073f2bfba7b7a810cdfc"}],"tests/unit/test_utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"865494f492d6448ced8a451b8000cfcfb447e215","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        with self.assertRaises(ValueError) as exc_manager:"},{"line_number":194,"context_line":"            u.generate_temp_url(self.url, \u00271.1\u0027, self.key, self.method)"},{"line_number":195,"context_line":"        self.assertEqual(exc_manager.exception.args[0],"},{"line_number":196,"context_line":"                         \u0027seconds must be a whole number\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def test_generate_temp_url_bad_path(self):"},{"line_number":199,"context_line":"        with self.assertRaises(ValueError) as exc_manager:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_c5ced3b3","line":196,"updated":"2016-09-09 18:41:11.000000000","message":"This seems to be begging for a loop, or at least a helper function.\n\nDo we want some positive tests, verifying that inputs like\n\n 1\n 1.0\n \u00270\u0027\n\nare all allowed?","commit_id":"07e8f288b13f7c5e67fd073f2bfba7b7a810cdfc"}]}
