)]}'
{"id":"openstack%2Fpython-swiftclient~373737","triplet_id":"openstack%2Fpython-swiftclient~master~If62e3f68698527756879471bde0139bb6bef9360","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1475722","hashtags":[],"change_id":"If62e3f68698527756879471bde0139bb6bef9360","subject":"Replace MagicMock with Mock class","status":"ABANDONED","created":"2016-09-21 06:39:25.000000000","updated":"2016-12-23 09:52:13.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e14275c85b9c236cfe2727fc0beaf9c0de6e4b60","_number":373737,"virtual_id_number":373737,"owner":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-09-21 07:51:25.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2016-09-21 19:51:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-21 07:51:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-21 19:51:34.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"43b7fe9b53a597bba559d81ea6577d01ddcd9eba","author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"date":"2016-09-21 06:39:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4922c7db8e14d9014aa55195a625a8047af6e7a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 07:51:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/37/373737/1/check/gate-python-swiftclient-docs-ubuntu-xenial/62573b6//doc/build/html/ : SUCCESS in 1m 25s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/37/373737/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/8214462/ : SUCCESS in 1m 30s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/37/373737/1/check/gate-python-swiftclient-python27-ubuntu-xenial/372ea86/ : FAILURE in 1m 57s\n- gate-python-swiftclient-python34 http://logs.openstack.org/37/373737/1/check/gate-python-swiftclient-python34/b690d6d/ : FAILURE in 2m 34s\n- gate-python-swiftclient-python35 http://logs.openstack.org/37/373737/1/check/gate-python-swiftclient-python35/5584f72/ : FAILURE in 4m 07s\n- gate-python-swiftclient-pypy http://logs.openstack.org/37/373737/1/check/gate-python-swiftclient-pypy/d4910be/ : FAILURE in 2m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/37/373737/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/50d70e4/ : SUCCESS in 1h 10m 28s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/37/373737/1/check/gate-swift-dsvm-functional-ubuntu-xenial/9c25271/ : SUCCESS in 21m 00s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/37/373737/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/1464b62/ : SUCCESS in 17m 12s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/37/373737/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/441005c/ : SUCCESS in 13m 38s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/37/373737/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/9be69e4/ : SUCCESS in 13m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3a9b3a81c09e90c90c46eef46166de64a092efa4","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-09-21 19:51:34.000000000","message":"Patch Set 1: Code-Review-2\n\nMagicMock is used by default when using mock.patch -- see https://docs.python.org/dev/library/unittest.mock.html#unittest.mock.patch -- so there are actually a whole lot more MagicMock uses than just this.\n\nFurther, just doing the first half\n\n\u003e Any usage should be replaced with the Mock class\n\nwithout doing the second\n\n\u003e and explicit attributes should be set on it.\n\nbreaks tests where we were expecting exactly the behavior of MagicMock.\n\nI\u0027m not convinced this is a productive use of time, even if it would have saved us from various intermittent failures similar to the one described in bug 1480223.\n\nFWIW, I\u0027d much rather see progress on real problems users face, like\n\n* over-zealous logging (bug 1213179),\n* aborting concurrent and future segment uploads when one fails (bug 1527017),\n* downloading large objects concurrently (bug 1621562), or even just\n* adding an --exclude option (bug 1532885).","accounts_in_message":[],"_revision_number":1},{"id":"749670270c1e9a8481fa75b52d23ef3ca92d374e","author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"date":"2016-12-23 09:52:13.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cb6bb638217619ff1b9f4d55d44e2cc4d82edb95","revisions":{"cb6bb638217619ff1b9f4d55d44e2cc4d82edb95":{"kind":"REWORK","_number":1,"created":"2016-09-21 06:39:25.000000000","uploader":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"ref":"refs/changes/37/373737/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/37/373737/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/37/373737/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/37/373737/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/37/373737/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/37/373737/1"}}},"commit":{"parents":[{"commit":"27f9178ec89259553a770349e0192b0981bdb956","subject":"Merge \"Update help text around container ACL syntax\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/27f9178ec89259553a770349e0192b0981bdb956"}]}],"author":{"name":"Sharat Sharma","email":"sharat.sharma@nectechnologies.in","date":"2016-09-21 06:38:01.000000000","tz":330},"committer":{"name":"Sharat Sharma","email":"sharat.sharma@nectechnologies.in","date":"2016-09-21 06:38:54.000000000","tz":330},"subject":"Replace MagicMock with Mock class","message":"Replace MagicMock with Mock class\n\nMagicMock magically allow things to pass. Any usage should be\nreplaced with the Mock class and explicit attributes should\nbe set on it.\n\nChange-Id: If62e3f68698527756879471bde0139bb6bef9360\nCloses-Bug: #1475722\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/cb6bb638217619ff1b9f4d55d44e2cc4d82edb95"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/cb6bb638217619ff1b9f4d55d44e2cc4d82edb95"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}