)]}'
{"id":"openstack%2Fpython-swiftclient~391509","triplet_id":"openstack%2Fpython-swiftclient~master~I1c96b76d90a78b7a10ffe63e4a7440c8f579147c","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1213179","hashtags":[],"change_id":"I1c96b76d90a78b7a10ffe63e4a7440c8f579147c","subject":"Low-level API: Don\u0027t log just before raising an exception","status":"MERGED","created":"2016-10-28 14:50:18.000000000","updated":"2016-10-28 17:37:57.000000000","submitted":"2016-10-28 17:37:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d28a6c7c7a3b981549716348af081bab77210b62","_number":391509,"virtual_id_number":391509,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":2,"date":"2016-10-28 17:37:57.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21231,"name":"Bryan Keller","email":"kellerbr@us.ibm.com","username":"bkeller"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":2,"date":"2016-10-28 15:47:04.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21231,"name":"Bryan Keller","email":"kellerbr@us.ibm.com","username":"bkeller"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21231,"name":"Bryan Keller","email":"kellerbr@us.ibm.com","username":"bkeller"},{"value":1,"date":"2016-10-28 15:48:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":21231,"name":"Bryan Keller","email":"kellerbr@us.ibm.com","username":"bkeller"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-28 15:10:44.000000000","updated_by":{"_account_id":21231,"name":"Bryan Keller","email":"kellerbr@us.ibm.com","username":"bkeller"},"reviewer":{"_account_id":21231,"name":"Bryan Keller","email":"kellerbr@us.ibm.com","username":"bkeller"},"state":"REVIEWER"},{"updated":"2016-10-28 15:47:04.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"},{"updated":"2016-10-28 17:37:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9a396b7133f646253a44138781e1696a539c9921","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-10-28 14:50:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c9e740adc2d6cbc95be5206e8ddda64e5f2d92a7","author":{"_account_id":21231,"name":"Bryan Keller","email":"kellerbr@us.ibm.com","username":"bkeller"},"date":"2016-10-28 15:10:44.000000000","message":"Patch Set 1: Code-Review+1\n\nSwiftclient is such a jerk","accounts_in_message":[],"_revision_number":1},{"id":"a5e547fb2469d35741c23895a04208a6c796441b","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-10-28 15:24:00.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Tim, this seems to be a pretty clear cut thing.","accounts_in_message":[],"_revision_number":1},{"id":"77f773eed379e4120bf7700429e3439245422392","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-10-28 15:26:58.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nActually, it\u0027s the right thing to do, but now we have unused variables...","accounts_in_message":[],"_revision_number":1},{"id":"3b7f4f2cb14d4745ebe3e2e3c7e3cab7a4044056","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-28 15:31:23.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/391509/1/check/gate-python-swiftclient-docs-ubuntu-xenial/46a0425//doc/build/html/ : SUCCESS in 40s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/09/391509/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/c6c5508/ : FAILURE in 39s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/09/391509/1/check/gate-python-swiftclient-python27-ubuntu-xenial/328815f/ : SUCCESS in 42s\n- gate-python-swiftclient-python34 http://logs.openstack.org/09/391509/1/check/gate-python-swiftclient-python34/99c3758/ : SUCCESS in 3m 02s\n- gate-python-swiftclient-python35 http://logs.openstack.org/09/391509/1/check/gate-python-swiftclient-python35/55423a4/ : SUCCESS in 1m 10s\n- gate-python-swiftclient-pypy http://logs.openstack.org/09/391509/1/check/gate-python-swiftclient-pypy/191b4db/ : SUCCESS in 1m 30s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/09/391509/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient/a5f6369/ : SUCCESS in 40m 50s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/09/391509/1/check/gate-swift-dsvm-functional-ubuntu-xenial/0cac48e/ : SUCCESS in 15m 41s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/09/391509/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/b43977a/ : SUCCESS in 15m 46s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/09/391509/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/87fafa6/ : SUCCESS in 12m 21s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/09/391509/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/5acb92b/ : SUCCESS in 12m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8c7444c923ed277bdbb4c5ba034987704770d9b8","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-10-28 15:37:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d90dbb604f1495a0d70c310db40be9a2e892fd0c","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2016-10-28 15:47:04.000000000","message":"Patch Set 2: Code-Review+2\n\nCheers.","accounts_in_message":[],"_revision_number":2},{"id":"f3c9834c65b965d2fb331db1cb31733d0fa7e8cf","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-10-28 15:48:39.000000000","message":"Patch Set 2: Workflow+1\n\nIt\u0027s tiny, it\u0027s better; we\u0027re good.","accounts_in_message":[],"_revision_number":2},{"id":"914ee52ed875d35bc944f5b3ef3cbf08008e12f2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-28 16:35:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/391509/2/check/gate-python-swiftclient-docs-ubuntu-xenial/1642f65//doc/build/html/ : SUCCESS in 40s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/09/391509/2/check/gate-python-swiftclient-pep8-ubuntu-xenial/cbcc102/ : SUCCESS in 42s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/09/391509/2/check/gate-python-swiftclient-python27-ubuntu-xenial/5af80dc/ : SUCCESS in 1m 14s\n- gate-python-swiftclient-python34 http://logs.openstack.org/09/391509/2/check/gate-python-swiftclient-python34/a0dc555/ : SUCCESS in 3m 14s\n- gate-python-swiftclient-python35 http://logs.openstack.org/09/391509/2/check/gate-python-swiftclient-python35/2429c7c/ : SUCCESS in 1m 13s\n- gate-python-swiftclient-pypy http://logs.openstack.org/09/391509/2/check/gate-python-swiftclient-pypy/8e92303/ : FAILURE in 1m 00s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/09/391509/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient/2f7845e/ : SUCCESS in 57m 35s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/09/391509/2/check/gate-swift-dsvm-functional-ubuntu-xenial/a5b9084/ : SUCCESS in 15m 59s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/09/391509/2/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/f796cf0/ : SUCCESS in 16m 14s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/09/391509/2/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/c50cbdd/ : SUCCESS in 12m 15s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/09/391509/2/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/11354c2/ : SUCCESS in 12m 07s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c4c83c108c19391652087fe035a0e0941d4ff0c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-28 16:35:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"1b5f7798cc5b4e466411d25d52c9050e3b523994","date":"2016-10-28 17:37:57.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"1d4c4890b86c5debd518587834202c042f95d77d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-28 17:37:57.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/391509/2/gate/gate-python-swiftclient-docs-ubuntu-xenial/52cb317//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/09/391509/2/gate/gate-python-swiftclient-pep8-ubuntu-xenial/17b0d93/ : SUCCESS in 40s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/09/391509/2/gate/gate-python-swiftclient-python27-ubuntu-xenial/1953d31/ : SUCCESS in 41s\n- gate-python-swiftclient-python34 http://logs.openstack.org/09/391509/2/gate/gate-python-swiftclient-python34/4d8a962/ : SUCCESS in 1m 16s\n- gate-python-swiftclient-python35 http://logs.openstack.org/09/391509/2/gate/gate-python-swiftclient-python35/251f344/ : SUCCESS in 1m 10s\n- gate-tempest-dsvm-neutron-src-python-swiftclient http://logs.openstack.org/09/391509/2/gate/gate-tempest-dsvm-neutron-src-python-swiftclient/5350059/ : SUCCESS in 40m 00s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/09/391509/2/gate/gate-swift-dsvm-functional-ubuntu-xenial/75db525/ : SUCCESS in 16m 12s\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/09/391509/2/gate/gate-swiftclient-dsvm-functional-ubuntu-xenial/a9f38cd/ : SUCCESS in 12m 14s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"481f74caf1ffc649128bb8db84ac9104304420a9","revisions":{"d68569a55a28596f976a6c4bd287d0457bb9502a":{"kind":"REWORK","_number":1,"created":"2016-10-28 14:50:18.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/09/391509/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/09/391509/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/391509/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/391509/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/391509/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/09/391509/1"}}},"commit":{"parents":[{"commit":"e9887703d09bb42ddc3ab1f38855286f8d569ad6","subject":"Merge \"Adding keystoneauth sessions support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e9887703d09bb42ddc3ab1f38855286f8d569ad6"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2016-10-28 10:19:35.000000000","tz":120},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2016-10-28 14:49:37.000000000","tz":120},"subject":"Low-level API: Don\u0027t log just before raising an exception","message":"Low-level API: Don\u0027t log just before raising an exception\n\nThe only logging we should do is when we\u0027ve encountered a problem *and\nwe\u0027ve dealt with it ourselves*. When we\u0027re raising an exception, it\nshould be up to the caller to decide whether to log anything about it.\n\nAnything else is just rude.\n\nChange-Id: I1c96b76d90a78b7a10ffe63e4a7440c8f579147c\nCloses-Bug:  1213179\nRelated-Bug: 1202229\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/d68569a55a28596f976a6c4bd287d0457bb9502a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/d68569a55a28596f976a6c4bd287d0457bb9502a"}]},"branch":"refs/heads/master"},"481f74caf1ffc649128bb8db84ac9104304420a9":{"kind":"REWORK","_number":2,"created":"2016-10-28 15:37:26.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/09/391509/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/09/391509/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/391509/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/391509/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/09/391509/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/09/391509/2"}}},"commit":{"parents":[{"commit":"e9887703d09bb42ddc3ab1f38855286f8d569ad6","subject":"Merge \"Adding keystoneauth sessions support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/e9887703d09bb42ddc3ab1f38855286f8d569ad6"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2016-10-28 10:19:35.000000000","tz":120},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2016-10-28 15:37:37.000000000","tz":120},"subject":"Low-level API: Don\u0027t log just before raising an exception","message":"Low-level API: Don\u0027t log just before raising an exception\n\nThe only logging we should do is when we\u0027ve encountered a problem *and\nwe\u0027ve dealt with it ourselves*. When we\u0027re raising an exception, it\nshould be up to the caller to decide whether to log anything about it.\n\nAnything else is just rude.\n\nChange-Id: I1c96b76d90a78b7a10ffe63e4a7440c8f579147c\nCloses-Bug:  1213179\nRelated-Bug: 1202229\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/481f74caf1ffc649128bb8db84ac9104304420a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/481f74caf1ffc649128bb8db84ac9104304420a9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}