)]}'
{"tools/tox_install.sh":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0aa5aa97330f1ab161eb4879c29c1a5f3eaa641a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"CONSTRAINTS_FILE\u003d\"$1\""},{"line_number":8,"context_line":"shift 1"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"set -e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# NOTE(tonyb): Place this in the tox enviroment\u0027s log dir so it will get"},{"line_number":13,"context_line":"# published to logs.openstack.org for easy debugging."}],"source_content_type":"text/x-sh","patch_set":1,"id":"da4df55a_46950f85","line":10,"updated":"2016-12-27 23:49:05.000000000","message":"Should this be moved up above? If I\u0027m thinking this through correctly, when no args were provided, the shift will fail, localfile will never get created, and the actual failure won\u0027t happen until line 22.","commit_id":"4c082bb52c36c92a5adc6694f993850701723448"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0aa5aa97330f1ab161eb4879c29c1a5f3eaa641a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if [[ \"$CONSTRAINTS_FILE\" !\u003d http* ]]; then"},{"line_number":17,"context_line":"    CONSTRAINTS_FILE\u003d\"file://$CONSTRAINTS_FILE\""},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":"# NOTE(tonyb): need to add curl to bindep.txt if the project supports bindep"},{"line_number":20,"context_line":"curl \"$CONSTRAINTS_FILE\" --insecure --progress-bar --output \"$localfile\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"pip install -c\"$localfile\" openstack-requirements"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da4df55a_4667cfe8","line":19,"updated":"2016-12-27 23:49:05.000000000","message":"It does.","commit_id":"4c082bb52c36c92a5adc6694f993850701723448"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0aa5aa97330f1ab161eb4879c29c1a5f3eaa641a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"edit-constraints \"$localfile\" -- \"$CLIENT_NAME\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"pip install -c\"$localfile\" -U \"$@\""},{"line_number":30,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da4df55a_668e937a","line":30,"updated":"2016-12-27 23:49:05.000000000","message":"Is this actually necessary? Doesn\u0027t the\n\n set -e\n\ncover it?","commit_id":"4c082bb52c36c92a5adc6694f993850701723448"}],"tox.ini":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0aa5aa97330f1ab161eb4879c29c1a5f3eaa641a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d py27,py34,py35,pypy,pep8"},{"line_number":3,"context_line":"minversion \u003d 2.0"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"da4df55a_6653f3e2","line":3,"updated":"2016-12-27 23:49:05.000000000","message":"This gets us out of distro packages for Ubuntu 14.04. Maybe that\u0027s OK? Looks like RHEL/CentOS don\u0027t ship tox *at all*, and EPEL only provides 1.4 (even for the 7 release), so I guess we\u0027re already assuming people are installing tox via pip?\n\nI\u0027m guessing the up-rev is needed for the\n\nsetenv \u003d\n    {[testenv]setenv}\n\nsyntax?","commit_id":"4c082bb52c36c92a5adc6694f993850701723448"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0aa5aa97330f1ab161eb4879c29c1a5f3eaa641a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  LANG\u003den_US.utf8"},{"line_number":11,"context_line":"  VIRTUAL_ENV\u003d{envdir}"},{"line_number":12,"context_line":"  BRANCH_NAME\u003dmaster"},{"line_number":13,"context_line":"  CLIENT_NAME\u003dpython-swiftclient"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"da4df55a_66bcd306","line":13,"updated":"2016-12-27 23:49:05.000000000","message":"Would it be better to just pass CONSTRAINTS_FILE as an environment variable here, rather than sticking it in the install_command line?","commit_id":"4c082bb52c36c92a5adc6694f993850701723448"}]}