)]}'
{"id":"openstack%2Fpython-swiftclient~446527","triplet_id":"openstack%2Fpython-swiftclient~master~Ibc58667789e8f54c74ae2bbd32717a45f7b30550","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1559079","hashtags":[],"change_id":"Ibc58667789e8f54c74ae2bbd32717a45f7b30550","subject":"Close file handle after upload job","status":"MERGED","created":"2017-03-16 14:09:17.000000000","updated":"2017-03-20 03:07:52.000000000","submitted":"2017-03-20 03:07:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8711f42fa842ee30a2f46d8b8121e609dc5bd588","_number":446527,"virtual_id_number":446527,"owner":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":2,"date":"2017-03-20 03:07:52.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":2,"date":"2017-03-20 01:51:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":2,"date":"2017-03-16 18:26:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":1,"date":"2017-03-20 01:51:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-16 14:09:29.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2017-03-16 18:26:20.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2017-03-20 01:51:03.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"},{"updated":"2017-03-20 03:07:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"db91e8554b58ce39aa921edbc9d5a529f301ba78","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2017-03-16 14:09:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b8c3c072033149f8f3d9c1da1ad71c3bbf925be","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2017-03-16 14:09:29.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"41cb9385c3f9bc2669e62f71ecf74133bdaffe3b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-16 15:23:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/27/446527/1/check/gate-python-swiftclient-docs-ubuntu-xenial/8ee47e8//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/27/446527/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/494d044/ : SUCCESS in 2m 40s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/27/446527/1/check/gate-python-swiftclient-python27-ubuntu-xenial/97c48a9/ : SUCCESS in 1m 54s\n- gate-python-swiftclient-python35 http://logs.openstack.org/27/446527/1/check/gate-python-swiftclient-python35/766d3ed/ : SUCCESS in 2m 42s\n- gate-python-swiftclient-pypy http://logs.openstack.org/27/446527/1/check/gate-python-swiftclient-pypy/89d74bf/ : SUCCESS in 2m 17s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/27/446527/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/3e974ae/ : SUCCESS in 1h 12m 47s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/27/446527/1/check/gate-swift-dsvm-functional-ubuntu-xenial/dba2f7a/ : SUCCESS in 22m 48s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/27/446527/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/18440ed/ : SUCCESS in 23m 09s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/27/446527/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/6bf2c35/ : SUCCESS in 32m 03s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/27/446527/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/49ec5d8/ : SUCCESS in 17m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5d1a647027f01554d370772bc71a2b5b6b5589bc","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-03-16 16:15:11.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)\n\nNice! I was just thinking about that bug a couple days ago. Change makes sense, and the consuming connection cleanup in tests brings us much closer to the real behavior.\n\nI noticed that nothing fails when I back out the change to service.py, though -- mind adding a failing test case so we won\u0027t regress? Something like http://paste.openstack.org/show/602985/ should work.","accounts_in_message":[],"_revision_number":1},{"id":"180c60e82b02452edc9818a5dc4cdacb6901e0fc","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2017-03-16 18:10:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"665ade2f3b9adcd2344f1da58ffaa860de1f4e22","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2017-03-16 18:23:44.000000000","message":"Patch Set 2:\n\nThank you very much, Tim, for reviewing and providing great piece of test.\n\nI added the test and fixed nits you pointed.","accounts_in_message":[],"_revision_number":2},{"id":"b3bc1252eae8047600130c605444e395c372a3c6","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-03-16 18:26:20.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d2ee21015c07f88215b7fe2a76c98b0601cbeef8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-16 19:31:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/27/446527/2/check/gate-python-swiftclient-docs-ubuntu-xenial/8495595//doc/build/html/ : SUCCESS in 1m 43s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/27/446527/2/check/gate-python-swiftclient-pep8-ubuntu-xenial/b855bf5/ : SUCCESS in 1m 26s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/27/446527/2/check/gate-python-swiftclient-python27-ubuntu-xenial/cbd3c91/ : SUCCESS in 1m 14s\n- gate-python-swiftclient-python35 http://logs.openstack.org/27/446527/2/check/gate-python-swiftclient-python35/32e32a7/ : SUCCESS in 2m 41s\n- gate-python-swiftclient-pypy http://logs.openstack.org/27/446527/2/check/gate-python-swiftclient-pypy/1079fc6/ : SUCCESS in 3m 14s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/27/446527/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/7e5abe3/ : SUCCESS in 1h 19m 32s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/27/446527/2/check/gate-swift-dsvm-functional-ubuntu-xenial/bc270db/ : SUCCESS in 32m 49s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/27/446527/2/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/c05d37b/ : SUCCESS in 33m 16s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/27/446527/2/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/93ae4ca/ : SUCCESS in 28m 32s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/27/446527/2/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/be19d1c/ : SUCCESS in 18m 40s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f65ae8c6ffac7e5a4fec5fb26c966ebb58f6446f","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2017-03-20 01:51:03.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2\n\nNice fix, cleans up closing files, tests are good. Nice work!","accounts_in_message":[],"_revision_number":2},{"id":"0825fa1c58268e7d44ddf708c3a953b4de64b5bb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 01:51:13.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"75a44567d70924fe008cbaccb9cf6be7f478306f","date":"2017-03-20 03:07:52.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"9bc9c2f038b448d7a48e9bf75e70a1e9deef3b67","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 03:07:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/27/446527/2/gate/gate-python-swiftclient-docs-ubuntu-xenial/dd1832f//doc/build/html/ : SUCCESS in 52s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/27/446527/2/gate/gate-python-swiftclient-pep8-ubuntu-xenial/b8c9bbc/ : SUCCESS in 55s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/27/446527/2/gate/gate-python-swiftclient-python27-ubuntu-xenial/3ac5138/ : SUCCESS in 1m 26s\n- gate-python-swiftclient-python35 http://logs.openstack.org/27/446527/2/gate/gate-python-swiftclient-python35/34bb355/ : SUCCESS in 52s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/27/446527/2/gate/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/f2381d8/ : SUCCESS in 1h 16m 29s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/27/446527/2/gate/gate-swift-dsvm-functional-ubuntu-xenial/8bd5ca1/ : SUCCESS in 21m 41s\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/27/446527/2/gate/gate-swiftclient-dsvm-functional-ubuntu-xenial/089e30f/ : SUCCESS in 16m 36s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"809e4cf98fceed1ddef033c86199cca48708d710","revisions":{"10483c91318c913eadc61c943f51ac72a45540a2":{"kind":"REWORK","_number":1,"created":"2017-03-16 14:09:17.000000000","uploader":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"ref":"refs/changes/27/446527/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/27/446527/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/27/446527/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/27/446527/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/27/446527/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/27/446527/1"}}},"commit":{"parents":[{"commit":"ee8620de940297f8b754ce0ffcfcbc4dceb29794","subject":"Change swift.o.o URL","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ee8620de940297f8b754ce0ffcfcbc4dceb29794"}]}],"author":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2017-03-15 20:47:33.000000000","tz":0},"committer":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2017-03-16 13:58:12.000000000","tz":0},"subject":"Close file handle after upload job","message":"Close file handle after upload job\n\nThe opened file for upload is not closed.\nThis fix prevents possible file handle leak.\n\nCloses-Bug: #1559079\nChange-Id: Ibc58667789e8f54c74ae2bbd32717a45f7b30550\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/10483c91318c913eadc61c943f51ac72a45540a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/10483c91318c913eadc61c943f51ac72a45540a2"}]},"branch":"refs/heads/master"},"809e4cf98fceed1ddef033c86199cca48708d710":{"kind":"REWORK","_number":2,"created":"2017-03-16 18:10:10.000000000","uploader":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"ref":"refs/changes/27/446527/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/27/446527/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/27/446527/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/27/446527/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/27/446527/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/27/446527/2"}}},"commit":{"parents":[{"commit":"ee8620de940297f8b754ce0ffcfcbc4dceb29794","subject":"Change swift.o.o URL","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ee8620de940297f8b754ce0ffcfcbc4dceb29794"}]}],"author":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2017-03-15 20:47:33.000000000","tz":0},"committer":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2017-03-16 18:03:13.000000000","tz":0},"subject":"Close file handle after upload job","message":"Close file handle after upload job\n\nThe opened file for upload is not closed.\nThis fix prevents possible file handle leak.\n\nCloses-Bug: #1559079\nChange-Id: Ibc58667789e8f54c74ae2bbd32717a45f7b30550\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/809e4cf98fceed1ddef033c86199cca48708d710"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/809e4cf98fceed1ddef033c86199cca48708d710"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}