)]}'
{"id":"openstack%2Fpython-swiftclient~447800","triplet_id":"openstack%2Fpython-swiftclient~master~I73388694eb25c142c39d554b2efc3df9f6979f0f","project":"openstack/python-swiftclient","branch":"master","topic":"develop","hashtags":[],"change_id":"I73388694eb25c142c39d554b2efc3df9f6979f0f","subject":"Replace json.loads(obj) with oslo_serialization.jsonutils.loads(obj)","status":"ABANDONED","created":"2017-03-21 04:55:30.000000000","updated":"2017-03-27 22:58:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"48a780b0f369a7980acf0b12bc8ac7b0b82bc8c7","_number":447800,"virtual_id_number":447800,"owner":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-03-21 06:28:17.000000000","_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},{"value":-1,"date":"2017-03-21 07:15:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2017-03-21 06:06:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-21 04:57:01.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2017-03-21 07:15:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a3b7c8977bb1641b4b3aa181aefe86ebd9ae436f","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-03-21 04:55:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a231df56f90ee6e75a52995178fe88950b04c457","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2017-03-21 04:57:01.000000000","message":"Patch Set 1: Code-Review-2\n\nwhy do we need to replace a standard library module with a new external dependency?","accounts_in_message":[],"_revision_number":1},{"id":"ad03b74598ec17abf904b5414e4198d317ae5510","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-03-21 06:06:20.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"11257942917cc6d6a12f1a55da421dbdbd61b940","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-03-21 06:28:17.000000000","message":"Patch Set 2:\n\n\u003e why do we need to replace a standard library module with a new\n \u003e external dependency?\n\nSerialization: base64, JSON, etc.\nRef: https://wiki.openstack.org/wiki/Python3#sixer_tool","accounts_in_message":[],"_revision_number":2},{"id":"e1568e6ea2e4ff1ff866ae0bf6b48fe03912859a","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-03-21 06:50:05.000000000","message":"Patch Set 2:\n\n\u003e why do we need to replace a standard library module with a new\n \u003e external dependency?\n\nRef:\nhttps://docs.openstack.org/developer/oslo.serialization/api.html#oslo_serialization.jsonutils.dump_as_bytes","accounts_in_message":[],"_revision_number":2},{"id":"07e7d313f331c65e76fe535097a0435c97349b02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-21 07:15:05.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/00/447800/2/check/gate-python-swiftclient-docs-ubuntu-xenial/89f12e6//doc/build/html/ : SUCCESS in 1m 34s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/00/447800/2/check/gate-python-swiftclient-pep8-ubuntu-xenial/3918770/ : FAILURE in 1m 39s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/00/447800/2/check/gate-python-swiftclient-python27-ubuntu-xenial/0b5fef3/ : SUCCESS in 2m 57s\n- gate-python-swiftclient-python35 http://logs.openstack.org/00/447800/2/check/gate-python-swiftclient-python35/042e723/ : FAILURE in 3m 17s\n- gate-python-swiftclient-pypy http://logs.openstack.org/00/447800/2/check/gate-python-swiftclient-pypy/e50f3b2/ : SUCCESS in 1m 32s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/00/447800/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/7bd04ca/ : SUCCESS in 1h 08m 18s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/00/447800/2/check/gate-swift-dsvm-functional-ubuntu-xenial/4b94e4e/ : SUCCESS in 36m 43s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/00/447800/2/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/e9cab9d/ : SUCCESS in 29m 54s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/00/447800/2/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/a314554/ : SUCCESS in 30m 56s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/00/447800/2/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/42c98b5/ : SUCCESS in 17m 16s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"44bec90eefcd3eca2b6bb97de695f4896bb048e9","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2017-03-21 16:05:05.000000000","message":"Patch Set 2:\n\nSo it would seem that the justification for using oslo.serialization (and the transitive dependency of oslo.utils) is to save an extra variable? This is what I gathered from the wiki page and looking through the two libraries.\n\nI don\u0027t see that the cost of adding new dependencies is worth it.","accounts_in_message":[],"_revision_number":2},{"id":"9e6ced39e29a5a0f08d4ba2560d4a547fe722208","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-03-27 22:58:21.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3a562bc99ba6294e5ad4c79f9e01daa66c4c1a02","revisions":{"c6eb3acbb9b9e349eb85c18d52cded286c64b1af":{"kind":"REWORK","_number":1,"created":"2017-03-21 04:55:30.000000000","uploader":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"ref":"refs/changes/00/447800/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/00/447800/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/447800/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/447800/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/447800/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/00/447800/1"}}},"commit":{"parents":[{"commit":"8aae889f26ea0abe38d5dc0cb340bc0096a75f9c","subject":"Merge \"Don\u0027t recommend to overwrite imported `session` variable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8aae889f26ea0abe38d5dc0cb340bc0096a75f9c"}]}],"author":{"name":"lijunbo","email":"lijunbo@fiberhome.com","date":"2017-03-21 04:53:49.000000000","tz":480},"committer":{"name":"lijunbo","email":"lijunbo@fiberhome.com","date":"2017-03-21 04:55:25.000000000","tz":480},"subject":"Replace json.loads(obj) with oslo_serialization.jsonutils.loads(obj)","message":"Replace json.loads(obj) with oslo_serialization.jsonutils.loads(obj)\n\nChange-Id: I73388694eb25c142c39d554b2efc3df9f6979f0f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c6eb3acbb9b9e349eb85c18d52cded286c64b1af"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c6eb3acbb9b9e349eb85c18d52cded286c64b1af"}]},"branch":"refs/heads/master"},"3a562bc99ba6294e5ad4c79f9e01daa66c4c1a02":{"kind":"REWORK","_number":2,"created":"2017-03-21 06:06:20.000000000","uploader":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"ref":"refs/changes/00/447800/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/00/447800/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/447800/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/447800/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/00/447800/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/00/447800/2"}}},"commit":{"parents":[{"commit":"8aae889f26ea0abe38d5dc0cb340bc0096a75f9c","subject":"Merge \"Don\u0027t recommend to overwrite imported `session` variable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8aae889f26ea0abe38d5dc0cb340bc0096a75f9c"}]}],"author":{"name":"lijunbo","email":"lijunbo@fiberhome.com","date":"2017-03-21 04:53:49.000000000","tz":480},"committer":{"name":"junboli","email":"lijunbo@fiberhome.com","date":"2017-03-21 05:55:09.000000000","tz":0},"subject":"Replace json.loads(obj) with oslo_serialization.jsonutils.loads(obj)","message":"Replace json.loads(obj) with oslo_serialization.jsonutils.loads(obj)\n\nChange-Id: I73388694eb25c142c39d554b2efc3df9f6979f0f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3a562bc99ba6294e5ad4c79f9e01daa66c4c1a02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3a562bc99ba6294e5ad4c79f9e01daa66c4c1a02"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}