)]}'
{"swiftclient/utils.py":[{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"72d82559db3c44605c25d56d820b1a7d8d364cc3","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self._md5 \u003d md5"},{"line_number":282,"context_line":"        self._reset_md5()"},{"line_number":283,"context_line":"        self._length \u003d self._to_buffer \u003d self._remaining \u003d length"},{"line_number":284,"context_line":"        self._buffer \u003d six.BytesIO()"},{"line_number":285,"context_line":"        self._buffer_size \u003d 0"},{"line_number":286,"context_line":"        self._readable \u003d readable"},{"line_number":287,"context_line":"        self.read_size \u003d read_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_55b5a6ed","line":284,"range":{"start_line":284,"start_character":27,"end_line":284,"end_character":34},"updated":"2017-04-05 15:22:07.000000000","message":"According to [1], file(-like) object\u0027s interfaces defined in the io module [2].\n[2]\u0027s overview says that there are binary streams and text streams.\nIn Python3, the two type streams are different.\nI think LengthWrapper\u0027s implementation should only support binary stream, because \"It is recommended to use this class only on files opened in binary mode.\" is in its comment.\nTherefore, I think TestLengthWrapper.test_stringio is wrong test.\nSo my opinion is that TestLengthWrapper.test_stringio should be removed, and LengthWrapper should raise error with text stream file-like objects.\n\n[1]: \u003chttps://docs.python.org/3.6/glossary.html#glossary\u003e\n[2]: \u003chttps://docs.python.org/3.6/library/io.html#module-io\u003e","commit_id":"593692101d852319f609659452e6aa954494b4a0"}],"tests/unit/test_service.py":[{"author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"change_message_id":"2f779fa206ebfee721f572b6ffb6ef67ba944a57","unresolved":false,"context_lines":[{"line_number":1951,"context_line":"                    \u0027headers_receipt\u0027: 3"},{"line_number":1952,"context_line":"                }"},{"line_number":1953,"context_line":"            )"},{"line_number":1954,"context_line":"            mock_open.assert_called_once_with(\u0027test_o\u0027, \u0027wb\u0027, 65536)"},{"line_number":1955,"context_line":"            written_content.write.assert_called_once_with(b\u0027objcontent\u0027)"},{"line_number":1956,"context_line":""},{"line_number":1957,"context_line":"        mock_conn.get_object.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_2865fcb5","line":1954,"updated":"2017-07-13 14:24:36.000000000","message":"It seems a little odd to hard code the value of the buffer size we expect in the tests when we\u0027ve got a const defined in service.py that we could be using...","commit_id":"638d7c789cf3ccab61bf6af6fcab6e6d79b9e0a4"}]}