)]}'
{"id":"openstack%2Fpython-swiftclient~449771","triplet_id":"openstack%2Fpython-swiftclient~master~I3160626e947083af487fd1c3cb0aa6a62646527b","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1671621","hashtags":[],"change_id":"I3160626e947083af487fd1c3cb0aa6a62646527b","subject":"Buffer reads from disk","status":"MERGED","created":"2017-03-24 18:19:56.000000000","updated":"2017-07-13 19:24:48.000000000","submitted":"2017-07-13 19:24:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7a472fa35dee1b2f6ad15362e4c27b27e079ff1e","_number":449771,"virtual_id_number":449771,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":2,"date":"2017-07-13 19:24:48.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":2,"date":"2017-07-13 16:46:21.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-13 04:32:22.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"all":[{"value":1,"date":"2017-07-13 16:46:25.000000000","_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-05 15:22:07.000000000","updated_by":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"reviewer":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"state":"REVIEWER"},{"updated":"2017-05-01 18:16:44.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2017-07-13 04:32:22.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2017-07-13 16:46:25.000000000","updated_by":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"reviewer":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"state":"REVIEWER"},{"updated":"2017-07-13 19:24:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1a14ac8095c5fa37e30ca4306787b1acac91fce9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-03-24 18:19:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"744b9242abceece2c7794c5a7fc24618f50aae44","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-24 19:41:41.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/449771/1/check/gate-python-swiftclient-docs-ubuntu-xenial/14ba707//doc/build/html/ : SUCCESS in 54s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/71/449771/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/45effa0/ : SUCCESS in 1m 17s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/71/449771/1/check/gate-python-swiftclient-python27-ubuntu-xenial/7e05fad/ : SUCCESS in 1m 19s\n- gate-python-swiftclient-python35 http://logs.openstack.org/71/449771/1/check/gate-python-swiftclient-python35/4f86e6c/ : FAILURE in 2m 05s\n- gate-python-swiftclient-pypy http://logs.openstack.org/71/449771/1/check/gate-python-swiftclient-pypy/0dd7270/ : SUCCESS in 2m 25s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/71/449771/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/c0dff31/ : SUCCESS in 1h 13m 34s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/1/check/gate-swift-dsvm-functional-ubuntu-xenial/7cb8207/ : SUCCESS in 30m 58s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/71/449771/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/57d4d29/ : SUCCESS in 30m 38s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/83b8663/ : SUCCESS in 26m 45s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/71/449771/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/6d3dff8/ : SUCCESS in 26m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"72d82559db3c44605c25d56d820b1a7d8d364cc3","author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"date":"2017-04-05 15:22:07.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI agree with your opinion about the py3 test.","accounts_in_message":[],"_revision_number":1},{"id":"6dea013d9a561350fb58bdeecc8da9adfe1a8734","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-04-19 04:24:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"faa97a80655d62e92ee68e43118a71688a30d7dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-19 06:11:56.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/449771/2/check/gate-python-swiftclient-docs-ubuntu-xenial/e58c7cf//doc/build/html/ : SUCCESS in 50s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-python-swiftclient-pep8-ubuntu-xenial/4b4c67b/ : SUCCESS in 1m 02s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-python-swiftclient-python27-ubuntu-xenial/c908340/ : SUCCESS in 1m 31s\n- gate-python-swiftclient-python35 http://logs.openstack.org/71/449771/2/check/gate-python-swiftclient-python35/a1a8b46/ : SUCCESS in 1m 00s\n- gate-python-swiftclient-pypy http://logs.openstack.org/71/449771/2/check/gate-python-swiftclient-pypy/50bf688/ : SUCCESS in 1m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/9990f0f/ : SUCCESS in 59m 24s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-swift-dsvm-functional-ubuntu-xenial/9e0a111/ : FAILURE in 21m 56s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/71/449771/2/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/f7f722d/ : FAILURE in 15m 38s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/7da2215/ : FAILURE in 17m 53s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/71/449771/2/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/c943d9e/ : FAILURE in 20m 59s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"556dbd5b9d58ed0a623b5e2f4337bb229202c153","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-04-19 06:23:44.000000000","message":"Patch Set 2:\n\nThis looks insane on the surface. Did you benchmark this against merely supplying a length to read()?","accounts_in_message":[],"_revision_number":2},{"id":"fe695bfa62a50f2409588e1ce802263d4bb71165","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-04-19 06:35:23.000000000","message":"Patch Set 2:\n\nActually, I take that back. I\u0027ll benchmark it myself!","accounts_in_message":[],"_revision_number":2},{"id":"4f0b8cf3c46fa75be8d3d0880b155bc76bf94e5d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-04-19 16:52:12.000000000","message":"Patch Set 2:\n\nrecheck\n\n\u003e merely supplying a length to read()\n\nWhere would we do that? We\u0027re passing the read()able down to requests which plumbs it all the way down to httplib/http.client, which hard-codes the read block size to 8k [1]. And we do *that* because the alternative involved requests sending both `Content-Length: X` *and* `Transfer-Encoding: chunked` headers.\n\nI did some simple benchmarking in the bug [2], though I later realized I was doing it on a vagrant shared filesystem which probably had some performance penalties. We\u0027ve seen it in the field, though; some customer/prospect was seeing better performance doing large transfers with an S3 client + swift3 than python-swiftclient!\n\n[1] https://github.com/python/cpython/blob/v3.6.1/Lib/http/client.py#L970-L983\n[2] https://bugs.launchpad.net/python-swiftclient/+bug/1671621","accounts_in_message":[],"_revision_number":2},{"id":"5b808bdce7aa9f6cd5811dbbe10ecd0d3c43c6e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-19 17:59:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/449771/2/check/gate-python-swiftclient-docs-ubuntu-xenial/a152318//doc/build/html/ : SUCCESS in 1m 31s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-python-swiftclient-pep8-ubuntu-xenial/0e6d066/ : SUCCESS in 1m 51s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-python-swiftclient-python27-ubuntu-xenial/d06a48d/ : SUCCESS in 2m 42s\n- gate-python-swiftclient-python35 http://logs.openstack.org/71/449771/2/check/gate-python-swiftclient-python35/bd604a3/ : SUCCESS in 1m 30s\n- gate-python-swiftclient-pypy http://logs.openstack.org/71/449771/2/check/gate-python-swiftclient-pypy/4db55f0/ : SUCCESS in 2m 41s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/867dcb1/ : SUCCESS in 1h 05m 52s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-swift-dsvm-functional-ubuntu-xenial/830de37/ : SUCCESS in 21m 28s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/71/449771/2/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/d2cd191/ : SUCCESS in 20m 43s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/2/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/ecf93d2/ : SUCCESS in 16m 00s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/71/449771/2/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/216920a/ : SUCCESS in 23m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4ddc40efab3bd4ebb0a6dfb861badde844e709bf","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-05-01 18:16:44.000000000","message":"Patch Set 2: Code-Review+1\n\nSo, a) yes there really is no good way to do this [1] [2] because b) yes stdlib httplib realy is this stupid [3] [4]\n\n1. https://github.com/sigmavirus24/requests-toolbelt/issues/75\n2. https://github.com/sigmavirus24/requests-toolbelt/pull/84/files\n3. https://github.com/python/cpython/blob/5d7a8d0c13737fd531b722ad76c505ef47aac96a/Lib/http/client.py#L948\n4.  http://bugs.python.org/issue21790","accounts_in_message":[],"_revision_number":2},{"id":"82185f221fa63505781b5d4373b1df95db46d325","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-05-06 03:59:33.000000000","message":"Patch Set 2: Code-Review-1\n\nHow about this:\n\nhttps://gist.github.com/zaitcev/5287ce6427bff61bccd463c82767a99d","accounts_in_message":[],"_revision_number":2},{"id":"eefc354c494877388430ae295edf9f26050bbc39","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-05-09 14:44:07.000000000","message":"Patch Set 2:\n\nTactically, that seems to trade one magic number for another -- if someone downstream from *us* says \"I don\u0027t want 64k reads, I want 1MB!\" they\u0027ll need some\n\n if size in (8192, 64536):\n     size \u003d 1048576\n\nNow, we could still preserve the read_size arg/attr to give them a better hook.\n\nMore generally, though, I\u0027m not quite comfortable breaking the read() contract like this -- as best I can tell, everyone[1][2] keeps to a contract along the lines of\n\n\u003e Read up to ``size`` bytes\n\nWhile returning more data than was requested works fine when we\u0027re immediately shoving the result down a socket anyway, I wonder whether anyone else may try to read from the stream, and how much they\u0027ll curse us when they realize they can read 8191 or 8193 bytes just fine, but 8192 starts overflowing buffers.\n\nI shudder to think of what all would break if socket.recv had a similar \"well, sometimes we\u0027re going to return way more than you asked for\" kludge...\n\n[1] https://docs.python.org/2/library/stdtypes.html#file.read\n[2] https://docs.python.org/2/library/io.html#io.RawIOBase.read","accounts_in_message":[],"_revision_number":2},{"id":"92e3c561ff191a3c7d412ddcf0b8634afc5a3ef8","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-05-09 17:45:13.000000000","message":"Patch Set 2: -Code-Review","accounts_in_message":[],"_revision_number":2},{"id":"0a903cb9856e7be1c4cb82cdba6991d64bf472b7","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-06-15 04:33:16.000000000","message":"Patch Set 2: Code-Review-1\n\nOkay, fine. But can we at least drop the shuffling of the tail of the buffer into its head, like this:\nhttps://gist.github.com/zaitcev/53b2c2b2b16f59387ca43d3a09872cfe","accounts_in_message":[],"_revision_number":2},{"id":"7d8a756daa8849e92fd4cd64dc4d19e64a702d11","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-07-08 01:18:27.000000000","message":"Patch Set 2: Workflow-1\n\nNote to self: consider passing a third arg to open(): https://docs.python.org/2/library/functions.html#open\n\nDoes it achieve similar results?","accounts_in_message":[],"_revision_number":2},{"id":"f7957c6b4efb277dd7cba81f93ec1b540f90303a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-07-12 00:05:00.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"46ff205ce23e8ee007a9e2acfc5fffdfc6fe5b3a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-12 01:12:37.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/449771/3/check/gate-python-swiftclient-docs-ubuntu-xenial/038a513//doc/build/html/ : SUCCESS in 1m 36s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/71/449771/3/check/gate-python-swiftclient-pep8-ubuntu-xenial/e03676b/ : SUCCESS in 1m 12s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/71/449771/3/check/gate-python-swiftclient-python27-ubuntu-xenial/e3e290f/ : SUCCESS in 2m 06s\n- gate-python-swiftclient-python35 http://logs.openstack.org/71/449771/3/check/gate-python-swiftclient-python35/38b092e/ : SUCCESS in 1m 36s\n- gate-python-swiftclient-pypy http://logs.openstack.org/71/449771/3/check/gate-python-swiftclient-pypy/b534cde/ : SUCCESS in 2m 56s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/71/449771/3/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/75a723a/ : SUCCESS in 1h 05m 47s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/3/check/gate-swift-dsvm-functional-ubuntu-xenial/885d43e/ : SUCCESS in 17m 30s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/71/449771/3/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/2186537/ : SUCCESS in 13m 11s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/3/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/43d8463/ : SUCCESS in 9m 01s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/71/449771/3/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/ff2c563/ : SUCCESS in 13m 37s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"062228a8c78cab6d8827a7e6e312c3d6daa1f0a2","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-07-13 04:32:22.000000000","message":"Patch Set 3: Code-Review+2\n\nGenius!\n\nAre you glad we didn\u0027t merge the previous version?","accounts_in_message":[],"_revision_number":3},{"id":"2f779fa206ebfee721f572b6ffb6ef67ba944a57","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2017-07-13 14:24:36.000000000","message":"Patch Set 3: Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"0937e89195d118f4fdf35fe6233fb65f4ad1600e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 14:24:52.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"87e4430af50a7773a1a2879b6e80bcbf53508672","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2017-07-13 14:27:16.000000000","message":"Patch Set 3: -Workflow","accounts_in_message":[],"_revision_number":3},{"id":"470a90b986611c74d36ca41ac2c8f60b70c542ac","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2017-07-13 14:28:20.000000000","message":"Patch Set 3: Code-Review-2\n\nJust trying to stop a merge after I fat-fingered the wrong button.","accounts_in_message":[],"_revision_number":3},{"id":"d75e0eb2887a15f4a6a5e1bb2d5a78cff3163ad8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 15:45:08.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/449771/3/gate/gate-python-swiftclient-docs-ubuntu-xenial/4c3a522//doc/build/html/ : SUCCESS in 2m 25s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-python-swiftclient-pep8-ubuntu-xenial/e4537b9/ : SUCCESS in 1m 10s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-python-swiftclient-python27-ubuntu-xenial/204f90e/ : SUCCESS in 1m 44s\n- gate-python-swiftclient-python35 http://logs.openstack.org/71/449771/3/gate/gate-python-swiftclient-python35/99e7988/ : SUCCESS in 1m 41s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/c57bcf9/ : SUCCESS in 1h 19m 42s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-swift-dsvm-functional-ubuntu-xenial/6b55eac/ : SUCCESS in 20m 21s\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-swiftclient-dsvm-functional-ubuntu-xenial/7b1cb19/ : SUCCESS in 15m 00s","accounts_in_message":[],"_revision_number":3},{"id":"003ccaa61b71bdc843466094d4553c08ea2a5f65","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2017-07-13 15:50:51.000000000","message":"Patch Set 3: Code-Review-1\n\nJust one comment re. using the buffer size const from service.py in the tests.","accounts_in_message":[],"_revision_number":3},{"id":"7b0aea9a31060ce80e8c3ffa3a0d20e02dc862dc","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-07-13 16:24:05.000000000","message":"Patch Set 3:\n\n\u003e Just one comment re. using the buffer size const from service.py in\n \u003e the tests.\n\nIsn\u0027t that backwards and defeats the tests? If the value changes, the tests continue to pass. Is it what we want?","accounts_in_message":[],"_revision_number":3},{"id":"d00dedc11adfce82d758cffc7f5e132f24fe6327","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2017-07-13 16:46:21.000000000","message":"Patch Set 3: Code-Review+2\n\nOkay, so there was an argument made against using the service.py const in the tests and I don\u0027t feel too strongly about it either way.","accounts_in_message":[],"_revision_number":3},{"id":"a700288adcb3b0f136168957e5de69ff6668dbc8","author":{"_account_id":9216,"name":"Joel Wright","email":"joel.wright@gmail.com","username":"jjw-sohonet"},"date":"2017-07-13 16:46:25.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"267cf6aff94f987cffebb3700523c8724ae8b5e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 16:50:02.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"ae78c35ef89bf6901dc9f75eaffe54f9ffdc59e8","date":"2017-07-13 19:24:48.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"e28182e49ea860e1838763e75b407a430bd4322f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 19:24:48.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/449771/3/gate/gate-python-swiftclient-docs-ubuntu-xenial/7dc6b5a//doc/build/html/ : SUCCESS in 1m 35s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-python-swiftclient-pep8-ubuntu-xenial/6689174/ : SUCCESS in 1m 30s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-python-swiftclient-python27-ubuntu-xenial/3a47e51/ : SUCCESS in 2m 18s\n- gate-python-swiftclient-python35 http://logs.openstack.org/71/449771/3/gate/gate-python-swiftclient-python35/e5ff99a/ : SUCCESS in 1m 42s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/e2b8555/ : SUCCESS in 1h 17m 29s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-swift-dsvm-functional-ubuntu-xenial/2e53309/ : SUCCESS in 18m 46s\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/449771/3/gate/gate-swiftclient-dsvm-functional-ubuntu-xenial/f6b0025/ : SUCCESS in 9m 52s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"638d7c789cf3ccab61bf6af6fcab6e6d79b9e0a4","revisions":{"593692101d852319f609659452e6aa954494b4a0":{"kind":"REWORK","_number":1,"created":"2017-03-24 18:19:56.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/71/449771/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/71/449771/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/1"}}},"commit":{"parents":[{"commit":"8aae889f26ea0abe38d5dc0cb340bc0096a75f9c","subject":"Merge \"Don\u0027t recommend to overwrite imported `session` variable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8aae889f26ea0abe38d5dc0cb340bc0096a75f9c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-03-15 18:05:38.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-03-24 18:19:09.000000000","tz":-420},"subject":"Buffer reads from disk","message":"Buffer reads from disk\n\nOtherwise, Python defaults to 8k reads which seems kinda terrible.\n\nWIP: py3 currently fails, but that seems like a not-good test anyway?\n\nChange-Id: I3160626e947083af487fd1c3cb0aa6a62646527b\nCloses-Bug: #1671621\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/593692101d852319f609659452e6aa954494b4a0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/593692101d852319f609659452e6aa954494b4a0"}]},"branch":"refs/heads/master"},"14ec08b2959ec5e8f7c4d5ac29e6452a96893163":{"kind":"REWORK","_number":2,"created":"2017-04-19 04:24:34.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/71/449771/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/71/449771/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/2"}}},"commit":{"parents":[{"commit":"8aae889f26ea0abe38d5dc0cb340bc0096a75f9c","subject":"Merge \"Don\u0027t recommend to overwrite imported `session` variable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8aae889f26ea0abe38d5dc0cb340bc0096a75f9c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-03-15 18:05:38.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-19 04:24:17.000000000","tz":-420},"subject":"Buffer reads from disk","message":"Buffer reads from disk\n\nOtherwise, Python defaults to 8k reads which seems kinda terrible.\n\nAs a side-effect, get more picky about the types of input we wrap. While\nyou can still send unicode that can be encoded to ASCII, any other\nunicode will raise a TypeError in LengthWrapper, rather than making it\nall the way down to httplib.\n\nChange-Id: I3160626e947083af487fd1c3cb0aa6a62646527b\nCloses-Bug: #1671621\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/14ec08b2959ec5e8f7c4d5ac29e6452a96893163"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/14ec08b2959ec5e8f7c4d5ac29e6452a96893163"}]},"branch":"refs/heads/master"},"638d7c789cf3ccab61bf6af6fcab6e6d79b9e0a4":{"kind":"REWORK","_number":3,"created":"2017-07-12 00:05:00.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/71/449771/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/71/449771/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/71/449771/3"}}},"commit":{"parents":[{"commit":"cde73c196d4f161b227fb924cd59cf02eaa33c03","subject":"Option to ignore mtime metadata entry.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/cde73c196d4f161b227fb924cd59cf02eaa33c03"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-03-15 18:05:38.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-07-12 00:04:49.000000000","tz":-420},"subject":"Buffer reads from disk","message":"Buffer reads from disk\n\nOtherwise, Python defaults to 8k reads which seems kinda terrible.\n\nChange-Id: I3160626e947083af487fd1c3cb0aa6a62646527b\nCloses-Bug: #1671621\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/638d7c789cf3ccab61bf6af6fcab6e6d79b9e0a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/638d7c789cf3ccab61bf6af6fcab6e6d79b9e0a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}