)]}'
{"id":"openstack%2Fpython-swiftclient~455470","triplet_id":"openstack%2Fpython-swiftclient~master~I1d80c76af02f2ca847123349224ddc36d2a6996b","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1680083","hashtags":[],"change_id":"I1d80c76af02f2ca847123349224ddc36d2a6996b","subject":"Stop sending X-Static-Large-Object headers","status":"MERGED","created":"2017-04-10 22:51:23.000000000","updated":"2017-06-14 23:35:32.000000000","submitted":"2017-06-14 23:35:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"60389f5893498b8bd282ac4f1e3941c696da3917","_number":455470,"virtual_id_number":455470,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2017-06-14 23:35:32.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":2,"date":"2017-06-14 22:07:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2017-06-14 22:07:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-14 22:07:20.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2017-06-14 23:35:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4d8bc64316837ba8e59af947a44d7a28bb8599dc","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-04-10 22:51:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1ab5130ab24ff3d4984b061e7dcadad44c825b6c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-10 23:55:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/70/455470/1/check/gate-python-swiftclient-docs-ubuntu-xenial/90f6e91//doc/build/html/ : SUCCESS in 47s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/70/455470/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/5f28577/ : SUCCESS in 1m 56s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/70/455470/1/check/gate-python-swiftclient-python27-ubuntu-xenial/b756475/ : SUCCESS in 1m 28s\n- gate-python-swiftclient-python35 http://logs.openstack.org/70/455470/1/check/gate-python-swiftclient-python35/8d001d4/ : SUCCESS in 2m 11s\n- gate-python-swiftclient-pypy http://logs.openstack.org/70/455470/1/check/gate-python-swiftclient-pypy/c155d36/ : SUCCESS in 2m 12s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/70/455470/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/b9a3f0c/ : SUCCESS in 1h 03m 12s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/70/455470/1/check/gate-swift-dsvm-functional-ubuntu-xenial/fb7467b/ : SUCCESS in 37m 42s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/70/455470/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/62b35c7/ : SUCCESS in 34m 22s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/70/455470/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/d2bec96/ : SUCCESS in 29m 16s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/70/455470/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/31bae93/ : SUCCESS in 26m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9445900760f5b95ea1a85b33875a976670bd012c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-06-14 22:07:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nZOMGBBQ!\n\nBEFORE:\n\n    DEBUG:swiftclient:REQ: curl -i http://saio:8080/v1/AUTH_test/test/testme.builder?multipart-manifest\u003dput -X PUT -H \"x-object-meta-mtime: 1443074688.000000\" -H \"x-static-large-object: true\" -H \"Content-Type: \" -H \"X-Auth-Token: AUTH_tk14e3d6eaf06040b9841a40f8ca82f52c\"\n\nAFTER:\n\n    DEBUG:swiftclient:REQ: curl -i http://saio:8080/v1/AUTH_test/test/testme.builder?multipart-manifest\u003dput -X PUT -H \"x-object-meta-mtime: 1443074688.000000\" -H \"Content-Type: \" -H \"X-Auth-Token: AUTH_tk14e3d6eaf06040b9841a40f8ca82f52c\"\n\nWITH FIX REVERTED:\n\n    FAIL: test_upload (tests.unit.test_shell.TestShell)\n    ----------------------------------------------------------------------\n    Traceback (most recent call last):\n      File \"/usr/local/lib/python2.7/dist-packages/mock/mock.py\", line 1724, in _inner\n        return f(*args, **kw)\n      File \"/usr/local/lib/python2.7/dist-packages/mock/mock.py\", line 1305, in patched\n        return func(*args, **keywargs)\n      File \"/vagrant/python-swiftclient/tests/unit/test_shell.py\", line 719, in test_upload\n        response_dict\u003d{})\n      File \"/usr/local/lib/python2.7/dist-packages/mock/mock.py\", line 937, in assert_called_with\n        six.raise_from(AssertionError(_error_message(cause)), cause)\n      File \"/usr/local/lib/python2.7/dist-packages/six.py\", line 718, in raise_from\n        raise value\n    AssertionError: Expected call: put_object(u\u0027container\u0027, u\u0027pseudo-folder/nested/tmp/tmpiLOgVr\u0027, \u003cANY\u003e, headers\u003d{u\u0027x-object-meta-mtime\u0027: \u003cANY\u003e}, query_string\u003du\u0027multipart-manifest\u003dput\u0027, response_dict\u003d{})\n    Actual call: put_object(u\u0027container\u0027, u\u0027pseudo-folder/nested/tmp/tmpiLOgVr\u0027, \u0027[{\"path\": \"/container_segments/pseudo-folder/nested/tmp/tmpiLOgVr/slo/1497477866.233345/20/10/00000000\", \"etag\": \"d41d8cd98f00b204e9800998ecf8427e\", \"size_bytes\": 10}, {\"path\": \"/container_segments/pseudo-folder/nested/tmp/tmpiLOgVr/slo/1497477866.233345/20/10/00000001\", \"etag\": \"d41d8cd98f00b204e9800998ecf8427e\", \"size_bytes\": 10}]\u0027, headers\u003d{u\u0027x-static-large-object\u0027: u\u0027true\u0027, u\u0027x-object-meta-mtime\u0027: u\u00271497477866.233345\u0027}, query_string\u003du\u0027multipart-manifest\u003dput\u0027, response_dict\u003d{})","accounts_in_message":[],"_revision_number":1},{"id":"049553cfd9e2b548fcaa6da52cfa364c2ef845a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-14 22:07:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c24c60848681e4730e2fe0271e00653747cc9ffa","date":"2017-06-14 23:35:32.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"8d7892fb819dd22dbe811c373bd4030737714531","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-14 23:35:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/70/455470/1/gate/gate-python-swiftclient-docs-ubuntu-xenial/6225129//doc/build/html/ : SUCCESS in 2m 20s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/70/455470/1/gate/gate-python-swiftclient-pep8-ubuntu-xenial/ed20176/ : SUCCESS in 1m 53s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/70/455470/1/gate/gate-python-swiftclient-python27-ubuntu-xenial/58bca3b/ : SUCCESS in 1m 24s\n- gate-python-swiftclient-python35 http://logs.openstack.org/70/455470/1/gate/gate-python-swiftclient-python35/ee0dfc8/ : SUCCESS in 1m 22s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/70/455470/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/846d667/ : SUCCESS in 1h 26m 05s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/70/455470/1/gate/gate-swift-dsvm-functional-ubuntu-xenial/cba3bd0/ : SUCCESS in 17m 47s\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/70/455470/1/gate/gate-swiftclient-dsvm-functional-ubuntu-xenial/53d505d/ : SUCCESS in 13m 13s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"aaaed55cd46902612f1ba93ac3394cfd99679b00","revisions":{"aaaed55cd46902612f1ba93ac3394cfd99679b00":{"kind":"REWORK","_number":1,"created":"2017-04-10 22:51:23.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/70/455470/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/70/455470/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/70/455470/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/70/455470/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/70/455470/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/70/455470/1"}}},"commit":{"parents":[{"commit":"058fb0323f9bc579a891ad48dcff80a7eda4f8ac","subject":"Optimize the link address","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/058fb0323f9bc579a891ad48dcff80a7eda4f8ac"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-10 22:38:58.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-10 22:40:35.000000000","tz":-420},"subject":"Stop sending X-Static-Large-Object headers","message":"Stop sending X-Static-Large-Object headers\n\nIf we were to include this in a normal PUT, it would 400, but only if\nslo is actually in the pipeline. If it\u0027s *not*, we\u0027ll create a normal\nSwift object and the header sticks.\n\n- This is really confusing for users; see the related bug.\n- If slo is later enabled in the cluster, Swift starts responding 500\n  with a KeyError because the client and on-disk formats don\u0027t match!\n\nChange-Id: I1d80c76af02f2ca847123349224ddc36d2a6996b\nRelated-Change: I986c1656658f874172860469624118cc63bff9bc\nRelated-Bug: #1680083\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/aaaed55cd46902612f1ba93ac3394cfd99679b00"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/aaaed55cd46902612f1ba93ac3394cfd99679b00"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}