)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4c81beccc14be0d131b6a37378b43075e0824c0b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Dickinson \u003cme@not.mn\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-14 09:47:56 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow swift functional tests to use keystone auth uri"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Devstack is working through changes to drop the special ports on"},{"line_number":10,"context_line":"things like keystone, as such everything is going to need to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7ffa3b31_8492839d","line":7,"updated":"2017-04-18 22:43:09.000000000","message":"Since https://review.openstack.org/#/c/456344/ has already landed, this seems more like\n\n\u003e Allow swift functional tests to *pass*","commit_id":"83105b62635e1b19a53817cdf4fa7240790be894"}],"tests/functional/test_swiftclient.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d8d72472b3ba9280f261a378d13ddd82b5fc6cf5","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _get_config(self):"},{"line_number":43,"context_line":"        config_file \u003d os.environ.get(\u0027SWIFT_TEST_CONFIG_FILE\u0027,"},{"line_number":44,"context_line":"                                     \u0027/etc/swift/test.conf\u0027)"},{"line_number":45,"context_line":"        config \u003d configparser.ConfigParser({\u0027auth_version\u0027: \u00271\u0027})"},{"line_number":46,"context_line":"        config.read(config_file)"},{"line_number":47,"context_line":"        self.config \u003d config"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_2191b253","side":"PARENT","line":44,"updated":"2017-04-14 23:02:10.000000000","message":"oh, interesting - we piggy back on *swifts* test.conf in development environments.","commit_id":"058fb0323f9bc579a891ad48dcff80a7eda4f8ac"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d8d72472b3ba9280f261a378d13ddd82b5fc6cf5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                self.account_username \u003d \"%s:%s\" % (account, username)"},{"line_number":56,"context_line":"            self.password \u003d config.get(\u0027func_test\u0027, \u0027password\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            auth_prefix \u003d config.get(\u0027func_test\u0027, \u0027auth_prefix\u0027)"},{"line_number":59,"context_line":"            self.auth_version \u003d config.get(\u0027func_test\u0027, \u0027auth_version\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            if config.has_option(\u0027func_test\u0027, \u0027auth_uri\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_cc0922de","line":58,"updated":"2017-04-14 23:02:10.000000000","message":"I think it\u0027s weird that this option is *required* ...","commit_id":"83105b62635e1b19a53817cdf4fa7240790be894"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d8d72472b3ba9280f261a378d13ddd82b5fc6cf5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    self.auth_url \u003d \"http://\""},{"line_number":71,"context_line":"                self.auth_url +\u003d \"%s:%s\" % (auth_host, auth_port)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            self.auth_url +\u003d auth_prefix"},{"line_number":74,"context_line":"            if self.auth_version \u003d\u003d \"1\":"},{"line_number":75,"context_line":"                self.auth_url +\u003d \u0027v1.0\u0027"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_ac0ed6e2","line":73,"updated":"2017-04-14 23:02:10.000000000","message":"... but should *mostly* be set to \u0027\u0027 if you\u0027re using auth_uri ???","commit_id":"83105b62635e1b19a53817cdf4fa7240790be894"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4c81beccc14be0d131b6a37378b43075e0824c0b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    self.auth_url \u003d \"http://\""},{"line_number":71,"context_line":"                self.auth_url +\u003d \"%s:%s\" % (auth_host, auth_port)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            self.auth_url +\u003d auth_prefix"},{"line_number":74,"context_line":"            if self.auth_version \u003d\u003d \"1\":"},{"line_number":75,"context_line":"                self.auth_url +\u003d \u0027v1.0\u0027"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_c4e76b12","line":73,"in_reply_to":"7ffa3b31_ac0ed6e2","updated":"2017-04-18 22:43:09.000000000","message":"IDK, I think keystone\u0027s concept of an auth_uri usually doesn\u0027t include the version number, at least judging by the test.conf that dsvm generates [1]. Given that, we need to use auth_prefix to specify a version... which is pretty terrible. I\u0027m not sure keystone ever *intended* auth_prefix to be used that way; my understanding is that it was meant for the \"/identity_admin\" part of \"http://15.184.66.177/identity_admin\"\n\nI think https://review.openstack.org/#/c/443104/ was on the right track, and busted keystone installs should be fixed -- otherwise they\u0027ll just break in other, probably even-stranger ways.\n\n[1] http://logs.openstack.org/76/457776/1/check/gate-swift-dsvm-functional-ubuntu-xenial/d0bef04/logs/etc/swift/test.conf.txt.gz","commit_id":"83105b62635e1b19a53817cdf4fa7240790be894"}]}