)]}'
{"id":"openstack%2Fpython-swiftclient~472541","triplet_id":"openstack%2Fpython-swiftclient~master~Ieb2243d2ff5326920a27ce8c3c6f0f5c396701ed","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"Ieb2243d2ff5326920a27ce8c3c6f0f5c396701ed","subject":"Do not set Content-Type to \u0027\u0027 with new requests.","status":"MERGED","created":"2017-06-09 06:54:17.000000000","updated":"2017-06-13 22:07:47.000000000","submitted":"2017-06-13 22:07:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":19,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"23bf40ab791fa941296960851e3824ae5fa2bdeb","_number":472541,"virtual_id_number":472541,"owner":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-06-13 22:07:47.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":2,"date":"2017-06-13 17:43:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":2,"date":"2017-06-13 20:13:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":1,"date":"2017-06-13 20:13:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-09 09:41:55.000000000","updated_by":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"reviewer":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"state":"REVIEWER"},{"updated":"2017-06-13 17:43:55.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2017-06-13 20:13:08.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2017-06-13 22:07:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"364f7861e21f55a4892c3c0586fd0ba809a0bc6f","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-06-09 06:54:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87e5f9ab549bb6c54ecd41cf631f7e970aaff375","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-09 08:20:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/41/472541/1/check/gate-python-swiftclient-docs-ubuntu-xenial/6819887//doc/build/html/ : SUCCESS in 59s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/41/472541/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/eff3d13/ : SUCCESS in 2m 53s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/41/472541/1/check/gate-python-swiftclient-python27-ubuntu-xenial/08e2412/ : SUCCESS in 1m 26s\n- gate-python-swiftclient-python35 http://logs.openstack.org/41/472541/1/check/gate-python-swiftclient-python35/a3e41c1/ : FAILURE in 1m 33s\n- gate-python-swiftclient-pypy http://logs.openstack.org/41/472541/1/check/gate-python-swiftclient-pypy/9a13493/ : SUCCESS in 1m 57s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/41/472541/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/8dc7606/ : SUCCESS in 1h 22m 07s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/1/check/gate-swift-dsvm-functional-ubuntu-xenial/1f0f535/ : SUCCESS in 15m 07s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/41/472541/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/f4e9f3e/ : SUCCESS in 22m 23s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/474927d/ : FAILURE in 16m 33s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/41/472541/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/ce3995d/ : FAILURE in 9m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a2e2ac0d6db1ecc715f0fcea96c6d218192782b6","author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"date":"2017-06-09 09:41:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"22288145f85b76966bddb4d459630ee011c76e96","author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"date":"2017-06-09 09:43:05.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"59fe2899fa336141cee878182cf8adb5994a1a48","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-06-09 17:17:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9456c2b868b5b45ef04d4926dde3faad0f70b7af","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-06-09 17:17:55.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a577b0cba83248c8c72e97a8ecc377078d849311","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-09 18:31:14.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/41/472541/2/check/gate-python-swiftclient-docs-ubuntu-xenial/c036a49//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/41/472541/2/check/gate-python-swiftclient-pep8-ubuntu-xenial/9dc4895/ : SUCCESS in 1m 52s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/41/472541/2/check/gate-python-swiftclient-python27-ubuntu-xenial/e71efad/ : SUCCESS in 1m 26s\n- gate-python-swiftclient-python35 http://logs.openstack.org/41/472541/2/check/gate-python-swiftclient-python35/4b791b1/ : SUCCESS in 55s\n- gate-python-swiftclient-pypy http://logs.openstack.org/41/472541/2/check/gate-python-swiftclient-pypy/a5c2e7c/ : SUCCESS in 2m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/41/472541/2/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/8a3c783/ : SUCCESS in 1h 12m 18s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/2/check/gate-swift-dsvm-functional-ubuntu-xenial/fddf834/ : SUCCESS in 24m 35s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/41/472541/2/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/b1138ed/ : SUCCESS in 21m 58s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/2/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/c3bfaf3/ : FAILURE in 14m 17s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/41/472541/2/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/ba389fb/ : FAILURE in 9m 21s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e35a07877f27fecef08daa1185416d4a3e876e48","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-06-09 18:36:09.000000000","message":"Patch Set 2:\n\nI think I\u0027d rather mirror the guessing the server would do -- see https://github.com/openstack/swift/blob/2.14.0/swift/proxy/controllers/obj.py#L425-L434 (which goes *way* back -- see, for example, https://github.com/openstack/swift/blob/1.0.0/swift/proxy/server.py#L544-L549 ) Otherwise we may break CLI users that just want to upload their html/txt/what-have-you files and have them Just Work™.\n\nCan we convince requests to just *not send* the header? I\u0027m willing to bet Christian tried around the time of https://github.com/openstack/python-swiftclient/commit/258420f but I wonder whether more recent versions of requests might allow it?","accounts_in_message":[],"_revision_number":2},{"id":"307a0df1c64f5f07514ab65fa982bd123cb80873","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-06-09 22:50:04.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"22e7e25b85d5f368f5d65c9694a323c34fb43b4c","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-06-09 22:51:52.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"5d0e4922a856ae6f0ae8442e467ed4f34f38328a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-10 00:12:34.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/41/472541/4/check/gate-python-swiftclient-docs-ubuntu-xenial/f7be65e//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/41/472541/4/check/gate-python-swiftclient-pep8-ubuntu-xenial/df0da11/ : SUCCESS in 1m 42s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/41/472541/4/check/gate-python-swiftclient-python27-ubuntu-xenial/6c68cbe/ : SUCCESS in 1m 04s\n- gate-python-swiftclient-python35 http://logs.openstack.org/41/472541/4/check/gate-python-swiftclient-python35/70e90b1/ : SUCCESS in 2m 44s\n- gate-python-swiftclient-pypy http://logs.openstack.org/41/472541/4/check/gate-python-swiftclient-pypy/b7c91a8/ : SUCCESS in 1m 57s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/41/472541/4/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/e4ab0a1/ : SUCCESS in 1h 19m 47s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/4/check/gate-swift-dsvm-functional-ubuntu-xenial/fd88129/ : SUCCESS in 16m 02s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/41/472541/4/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/c767be9/ : SUCCESS in 15m 19s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/4/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/c4c0ac4/ : SUCCESS in 14m 07s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/41/472541/4/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/1227b66/ : SUCCESS in 9m 19s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"f0cc2780058da68ff8e9e322d6d99db9ba008c05","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-06-12 17:15:22.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)\n\nSeems sane.","accounts_in_message":[],"_revision_number":4},{"id":"7525fce94246f954c1269e18b851ae265200a3ca","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2017-06-13 13:43:23.000000000","message":"Patch Set 4: Code-Review+1\n\n(6 comments)\n\nPatch LGTM but I think it would be worth capturing the references in the commit message - in particular it took me a while to find the requests issue that fixed the underlying problem - so just voting +1.\n\nThe new test breaks when I revert the change.\n\nI confirmed the original work around is not necessary with requests \u003e\u003d 2.4.0. \n\n```\n\nswift@vm-15:~/swift$ python3 -c \"import requests; print(requests.post(\u0027http://httpbin.org/post\u0027, data\u003db\u0027hi\u0027, headers\u003d{}).text)\"\n{\n  \"args\": {},\n  \"data\": \"\",\n  \"files\": {},\n  \"form\": {\n    \"hi\": \"\"\n  },\n  \"headers\": {\n    \"Accept\": \"*/*\",\n    \"Accept-Encoding\": \"gzip, deflate\",\n    \"Connection\": \"close\",\n    \"Content-Length\": \"2\",\n    \"Content-Type\": \"application/x-www-form-urlencoded\",\n    \"Host\": \"httpbin.org\",\n    \"User-Agent\": \"python-requests/2.3.0 CPython/3.5.2 Linux/4.8.0-52-generic\"\n  },\n  \"json\": null,\n  \"origin\": \"79.68.30.192\",\n  \"url\": \"http://httpbin.org/post\"\n}\n\nswift@vm-15:~/swift$ pip3 install requests\u003d\u003d2.4.0Collecting requests\u003d\u003d2.4.0\n\n...\n\nswift@vm-15:~/swift$ python3 -c \"import requests; print(requests.post(\u0027http://httpbin.org/post\u0027, data\u003db\u0027hi\u0027, headers\u003d{}).text)\"\n{\n  \"args\": {},\n  \"data\": \"hi\",\n  \"files\": {},\n  \"form\": {},\n  \"headers\": {\n    \"Accept\": \"*/*\",\n    \"Accept-Encoding\": \"gzip, deflate\",\n    \"Connection\": \"close\",\n    \"Content-Length\": \"2\",\n    \"Host\": \"httpbin.org\",\n    \"User-Agent\": \"python-requests/2.4.0 CPython/3.5.2 Linux/4.8.0-52-generic\"\n  },\n  \"json\": null,\n  \"origin\": \"79.68.30.192\",\n  \"url\": \"http://httpbin.org/post\"\n}\n\nswift@vm-15:~/swift$ pip3 install requests -U\nCollecting requests\n\n...\n\nswift@vm-15:~/swift$ python3 -c \"import requests; print(requests.post(\u0027http://httpbin.org/post\u0027, data\u003db\u0027hi\u0027, headers\u003d{}).text)\"\n{\n  \"args\": {},\n  \"data\": \"hi\",\n  \"files\": {},\n  \"form\": {},\n  \"headers\": {\n    \"Accept\": \"*/*\",\n    \"Accept-Encoding\": \"gzip, deflate\",\n    \"Connection\": \"close\",\n    \"Content-Length\": \"2\",\n    \"Host\": \"httpbin.org\",\n    \"User-Agent\": \"python-requests/2.17.3\"\n  },\n  \"json\": null,\n  \"origin\": \"79.68.30.192\",\n  \"url\": \"http://httpbin.org/post\"\n}\n\n```","accounts_in_message":[],"_revision_number":4},{"id":"2df4696c65b28cd0da5e46c3637869f34583e14c","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-06-13 17:41:48.000000000","message":"Patch Set 4:\n\n(6 comments)\n\nThanks for the reviews!","accounts_in_message":[],"_revision_number":4},{"id":"63b14b35af22459f7e51393da9a6fbe162d60426","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-06-13 17:42:05.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"907444306fdfbd412427891b43cba14b087b9b4a","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2017-06-13 17:43:55.000000000","message":"Patch Set 5: Code-Review+2\n\nThanks Timur!","accounts_in_message":[],"_revision_number":5},{"id":"68e49bf6a8a84b5fb963a7a45d3fc41102f374ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-13 19:06:49.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/41/472541/5/check/gate-python-swiftclient-docs-ubuntu-xenial/96500bf//doc/build/html/ : SUCCESS in 2m 20s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/41/472541/5/check/gate-python-swiftclient-pep8-ubuntu-xenial/4f3fb78/ : SUCCESS in 1m 33s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/41/472541/5/check/gate-python-swiftclient-python27-ubuntu-xenial/14af731/ : SUCCESS in 1m 12s\n- gate-python-swiftclient-python35 http://logs.openstack.org/41/472541/5/check/gate-python-swiftclient-python35/a989a37/ : SUCCESS in 1m 43s\n- gate-python-swiftclient-pypy http://logs.openstack.org/41/472541/5/check/gate-python-swiftclient-pypy/95b1a91/ : SUCCESS in 2m 41s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/41/472541/5/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/52d1fe5/ : SUCCESS in 1h 20m 21s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/5/check/gate-swift-dsvm-functional-ubuntu-xenial/30d9b5b/ : SUCCESS in 21m 55s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/41/472541/5/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/f95dc81/ : SUCCESS in 27m 55s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/5/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/7e14eb4/ : SUCCESS in 14m 26s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/41/472541/5/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/2fd9a0b/ : SUCCESS in 16m 59s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"e39c8dc877cf4753445946934321f94017a9c92b","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-06-13 20:12:57.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"bfc5df09c41e894fefeb4498b9d7501b4262ad34","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-06-13 20:13:08.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"67e6b213b35aff97a55b1dd559420e5df6016ad6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-13 20:13:53.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"19e551886819577ced11accf36768c831b4a6f8e","date":"2017-06-13 22:07:47.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5},{"id":"23bf40ab791fa941296960851e3824ae5fa2bdeb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-13 22:07:47.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/41/472541/5/gate/gate-python-swiftclient-docs-ubuntu-xenial/4ff2f7e//doc/build/html/ : SUCCESS in 1m 46s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/41/472541/5/gate/gate-python-swiftclient-pep8-ubuntu-xenial/725d9df/ : SUCCESS in 1m 15s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/41/472541/5/gate/gate-python-swiftclient-python27-ubuntu-xenial/16a0526/ : SUCCESS in 2m 37s\n- gate-python-swiftclient-python35 http://logs.openstack.org/41/472541/5/gate/gate-python-swiftclient-python35/3c0a0db/ : SUCCESS in 2m 37s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/41/472541/5/gate/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/b59df7e/ : SUCCESS in 1h 30m 11s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/5/gate/gate-swift-dsvm-functional-ubuntu-xenial/6ed1ef3/ : SUCCESS in 26m 54s\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/472541/5/gate/gate-swiftclient-dsvm-functional-ubuntu-xenial/4d91750/ : SUCCESS in 16m 59s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"32f6b3c642fd5830a63e06ea4fac86956160312f","revisions":{"3a8a46f46b99776b6c7cc6e1675a9e6ed3312094":{"kind":"REWORK","_number":1,"created":"2017-06-09 06:54:17.000000000","uploader":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"ref":"refs/changes/41/472541/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/41/472541/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/1"}}},"commit":{"parents":[{"commit":"6d5e87a1830977d3962e5cf22476b0892b39ce81","subject":"Merge \"ISO 8601 timestamps for tempurl\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6d5e87a1830977d3962e5cf22476b0892b39ce81"}]}],"author":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 06:47:14.000000000","tz":-420},"committer":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 06:52:47.000000000","tz":-420},"subject":"Default to binary/octet-stream.","message":"Default to binary/octet-stream.\n\nWhen no Content-Type is passed in, python-swiftclient should default\nto binary/octect-stream. Passing a header with an empty value -- like\nswiftclient does now -- is not valid. Amazon S3 defaults to\nbinary/octect-stream and this seems like a reasonable default.\n\nFixes #1433767\n\nChange-Id: Ieb2243d2ff5326920a27ce8c3c6f0f5c396701ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3a8a46f46b99776b6c7cc6e1675a9e6ed3312094"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/3a8a46f46b99776b6c7cc6e1675a9e6ed3312094"}]},"branch":"refs/heads/master"},"339e9c93c06fe41a3d8069b0a1c8a8ff4afb79f1":{"kind":"REWORK","_number":2,"created":"2017-06-09 17:17:21.000000000","uploader":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"ref":"refs/changes/41/472541/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/41/472541/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/2"}}},"commit":{"parents":[{"commit":"6d5e87a1830977d3962e5cf22476b0892b39ce81","subject":"Merge \"ISO 8601 timestamps for tempurl\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6d5e87a1830977d3962e5cf22476b0892b39ce81"}]}],"author":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 06:47:14.000000000","tz":-420},"committer":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 17:17:05.000000000","tz":-420},"subject":"Default to binary/octet-stream.","message":"Default to binary/octet-stream.\n\nWhen no Content-Type is passed in, python-swiftclient should default\nto binary/octect-stream. Passing a header with an empty value -- like\nswiftclient does now -- is not valid. Amazon S3 defaults to\nbinary/octect-stream and this seems like a reasonable default.\n\nFixes #1433767\n\nChange-Id: Ieb2243d2ff5326920a27ce8c3c6f0f5c396701ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/339e9c93c06fe41a3d8069b0a1c8a8ff4afb79f1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/339e9c93c06fe41a3d8069b0a1c8a8ff4afb79f1"}]},"branch":"refs/heads/master"},"217b06d3ff522f27980ab27bc4ca1e5866778975":{"kind":"REWORK","_number":3,"created":"2017-06-09 22:50:04.000000000","uploader":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"ref":"refs/changes/41/472541/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/41/472541/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/3"}}},"commit":{"parents":[{"commit":"6d5e87a1830977d3962e5cf22476b0892b39ce81","subject":"Merge \"ISO 8601 timestamps for tempurl\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6d5e87a1830977d3962e5cf22476b0892b39ce81"}]}],"author":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 06:47:14.000000000","tz":-420},"committer":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 22:49:21.000000000","tz":-420},"subject":"Do not set Content-Type to \u0027\u0027.","message":"Do not set Content-Type to \u0027\u0027.\n\nPreviously, python-swiftclient worked around a requests issue where\nContent-Type could be set to application/x-www-form-urlencoded. It\nappears requests has resolved that issue and we no longer have to do\nthis. Moreover, I\u0027m unable to reproduce the original issue with the\nrequests library versions as old as 2.0.\n\nFixes #1433767\n\nChange-Id: Ieb2243d2ff5326920a27ce8c3c6f0f5c396701ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/217b06d3ff522f27980ab27bc4ca1e5866778975"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/217b06d3ff522f27980ab27bc4ca1e5866778975"}]},"branch":"refs/heads/master"},"cea8db1d913ca9a8e33859346ef2ddbe1879eacc":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2017-06-09 22:51:52.000000000","uploader":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"ref":"refs/changes/41/472541/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/41/472541/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/4"}}},"commit":{"parents":[{"commit":"6d5e87a1830977d3962e5cf22476b0892b39ce81","subject":"Merge \"ISO 8601 timestamps for tempurl\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6d5e87a1830977d3962e5cf22476b0892b39ce81"}]}],"author":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 06:47:14.000000000","tz":-420},"committer":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 22:50:08.000000000","tz":-420},"subject":"Do not set Content-Type to \u0027\u0027 with new requests.","message":"Do not set Content-Type to \u0027\u0027 with new requests.\n\nPreviously, python-swiftclient worked around a requests issue where\nContent-Type could be set to application/x-www-form-urlencoded when\nusing python3. This issue has been resolved and a fix released in\nrequests versions newer than 2.4. The patch makes the workaround\nconditional on the requests version, so that with sufficiently new\nrequests libraries, the Content-Type is not set.\n\nFor reference, requests 2.4 was released August 29th, 2014.\n\nFixes #1433767\n\nChange-Id: Ieb2243d2ff5326920a27ce8c3c6f0f5c396701ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/cea8db1d913ca9a8e33859346ef2ddbe1879eacc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/cea8db1d913ca9a8e33859346ef2ddbe1879eacc"}]},"branch":"refs/heads/master"},"32f6b3c642fd5830a63e06ea4fac86956160312f":{"kind":"REWORK","_number":5,"created":"2017-06-13 17:42:05.000000000","uploader":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"ref":"refs/changes/41/472541/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/41/472541/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/41/472541/5"}}},"commit":{"parents":[{"commit":"6d5e87a1830977d3962e5cf22476b0892b39ce81","subject":"Merge \"ISO 8601 timestamps for tempurl\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6d5e87a1830977d3962e5cf22476b0892b39ce81"}]}],"author":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-09 06:47:14.000000000","tz":-420},"committer":{"name":"Timur Alperovich","email":"timuralp@swiftstack.com","date":"2017-06-13 17:41:01.000000000","tz":-420},"subject":"Do not set Content-Type to \u0027\u0027 with new requests.","message":"Do not set Content-Type to \u0027\u0027 with new requests.\n\nPreviously, python-swiftclient worked around a requests issue where\nContent-Type could be set to application/x-www-form-urlencoded when\nusing python3. This issue has been resolved and a fix released in\nrequests 2.4 (fixed in subsequent releases as well). The patch makes\nthe workaround conditional on the requests version, so that with\nsufficiently new requests libraries, the Content-Type is not set.\n\nFor reference, requests 2.4 was released August 29th, 2014. The\nspecific issue filed in the requests tracker is:\nhttps://github.com/requests/requests/issues/2071.\n\nRelated-Change: I035f8b4b9c9ccdc79820b907770a48f86d0343b4\nCloses-Bug: #1433767\n\nChange-Id: Ieb2243d2ff5326920a27ce8c3c6f0f5c396701ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/32f6b3c642fd5830a63e06ea4fac86956160312f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/32f6b3c642fd5830a63e06ea4fac86956160312f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
