)]}'
{"swiftclient/client.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c3d3f3cdc7b751a900516aaa07da1906206a9a18","unresolved":false,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    # Add the version suffix in case of versionless Keystone endpoints. If"},{"line_number":557,"context_line":"    # auth_version is also unset it is likely that it is v3"},{"line_number":558,"context_line":"    if len(urlparse(auth_url).path) \u003c\u003d 1:"},{"line_number":559,"context_line":"        if auth_version and auth_version in AUTH_VERSIONS_V2:"},{"line_number":560,"context_line":"            auth_url \u003d urljoin(auth_url, \"v2.0\")"},{"line_number":561,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_781de071","line":558,"updated":"2017-06-13 16:49:42.000000000","message":"Hmm... so this won\u0027t help us with devstack [1]? FWIW, I\u0027ve tried adding some does-this-uri-include-a-version logic to swift3 [2]... but maybe that\u0027s still not enough?\n\n[1] https://github.com/openstack-dev/devstack/blob/902158b/lib/keystone#L116\n\n[2] https://review.openstack.org/#/c/384659/4/swift3/s3_token_middleware.py","commit_id":"2ff3102cf779a507af8fa39296154a17a60f540a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c3d3f3cdc7b751a900516aaa07da1906206a9a18","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        else:"},{"line_number":562,"context_line":"            auth_url \u003d urljoin(auth_url, \"v3\")"},{"line_number":563,"context_line":"            auth_version \u003d \u00273\u0027"},{"line_number":564,"context_line":"        logger.debug(\"Versionless auth_url - using %s as endpoint\" % auth_url)"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    # Legacy default if not set"},{"line_number":567,"context_line":"    if auth_version is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_42034e0e","line":564,"updated":"2017-06-13 16:49:42.000000000","message":"+1 on being explicit about what\u0027s going on.","commit_id":"2ff3102cf779a507af8fa39296154a17a60f540a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c3d3f3cdc7b751a900516aaa07da1906206a9a18","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            auth_version \u003d \u00273\u0027"},{"line_number":564,"context_line":"        logger.debug(\"Versionless auth_url - using %s as endpoint\" % auth_url)"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    # Legacy default if not set"},{"line_number":567,"context_line":"    if auth_version is None:"},{"line_number":568,"context_line":"        auth_version \u003d \u0027v2.0\u0027"},{"line_number":569,"context_line":"    ksclient, exceptions \u003d _import_keystone_client(auth_version)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_a236a2e5","line":566,"updated":"2017-06-13 16:49:42.000000000","message":"...and this will mainly be the case when using the client.py API directly, yeah? Through service.py (or the CLI) we still get the benefit of domain detection to get us v3? See https://github.com/openstack/python-swiftclient/blob/3.3.0/swiftclient/service.py#L97-L103","commit_id":"2ff3102cf779a507af8fa39296154a17a60f540a"}],"tests/unit/test_swiftclient.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c3d3f3cdc7b751a900516aaa07da1906206a9a18","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        self.assertEqual(1, len(fake_ks.calls))"},{"line_number":595,"context_line":"        self.assertEqual(\u0027http://auth_url/v2.0\u0027,"},{"line_number":596,"context_line":"                         fake_ks.calls[0].get(\u0027auth_url\u0027))"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    def test_auth_with_session(self):"},{"line_number":599,"context_line":"        mock_session \u003d mock.MagicMock()"},{"line_number":600,"context_line":"        mock_session.get_endpoint.return_value \u003d \u0027http://storagehost/v1/acct\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_6261aaa9","line":597,"updated":"2017-06-13 16:49:42.000000000","message":"Should we include a test that mirrors devstack\u0027s\n\n http://auth_url/identity\n\ninput?","commit_id":"2ff3102cf779a507af8fa39296154a17a60f540a"}]}