)]}'
{"id":"openstack%2Fpython-swiftclient~473740","triplet_id":"openstack%2Fpython-swiftclient~master~If7ecb67776cb77828f93ad8278cc5040015216b7","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1554885","hashtags":[],"change_id":"If7ecb67776cb77828f93ad8278cc5040015216b7","subject":"Add support for versionless endpoints","status":"MERGED","created":"2017-06-13 08:56:19.000000000","updated":"2017-09-19 07:38:30.000000000","submitted":"2017-08-29 02:15:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5f22d369b82afbe2bebf0c818543df1386bdba04","_number":473740,"virtual_id_number":473740,"owner":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-08-29 02:15:28.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-08-28 20:36:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":2,"date":"2017-06-13 18:17:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":1,"date":"2017-06-13 16:49:42.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-08-28 20:36:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-13 16:49:42.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2017-06-13 18:17:19.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2017-08-28 20:36:21.000000000","updated_by":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"reviewer":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"state":"REVIEWER"},{"updated":"2017-08-29 02:15:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2427247cac194ef0d3d63ccbd3a8a568ea1acfa7","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2017-06-13 08:56:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f611afe80026a18d954703b3e3ac10d253b2ec4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-13 10:30:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/40/473740/1/check/gate-python-swiftclient-docs-ubuntu-xenial/7283c61//doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/40/473740/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/2635e44/ : SUCCESS in 1m 46s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/40/473740/1/check/gate-python-swiftclient-python27-ubuntu-xenial/7be2d2c/ : SUCCESS in 1m 40s\n- gate-python-swiftclient-python35 http://logs.openstack.org/40/473740/1/check/gate-python-swiftclient-python35/045c978/ : SUCCESS in 2m 10s\n- gate-python-swiftclient-pypy http://logs.openstack.org/40/473740/1/check/gate-python-swiftclient-pypy/7aaf09a/ : SUCCESS in 2m 15s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/40/473740/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/1b0e575/ : SUCCESS in 1h 31m 20s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/40/473740/1/check/gate-swift-dsvm-functional-ubuntu-xenial/28a3a1b/ : SUCCESS in 23m 44s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/40/473740/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/106cd14/ : SUCCESS in 26m 24s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/40/473740/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/d55e6c0/ : SUCCESS in 17m 13s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/40/473740/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/5938a0d/ : SUCCESS in 18m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"92f211a62be685e80b88cf13ac6649b58d60ea30","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-06-13 15:08:50.000000000","message":"Patch Set 1: Code-Review+1\n\nSeems to have a similar stated purpose as another ongoing review [1], but the implementation is different?  It seems like the python-swiftclient lp bug #1554885 is surprisingly inconsistent for folks - so if this is a good clean fix w/o the side-effects and concerns from the other change - it\u0027d probably be good to get this landed (thanks Christian!)\n\n\n1. Change-Id: I3c0ed6648409f067c94413cdb49dee839de362ad","accounts_in_message":[],"_revision_number":1},{"id":"c3d3f3cdc7b751a900516aaa07da1906206a9a18","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-06-13 16:49:42.000000000","message":"Patch Set 1: Code-Review+1\n\n(4 comments)\n\nUgh. The more I think about all of this, the less I like how we rely on a heuristic rather than just asking the service to tell us what\u0027s supported. We really need to get a way to start locally caching things like\n\n* /info responses\n* tokens/storage urls\n* keystone discovery responses\n\nThat said, this seems like a reasonably safe heuristic to use? We err on the side of doing nothing rather than requiring an extra request every time we need to auth.\n\nMight be worth adding a test case to demonstrate that version-less urls get fixed when coming from the CLI, though; there\u0027s a lot of other massaging going on, so it\u0027d be nice to show that nothing goes wrong.","accounts_in_message":[],"_revision_number":1},{"id":"8ccd2e52662b70ca1ddc7aa41044b2b5ea458b94","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-06-13 18:17:19.000000000","message":"Patch Set 1: Code-Review+2\n\ndo it!  merge everything!  fix the bug!  WHOOOO!","accounts_in_message":[],"_revision_number":1},{"id":"5b5630d5f97c4d4a1e6d361e325746b677d2aea5","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-06-13 18:17:40.000000000","message":"Patch Set 1:\n\noh, but we probably want this too:\n\nhttps://review.openstack.org/473930","accounts_in_message":[],"_revision_number":1},{"id":"11a5a8992468ccc5643891661451f6adb4b30364","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-08-28 20:36:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nlgtm, tested against keystone with versionless, v2.0 and v3 endpoints. Also tested with tempauth v1.","accounts_in_message":[],"_revision_number":1},{"id":"4f0a92d01b7655c28f8a47900d3e9625fb618123","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-28 20:36:32.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f45536a8ba28f8203a8899f3097a3558cdc67062","date":"2017-08-29 02:15:28.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"9cc6db6fb355cb61e6c7acc5668afb9bd9a5a59f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-29 02:15:28.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/40/473740/1/gate/gate-python-swiftclient-docs-ubuntu-xenial/aa48200//doc/build/html/ : SUCCESS in 1m 46s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/40/473740/1/gate/gate-python-swiftclient-pep8-ubuntu-xenial/bc67735/ : SUCCESS in 1m 48s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/40/473740/1/gate/gate-python-swiftclient-python27-ubuntu-xenial/4eedcb9/ : SUCCESS in 4m 02s\n- gate-python-swiftclient-python35 http://logs.openstack.org/40/473740/1/gate/gate-python-swiftclient-python35/8ca8930/ : SUCCESS in 4m 02s\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/40/473740/1/gate/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/349dc89/ : SUCCESS in 1h 08m 54s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/40/473740/1/gate/gate-swift-dsvm-functional-ubuntu-xenial/78e9814/ : SUCCESS in 22m 13s\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/40/473740/1/gate/gate-swiftclient-dsvm-functional-ubuntu-xenial/3ab9c6b/ : SUCCESS in 17m 21s","accounts_in_message":[],"_revision_number":1},{"id":"55761121559f25456c85bb6aaf7727bcbd3a5342","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2017-09-19 07:38:30.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit ba6abe9b20923390383050c025c56f86088bc416","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2ff3102cf779a507af8fa39296154a17a60f540a","revisions":{"2ff3102cf779a507af8fa39296154a17a60f540a":{"kind":"REWORK","_number":1,"created":"2017-06-13 08:56:19.000000000","uploader":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"ref":"refs/changes/40/473740/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/40/473740/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/40/473740/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/40/473740/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/40/473740/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/40/473740/1"}}},"commit":{"parents":[{"commit":"f18d070b0be3511ecb86c3299469024132561bc8","subject":"Merge \"Fix MockHttpResponse to be more like the Real\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f18d070b0be3511ecb86c3299469024132561bc8"}]}],"author":{"name":"Christian Schwede","email":"cschwede@redhat.com","date":"2017-06-13 08:51:33.000000000","tz":120},"committer":{"name":"Christian Schwede","email":"cschwede@redhat.com","date":"2017-06-13 08:55:50.000000000","tz":120},"subject":"Add support for versionless endpoints","message":"Add support for versionless endpoints\n\nNewer deployments are using versionless Keystone endpoints, and most\nOpenStack clients already support this.\n\nThis patch enables this for Swift: if an auth_url without any path\ncomponent is found, it assumes a versionless endpoint will be used.\nIn this case the v3 suffix will be appended to the path if none\nauth_version is set, and v2.0 is appended if auth_version requires v2.\n\nCloses-Bug: 1554885\nRelated-Bug: 1691106\nChange-Id: If7ecb67776cb77828f93ad8278cc5040015216b7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2ff3102cf779a507af8fa39296154a17a60f540a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2ff3102cf779a507af8fa39296154a17a60f540a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}