)]}'
{"id":"openstack%2Fpython-swiftclient~473925","triplet_id":"openstack%2Fpython-swiftclient~master~I21298bfd39fe386b5ea19e3a6f4408d8a0459c92","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"I21298bfd39fe386b5ea19e3a6f4408d8a0459c92","subject":"Support pdb in tests better","status":"MERGED","created":"2017-06-13 17:51:13.000000000","updated":"2019-07-10 23:27:18.000000000","submitted":"2019-07-10 23:27:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"473925-1562801238310-a65eadfb","meta_rev_id":"9b78960c97ec8a06aa4df82decfa7fa0d367ca80","_number":473925,"virtual_id_number":473925,"owner":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2017-06-14 01:54:07.000000000","_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"date":"2017-06-14 07:11:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2017-06-13 19:41:00.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2019-07-10 23:27:18.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-09 17:03:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-09 17:03:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-14 01:54:07.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"},{"updated":"2017-06-14 07:11:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2019-07-09 17:03:11.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2019-07-10 23:27:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2d943af1c093b09fb250ce5c7ff770c1ab861548","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-06-13 17:51:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"852b6c812c09184b236979a075386f36c90da67e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-13 19:33:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/25/473925/1/check/gate-python-swiftclient-docs-ubuntu-xenial/865ba73//doc/build/html/ : SUCCESS in 2m 33s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/bad8989/ : SUCCESS in 2m 09s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-python-swiftclient-python27-ubuntu-xenial/1998153/ : SUCCESS in 1m 28s\n- gate-python-swiftclient-python35 http://logs.openstack.org/25/473925/1/check/gate-python-swiftclient-python35/17fb2d0/ : SUCCESS in 1m 05s\n- gate-python-swiftclient-pypy http://logs.openstack.org/25/473925/1/check/gate-python-swiftclient-pypy/1a973d8/ : SUCCESS in 2m 32s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/a1a6b00/ : SUCCESS in 1h 36m 13s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-swift-dsvm-functional-ubuntu-xenial/78c7225/ : FAILURE in 5m 39s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/25/473925/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/815a401/ : SUCCESS in 21m 08s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/41b1ffa/ : FAILURE in 5m 45s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/25/473925/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/9f01a8c/ : FAILURE in 5m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8626721bbae0b759ab9f37b7f9bf866410ba8d6c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-06-13 19:41:00.000000000","message":"Patch Set 1:\n\nFound this in a couple of logs\n\n2017-06-13 18:02:23.540 | Resolving tarballs.openstack.org (tarballs.openstack.org)... failed: Temporary failure in name resolution.","accounts_in_message":[],"_revision_number":1},{"id":"8c3a0abfb4068b760cd44c135e676af62850e6b6","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2017-06-14 01:54:07.000000000","message":"Patch Set 1:\n\nYup mocking stdout in some tests in the swift also means pdb (or if youe like me and more lazy pudb) fails. So yes, totally feel your pain here :)","accounts_in_message":[],"_revision_number":1},{"id":"99e3680670c77d8f6e20d8fd9add01bc2fe6bd11","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2017-06-14 05:39:03.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"31fdf41e726dce26ab74ab4193d907d028b78dc0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-14 07:11:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/25/473925/1/check/gate-python-swiftclient-docs-ubuntu-xenial/147dd91//doc/build/html/ : SUCCESS in 51s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/949749a/ : SUCCESS in 1m 42s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-python-swiftclient-python27-ubuntu-xenial/d732f68/ : SUCCESS in 2m 08s\n- gate-python-swiftclient-python35 http://logs.openstack.org/25/473925/1/check/gate-python-swiftclient-python35/f32dfbf/ : SUCCESS in 1m 30s\n- gate-python-swiftclient-pypy http://logs.openstack.org/25/473925/1/check/gate-python-swiftclient-pypy/9d48948/ : SUCCESS in 1m 38s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/20f28df/ : SUCCESS in 1h 30m 49s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-swift-dsvm-functional-ubuntu-xenial/b8e0b7d/ : SUCCESS in 21m 19s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/25/473925/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/36b2e51/ : SUCCESS in 16m 02s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/25/473925/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/7056143/ : SUCCESS in 13m 46s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/25/473925/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/4b32e9a/ : SUCCESS in 10m 23s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6134740d9c3bfd61c9cf24d3ecc92d248eecebe2","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-07-09 17:03:11.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8c5207f8b790d59872eee1e1609397e39d6d77c7","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-07-10 15:58:55.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"5b07cbfdb77e5a34aa1779be8bbfd166eb5b7204","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 21:36:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/25/473925/1/check/tempest-full/860df43/ : SUCCESS in 1h 48m 01s\n- openstack-tox-lower-constraints http://logs.openstack.org/25/473925/1/check/openstack-tox-lower-constraints/0d60cb7/ : SUCCESS in 3m 42s\n- openstack-tox-pypy http://logs.openstack.org/25/473925/1/check/openstack-tox-pypy/fec6641/ : SUCCESS in 3m 42s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/25/473925/1/check/openstack-tox-pep8/cb4fbb9/ : SUCCESS in 3m 21s\n- openstack-tox-py27 http://logs.openstack.org/25/473925/1/check/openstack-tox-py27/92ee110/ : SUCCESS in 3m 05s\n- openstack-tox-py35 http://logs.openstack.org/25/473925/1/check/openstack-tox-py35/50c6a18/ : SUCCESS in 3m 54s\n- openstack-tox-py36 http://logs.openstack.org/25/473925/1/check/openstack-tox-py36/d511050/ : SUCCESS in 3m 55s\n- openstack-tox-py37 http://logs.openstack.org/25/473925/1/check/openstack-tox-py37/6f7a247/ : SUCCESS in 3m 58s\n- openstack-tox-docs http://logs.openstack.org/25/473925/1/check/openstack-tox-docs/94531b7/html/ : SUCCESS in 2m 55s\n- swiftclient-swift-functional http://logs.openstack.org/25/473925/1/check/swiftclient-swift-functional/281cca9/ : SUCCESS in 35m 33s\n- swiftclient-functional http://logs.openstack.org/25/473925/1/check/swiftclient-functional/24dc810/ : SUCCESS in 24m 54s\n- swiftclient-functional-py2 http://logs.openstack.org/25/473925/1/check/swiftclient-functional-py2/4d689cf/ : SUCCESS in 20m 29s","accounts_in_message":[],"_revision_number":1},{"id":"9ff2a08f9ac00d39d32b3baa7d0f47b140eb67ba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 21:40:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d5811fd555470c716ffb112e679f9d5216a9382d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 23:27:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"9b78960c97ec8a06aa4df82decfa7fa0d367ca80","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 23:27:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/25/473925/1/gate/tempest-full/ae724f7/ : SUCCESS in 1h 44m 03s\n- openstack-tox-lower-constraints http://logs.openstack.org/25/473925/1/gate/openstack-tox-lower-constraints/262af55/ : SUCCESS in 3m 20s\n- openstack-tox-pep8 http://logs.openstack.org/25/473925/1/gate/openstack-tox-pep8/26fd7de/ : SUCCESS in 3m 14s\n- openstack-tox-py27 http://logs.openstack.org/25/473925/1/gate/openstack-tox-py27/9de27e1/ : SUCCESS in 3m 25s\n- openstack-tox-py35 http://logs.openstack.org/25/473925/1/gate/openstack-tox-py35/0f2276a/ : SUCCESS in 4m 46s\n- openstack-tox-py36 http://logs.openstack.org/25/473925/1/gate/openstack-tox-py36/ea37ead/ : SUCCESS in 3m 34s\n- openstack-tox-py37 http://logs.openstack.org/25/473925/1/gate/openstack-tox-py37/b9823e2/ : SUCCESS in 4m 04s\n- openstack-tox-docs http://logs.openstack.org/25/473925/1/gate/openstack-tox-docs/472a260/html/ : SUCCESS in 2m 39s\n- swiftclient-swift-functional http://logs.openstack.org/25/473925/1/gate/swiftclient-swift-functional/bc25dcb/ : SUCCESS in 30m 19s\n- swiftclient-functional http://logs.openstack.org/25/473925/1/gate/swiftclient-functional/8311439/ : SUCCESS in 18m 26s\n- swiftclient-functional-py2 http://logs.openstack.org/25/473925/1/gate/swiftclient-functional-py2/c95972a/ : SUCCESS in 22m 03s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"01f5a9f3af3a1630297a92dff0f998b4f0e97a49","revisions":{"01f5a9f3af3a1630297a92dff0f998b4f0e97a49":{"kind":"REWORK","_number":1,"created":"2017-06-13 17:51:13.000000000","uploader":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"ref":"refs/changes/25/473925/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/25/473925/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/25/473925/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/25/473925/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/25/473925/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/25/473925/1"}}},"commit":{"parents":[{"commit":"f18d070b0be3511ecb86c3299469024132561bc8","subject":"Merge \"Fix MockHttpResponse to be more like the Real\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f18d070b0be3511ecb86c3299469024132561bc8"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2017-06-13 17:46:10.000000000","tz":-420},"committer":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2017-06-13 17:51:09.000000000","tz":-420},"subject":"Support pdb in tests better","message":"Support pdb in tests better\n\nNot really \"better\" so much as \"at all\" - the thing we do with the\ncapture stderr *everywhere* is probably brilliant - but absolutely not\nstrictly necessary for every MockHttpTest TestCase and comes with the\nannoying overhead of trying to get into a debugger causes tests to hang\ninexplicably and you can\u0027t even do debug prints in tests!?\n\nNow if you add SWIFTCLIENT_DEBUG\u003d1 to your nose -vsx command you can not\nonly jump into debugger, but if you\u0027re \"in the know\" you could even get\nsome stderr print debugging going on!\n\nIf you\u0027re not \"in the know\" when you try to pdb.set_trace() the tests\nwill blow-up for you because we monkeypatch pdb when not in\nSWIFTCLIENT_DEBUG mode, you\u0027re welcome.\n\nChange-Id: I21298bfd39fe386b5ea19e3a6f4408d8a0459c92\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/01f5a9f3af3a1630297a92dff0f998b4f0e97a49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/01f5a9f3af3a1630297a92dff0f998b4f0e97a49"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}