)]}'
{"id":"openstack%2Fpython-swiftclient~477872","triplet_id":"openstack%2Fpython-swiftclient~master~I36a6997fdb806b4d0a9d064107cc1451c766c987","project":"openstack/python-swiftclient","branch":"master","topic":"627724","hashtags":[],"change_id":"I36a6997fdb806b4d0a9d064107cc1451c766c987","subject":"Enable some off-by-default checks","status":"MERGED","created":"2017-06-27 10:19:40.000000000","updated":"2019-03-30 07:17:20.000000000","submitted":"2019-03-30 07:17:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"477872-1553930240587-8896891f","meta_rev_id":"a7f567060bc486853149d1b13e0e71a84bf4d84d","_number":477872,"virtual_id_number":477872,"owner":{"_account_id":24883,"name":"wangzhenyu","email":"wangzy@fiberhome.com","username":"wangzhenyu"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2019-03-30 07:17:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-02-27 19:50:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-02-27 19:50:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-27 11:47:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2019-02-27 19:50:10.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2019-03-30 07:17:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"569985f64b39759b9d043538b9dcdceaa6ecae15","author":{"_account_id":24883,"name":"wangzhenyu","email":"wangzy@fiberhome.com","username":"wangzhenyu"},"date":"2017-06-27 10:19:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"464fbbdb46634e2241dbec3883e47776a7e53c46","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-27 11:47:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/72/477872/1/check/gate-python-swiftclient-docs-ubuntu-xenial/73fa22f//doc/build/html/ : SUCCESS in 1m 46s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/72/477872/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/96fe032/ : SUCCESS in 2m 02s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/72/477872/1/check/gate-python-swiftclient-python27-ubuntu-xenial/916c4a9/ : SUCCESS in 1m 50s\n- gate-python-swiftclient-python35 http://logs.openstack.org/72/477872/1/check/gate-python-swiftclient-python35/2fb8e36/ : SUCCESS in 1m 57s\n- gate-python-swiftclient-pypy http://logs.openstack.org/72/477872/1/check/gate-python-swiftclient-pypy/749b4c5/ : SUCCESS in 2m 42s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/72/477872/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/9a2a255/ : SUCCESS in 1h 23m 36s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/72/477872/1/check/gate-swift-dsvm-functional-ubuntu-xenial/5681b86/ : SUCCESS in 18m 06s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/72/477872/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/5ab03e7/ : SUCCESS in 20m 31s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/72/477872/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/fd2c804/ : SUCCESS in 15m 31s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/72/477872/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/5cd40ee/ : SUCCESS in 16m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6c2449f77c3ef22445b41b116b66e8814f2edbc9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-02-27 19:48:32.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"853f40f35ba01ea2481e084e16d823ba99e5d224","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-02-27 19:50:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nYeah, sure. Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"7057d0f93c8ae37d3c951b06b2e847d6afd016e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-28 00:12:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/72/477872/2/check/tempest-full/310fabd/ : SUCCESS in 2h 02m 57s\n- openstack-tox-lower-constraints http://logs.openstack.org/72/477872/2/check/openstack-tox-lower-constraints/493124c/ : SUCCESS in 4m 58s\n- openstack-tox-pypy http://logs.openstack.org/72/477872/2/check/openstack-tox-pypy/f98e3da/ : SUCCESS in 4m 46s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/72/477872/2/check/openstack-tox-pep8/8705150/ : SUCCESS in 3m 47s\n- openstack-tox-py27 http://logs.openstack.org/72/477872/2/check/openstack-tox-py27/3f145c5/ : SUCCESS in 4m 18s\n- openstack-tox-py35 http://logs.openstack.org/72/477872/2/check/openstack-tox-py35/c7bcd8d/ : SUCCESS in 4m 11s\n- openstack-tox-py36 http://logs.openstack.org/72/477872/2/check/openstack-tox-py36/e59ad8a/ : SUCCESS in 4m 51s\n- openstack-tox-docs http://logs.openstack.org/72/477872/2/check/openstack-tox-docs/2fdcc19/html/ : SUCCESS in 4m 39s\n- build-openstack-releasenotes http://logs.openstack.org/72/477872/2/check/build-openstack-releasenotes/eecc789/html/ : SUCCESS in 3m 39s\n- swiftclient-swift-functional http://logs.openstack.org/72/477872/2/check/swiftclient-swift-functional/05ca3b6/ : SUCCESS in 26m 52s\n- swiftclient-functional http://logs.openstack.org/72/477872/2/check/swiftclient-functional/5c05e64/ : SUCCESS in 17m 51s\n- swiftclient-functional-py2 http://logs.openstack.org/72/477872/2/check/swiftclient-functional-py2/0b37d46/ : SUCCESS in 19m 28s","accounts_in_message":[],"_revision_number":2},{"id":"19db4b1b81a2d099716ff084ef08be24fe907f61","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-29 20:43:39.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"41f67704672c28e3868e623b0c82e8f594b6f009","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-30 00:06:21.000000000","message":"Patch Set 2: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":2},{"id":"e3878ea45dedd87b4a1d7dd4dcc08651ee601167","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-03-30 03:40:51.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"1e8c711d01b37c74e4b5b5428182f99240504f69","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-30 05:15:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/72/477872/2/check/tempest-full/7bcca89/ : SUCCESS in 1h 32m 13s\n- openstack-tox-lower-constraints http://logs.openstack.org/72/477872/2/check/openstack-tox-lower-constraints/836f79d/ : SUCCESS in 4m 01s\n- openstack-tox-pypy http://logs.openstack.org/72/477872/2/check/openstack-tox-pypy/be42e4d/ : SUCCESS in 3m 34s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/72/477872/2/check/openstack-tox-pep8/ec21df6/ : SUCCESS in 2m 45s\n- openstack-tox-py27 http://logs.openstack.org/72/477872/2/check/openstack-tox-py27/3dcd75f/ : SUCCESS in 2m 54s\n- openstack-tox-py35 http://logs.openstack.org/72/477872/2/check/openstack-tox-py35/6200401/ : SUCCESS in 2m 49s\n- openstack-tox-py36 http://logs.openstack.org/72/477872/2/check/openstack-tox-py36/b154cc2/ : SUCCESS in 2m 51s\n- openstack-tox-py37 http://logs.openstack.org/72/477872/2/check/openstack-tox-py37/6372791/ : SUCCESS in 3m 28s\n- openstack-tox-docs http://logs.openstack.org/72/477872/2/check/openstack-tox-docs/79e4a57/html/ : SUCCESS in 2m 46s\n- build-openstack-releasenotes http://logs.openstack.org/72/477872/2/check/build-openstack-releasenotes/e710a3e/html/ : SUCCESS in 2m 18s\n- swiftclient-swift-functional http://logs.openstack.org/72/477872/2/check/swiftclient-swift-functional/90da5b6/ : SUCCESS in 23m 47s\n- swiftclient-functional http://logs.openstack.org/72/477872/2/check/swiftclient-functional/04a3f00/ : SUCCESS in 17m 04s\n- swiftclient-functional-py2 http://logs.openstack.org/72/477872/2/check/swiftclient-functional-py2/066d74d/ : SUCCESS in 15m 02s","accounts_in_message":[],"_revision_number":2},{"id":"348648544a03a6a71c39feddb7f038302c816ef5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-30 05:15:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"03d3a6f147e3acc81ba2ff8cf0481514eb76b03e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-30 07:17:20.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"e44386e0cc3befa558123264fc4f171636333caa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-30 07:17:20.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/72/477872/2/gate/tempest-full/86d0739/ : SUCCESS in 1h 59m 00s\n- openstack-tox-lower-constraints http://logs.openstack.org/72/477872/2/gate/openstack-tox-lower-constraints/f7fa187/ : SUCCESS in 3m 16s\n- openstack-tox-pep8 http://logs.openstack.org/72/477872/2/gate/openstack-tox-pep8/a86e89a/ : SUCCESS in 2m 19s\n- openstack-tox-py27 http://logs.openstack.org/72/477872/2/gate/openstack-tox-py27/0b894f9/ : SUCCESS in 2m 22s\n- openstack-tox-py35 http://logs.openstack.org/72/477872/2/gate/openstack-tox-py35/1a8c803/ : SUCCESS in 4m 14s\n- openstack-tox-py36 http://logs.openstack.org/72/477872/2/gate/openstack-tox-py36/77a8f5a/ : SUCCESS in 2m 26s\n- openstack-tox-py37 http://logs.openstack.org/72/477872/2/gate/openstack-tox-py37/6d39d01/ : SUCCESS in 4m 18s\n- openstack-tox-docs http://logs.openstack.org/72/477872/2/gate/openstack-tox-docs/a85d626/html/ : SUCCESS in 2m 18s\n- build-openstack-releasenotes http://logs.openstack.org/72/477872/2/gate/build-openstack-releasenotes/45cb3da/html/ : SUCCESS in 3m 13s\n- swiftclient-swift-functional http://logs.openstack.org/72/477872/2/gate/swiftclient-swift-functional/2eb1906/ : SUCCESS in 24m 32s\n- swiftclient-functional http://logs.openstack.org/72/477872/2/gate/swiftclient-functional/ed96115/ : SUCCESS in 17m 02s\n- swiftclient-functional-py2 http://logs.openstack.org/72/477872/2/gate/swiftclient-functional-py2/6bf433f/ : SUCCESS in 11m 33s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fd6e76029dc725ad48ae4e250f1c70a58740cad7","revisions":{"025a7f43200ed0b72cab72ba1abfad496fc8dadc":{"kind":"REWORK","_number":1,"created":"2017-06-27 10:19:40.000000000","uploader":{"_account_id":24883,"name":"wangzhenyu","email":"wangzy@fiberhome.com","username":"wangzhenyu"},"ref":"refs/changes/72/477872/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/72/477872/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/477872/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/477872/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/477872/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/72/477872/1"}}},"commit":{"parents":[{"commit":"1d57403668815ab8cef9d6598c06bf1c7e5355c0","subject":"Merge \"Skip checksum validation on partial downloads\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/1d57403668815ab8cef9d6598c06bf1c7e5355c0"}]}],"author":{"name":"wangzhenyu","email":"wangzy@fiberhome.com","date":"2017-06-27 10:15:51.000000000","tz":480},"committer":{"name":"wangzhenyu","email":"wangzy@fiberhome.com","date":"2017-06-27 10:19:14.000000000","tz":480},"subject":"Enable some off-by-default checks","message":"Enable some off-by-default checks\n\nSome of the available checks are disabled by default, like:\n[H106] Don’t put vim configuration in source files\n[H203] Use assertIs(Not)None to check for None\n\nChange-Id: I36a6997fdb806b4d0a9d064107cc1451c766c987\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/025a7f43200ed0b72cab72ba1abfad496fc8dadc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/025a7f43200ed0b72cab72ba1abfad496fc8dadc"}]},"branch":"refs/heads/master"},"fd6e76029dc725ad48ae4e250f1c70a58740cad7":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-02-27 19:48:32.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/72/477872/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/72/477872/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/477872/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/477872/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/72/477872/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/72/477872/2"}}},"commit":{"parents":[{"commit":"0ee7c8272e0de2d8c44fd98306d54fc290d74f38","subject":"Make proper functions instead of assigning lambdas","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0ee7c8272e0de2d8c44fd98306d54fc290d74f38"}]}],"author":{"name":"wangzhenyu","email":"wangzy@fiberhome.com","date":"2017-06-27 10:15:51.000000000","tz":480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2019-02-21 17:31:09.000000000","tz":-480},"subject":"Enable some off-by-default checks","message":"Enable some off-by-default checks\n\nSome of the available checks are disabled by default, like:\n[H106] Don’t put vim configuration in source files\n[H203] Use assertIs(Not)None to check for None\n\nChange-Id: I36a6997fdb806b4d0a9d064107cc1451c766c987\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/fd6e76029dc725ad48ae4e250f1c70a58740cad7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/fd6e76029dc725ad48ae4e250f1c70a58740cad7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}