)]}'
{"id":"openstack%2Fpython-swiftclient~498069","triplet_id":"openstack%2Fpython-swiftclient~master~Ia1638c216eff9db6fbe416bc0570c27cfdcfe730","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"Ia1638c216eff9db6fbe416bc0570c27cfdcfe730","subject":"Stop mutating header dicts","status":"MERGED","created":"2017-08-25 19:26:50.000000000","updated":"2018-07-17 01:05:14.000000000","submitted":"2018-07-17 01:05:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"498069-1531789514900-2aee0645","meta_rev_id":"29ccfec34a27bc729d2ea3c2f83916fcf726744f","_number":498069,"virtual_id_number":498069,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2017-08-25 20:40:36.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2018-07-17 01:05:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2017-08-25 19:52:07.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"recommended":{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2018-04-10 23:14:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":1,"date":"2018-07-12 00:25:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":2,"date":"2018-04-12 20:28:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},{"value":1,"date":"2018-07-11 23:29:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-25 20:40:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2018-04-10 23:14:24.000000000","updated_by":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"reviewer":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"state":"REVIEWER"},{"updated":"2018-04-12 20:28:43.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2018-07-11 23:29:20.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2018-07-12 00:25:50.000000000","updated_by":{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},"reviewer":{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},"state":"REVIEWER"},{"updated":"2018-07-17 01:05:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9dc77cd483013e1e86d6dbed2f95f53c4ad1430a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-08-25 19:26:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2bbdc3286fce7debaaf51c01bfd453684cc22704","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-08-25 19:38:32.000000000","message":"Patch Set 1: Code-Review+1\n\n(5 comments)\n\nidk, i\u0027m bored, i\u0027m sure with enough effort this would be a great idea.","accounts_in_message":[],"_revision_number":1},{"id":"8fd29a3641c920dd1398dfc3de0910218409799d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-08-25 19:52:07.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ac9b749a7f9aab25f7e16b4f0f6f7c0cc33fcc94","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-25 20:40:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-swiftclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/498069/1/check/gate-python-swiftclient-docs-ubuntu-xenial/387e5b2//doc/build/html/ : SUCCESS in 1m 51s\n- gate-python-swiftclient-pep8-ubuntu-xenial http://logs.openstack.org/69/498069/1/check/gate-python-swiftclient-pep8-ubuntu-xenial/3577cb8/ : SUCCESS in 1m 43s\n- gate-python-swiftclient-python27-ubuntu-xenial http://logs.openstack.org/69/498069/1/check/gate-python-swiftclient-python27-ubuntu-xenial/facf2c5/ : SUCCESS in 1m 44s\n- gate-python-swiftclient-python35 http://logs.openstack.org/69/498069/1/check/gate-python-swiftclient-python35/8e09947/ : SUCCESS in 1m 30s\n- gate-python-swiftclient-pypy http://logs.openstack.org/69/498069/1/check/gate-python-swiftclient-pypy/ac82599/ : SUCCESS in 2m 21s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial http://logs.openstack.org/69/498069/1/check/gate-tempest-dsvm-neutron-src-python-swiftclient-ubuntu-xenial/a3e1d97/ : SUCCESS in 1h 12m 52s\n- gate-swift-dsvm-functional-ubuntu-xenial http://logs.openstack.org/69/498069/1/check/gate-swift-dsvm-functional-ubuntu-xenial/c78b75d/ : SUCCESS in 18m 57s\n- gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/69/498069/1/check/gate-swift-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/866a25c/ : SUCCESS in 18m 52s (non-voting)\n- gate-swiftclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/69/498069/1/check/gate-swiftclient-dsvm-functional-ubuntu-xenial/cbfb0fb/ : SUCCESS in 16m 10s\n- gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/69/498069/1/check/gate-swiftclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/1f8368a/ : SUCCESS in 14m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d22f1bea4d42052ef28865bcf4c8067270ebb4dc","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2018-04-10 23:14:24.000000000","message":"Patch Set 1: Code-Review+1\n\nI think the side-effect of mutating headers is surprising. I would be curious if there is anyone that relies on this behavior. The patch looks great to me! :)","accounts_in_message":[],"_revision_number":1},{"id":"9c719279e57640660680c01a6fc880da48b0a09d","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2018-04-12 20:28:43.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nSo the pain was a test saying:\n\n    meta \u003d {\u0027x-something-meta\u0027: \u0027foo\u0027}\n    c.post(blah, blah, meta)\n    headers \u003d c.head(blah, blah)\n    for k, v in meta.items():\n        self.assertEqual(headers[k], v)\n\nwhich seems not unreasonable as long as case insensitivity or whatever.  I couldn\u0027t find any examples of httplib or urllib doing this and requests seems to avoid it as well [1] - so ... principle of least surprise may require we follow suit.\n\n1. https://github.com/requests/requests/blob/master/requests/models.py#L433","accounts_in_message":[],"_revision_number":1},{"id":"fc1b554968c4cf6c24c57f0c454038f1b08d435d","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2018-07-11 23:29:20.000000000","message":"Patch Set 1: Workflow+1\n\nlanding based on existing reviews","accounts_in_message":[],"_revision_number":1},{"id":"f286ca6988005de3b834bd3028dc3821584d9bbc","author":{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},"date":"2018-07-12 00:25:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"44b79a6774859dc2dfde6d78934ea228f575151a","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2018-07-16 18:59:40.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0a4c6ab28356976ba678931cbaf9acf589f025dd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-16 22:44:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/69/498069/1/check/openstack-tox-pep8/66e4e67/ : SUCCESS in 4m 00s\n- openstack-tox-py27 http://logs.openstack.org/69/498069/1/check/openstack-tox-py27/ac8ce4e/ : SUCCESS in 5m 12s\n- openstack-tox-py35 http://logs.openstack.org/69/498069/1/check/openstack-tox-py35/161ca62/ : SUCCESS in 4m 10s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/498069/1/check/build-openstack-sphinx-docs/e4a1ebd/html/ : SUCCESS in 4m 18s\n- openstack-tox-pypy http://logs.openstack.org/69/498069/1/check/openstack-tox-pypy/6096158/ : SUCCESS in 5m 05s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/69/498069/1/check/legacy-tempest-dsvm-neutron-src/2276af4/ : SUCCESS in 1h 33m 16s\n- legacy-swift-dsvm-functional http://logs.openstack.org/69/498069/1/check/legacy-swift-dsvm-functional/9d94b9a/ : SUCCESS in 26m 01s\n- legacy-swift-dsvm-functional-identity-v3-only http://logs.openstack.org/69/498069/1/check/legacy-swift-dsvm-functional-identity-v3-only/2c1a824/ : SUCCESS in 25m 11s (non-voting)\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/69/498069/1/check/legacy-swiftclient-dsvm-functional/86f65bd/ : SUCCESS in 19m 07s\n- legacy-swiftclient-dsvm-functional-identity-v3-only http://logs.openstack.org/69/498069/1/check/legacy-swiftclient-dsvm-functional-identity-v3-only/77b838d/ : SUCCESS in 20m 16s (non-voting)\n- openstack-tox-py36 http://logs.openstack.org/69/498069/1/check/openstack-tox-py36/0e25616/ : SUCCESS in 4m 07s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/69/498069/1/check/openstack-tox-lower-constraints/9a36e6d/ : SUCCESS in 6m 06s","accounts_in_message":[],"_revision_number":1},{"id":"b5786a42521af16b76f7440487d889880a66cf9a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-16 22:45:14.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a5cf65ace85e653476b1452fb2f78c4a60dc2338","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-17 01:05:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/69/498069/1/gate/openstack-tox-pep8/1c6cee9/ : SUCCESS in 4m 09s\n- openstack-tox-py27 http://logs.openstack.org/69/498069/1/gate/openstack-tox-py27/f37bdae/ : SUCCESS in 5m 03s\n- openstack-tox-py35 http://logs.openstack.org/69/498069/1/gate/openstack-tox-py35/6df536b/ : SUCCESS in 5m 09s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/498069/1/gate/build-openstack-sphinx-docs/50112dd/html/ : SUCCESS in 6m 44s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/69/498069/1/gate/legacy-tempest-dsvm-neutron-src/565081a/ : SUCCESS in 2h 01m 49s\n- legacy-swift-dsvm-functional http://logs.openstack.org/69/498069/1/gate/legacy-swift-dsvm-functional/bf0ca1f/ : SUCCESS in 26m 30s\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/69/498069/1/gate/legacy-swiftclient-dsvm-functional/8d0d8d0/ : SUCCESS in 20m 31s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/498069/1/gate/openstack-tox-lower-constraints/370c7ed/ : SUCCESS in 5m 41s","accounts_in_message":[],"_revision_number":1},{"id":"29ccfec34a27bc729d2ea3c2f83916fcf726744f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-17 01:05:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ae5fd46e8772e50a0ab2ac89216188b1cdc83d8e","revisions":{"ae5fd46e8772e50a0ab2ac89216188b1cdc83d8e":{"kind":"REWORK","_number":1,"created":"2017-08-25 19:26:50.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/69/498069/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/69/498069/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/69/498069/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/69/498069/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/69/498069/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/69/498069/1"}}},"commit":{"parents":[{"commit":"f323bb4824d98e74fdd5e357526ce678d0f7d45a","subject":"Trying out the new releasenotes jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/f323bb4824d98e74fdd5e357526ce678d0f7d45a"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-08-25 19:13:12.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-08-25 19:26:03.000000000","tz":-420},"subject":"Stop mutating header dicts","message":"Stop mutating header dicts\n\nChange-Id: Ia1638c216eff9db6fbe416bc0570c27cfdcfe730\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ae5fd46e8772e50a0ab2ac89216188b1cdc83d8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/ae5fd46e8772e50a0ab2ac89216188b1cdc83d8e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}