)]}'
{"id":"openstack%2Fpython-swiftclient~538349","triplet_id":"openstack%2Fpython-swiftclient~master~I76be70ddb289bd4f1054a684a247279ab16ca34a","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"I76be70ddb289bd4f1054a684a247279ab16ca34a","subject":"Treat 404 as success when deleting segments","status":"MERGED","created":"2018-01-26 22:14:32.000000000","updated":"2018-07-12 01:46:49.000000000","submitted":"2018-07-12 01:46:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"538349-1531360009345-5cabf1e8","meta_rev_id":"39f57cf9121fa0d4f518f5ed39b96b1beb30a936","_number":538349,"virtual_id_number":538349,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2018-07-12 01:46:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"date":"2018-01-29 18:23:32.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"date":"2018-07-12 01:04:54.000000000","_account_id":26431,"name":"daixianmeng","email":"daixianmeng@yovole.com","username":"daixianmeng"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"recommended":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2018-07-12 00:24:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":1,"date":"2018-01-29 16:02:32.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-01-26 22:27:54.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":26431,"name":"daixianmeng","email":"daixianmeng@yovole.com","username":"daixianmeng"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":0,"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},{"value":1,"date":"2018-07-11 23:29:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":26431,"name":"daixianmeng","email":"daixianmeng@yovole.com","username":"daixianmeng"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26431,"name":"daixianmeng","email":"daixianmeng@yovole.com","username":"daixianmeng"},{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-26 22:27:54.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2018-01-29 16:02:32.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2018-07-11 23:29:08.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2018-07-12 00:24:27.000000000","updated_by":{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},"reviewer":{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},"state":"REVIEWER"},{"updated":"2018-07-12 01:04:54.000000000","updated_by":{"_account_id":26431,"name":"daixianmeng","email":"daixianmeng@yovole.com","username":"daixianmeng"},"reviewer":{"_account_id":26431,"name":"daixianmeng","email":"daixianmeng@yovole.com","username":"daixianmeng"},"state":"REVIEWER"},{"updated":"2018-07-12 01:46:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3096be3a66b7dffacc31db4cb291270fd9f875a7","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-01-26 22:14:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2085e32f198fdf4e506b4b3f5dd6f9ec9f9e3838","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-01-26 22:16:32.000000000","message":"Patch Set 1:\n\nThings like\n\nTraceback (most recent call last):\n  File \"/Users/tburke/Code/openstack/python-swiftclient/swiftclient/service.py\", line 2474, in _delete_segment\n    conn.delete_object(container, obj, response_dict\u003dresults_dict)\n  File \"/Users/tburke/Code/openstack/python-swiftclient/swiftclient/client.py\", line 1862, in delete_object\n    headers\u003dheaders)\n  File \"/Users/tburke/Code/openstack/python-swiftclient/swiftclient/client.py\", line 1691, in _retry\n    service_token\u003dself.service_token, **kwargs)\n  File \"/Users/tburke/Code/openstack/python-swiftclient/swiftclient/client.py\", line 1498, in delete_object\n    raise ClientException.from_response(resp, \u0027Object DELETE failed\u0027, body)\nClientException: Object DELETE failed: http://saio:8080/v1/AUTH_dev/c_segments/slo/slo/1517003976.295687/4194304/2097152/00000000 404 Not Found  [first 60 chars of response] \u003chtml\u003e\u003ch1\u003eNot Found\u003c/h1\u003e\u003cp\u003eThe resource could not be found.\u003c\n\n...aren\u0027t super-useful generally.","accounts_in_message":[],"_revision_number":1},{"id":"a3229eb27954370c83532896a90244ca6bddfcb6","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2018-01-26 22:27:54.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"07e370a4448a50ae65f256cf97c176b0b17c72e7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-26 23:38:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/49/538349/1/check/openstack-tox-pep8/26bf26d/ : SUCCESS in 4m 29s\n- openstack-tox-py27 http://logs.openstack.org/49/538349/1/check/openstack-tox-py27/5af361c/ : SUCCESS in 4m 25s\n- openstack-tox-py35 http://logs.openstack.org/49/538349/1/check/openstack-tox-py35/e0864d2/ : SUCCESS in 4m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/49/538349/1/check/build-openstack-sphinx-docs/5cffc01/html/ : SUCCESS in 4m 21s\n- openstack-tox-pypy http://logs.openstack.org/49/538349/1/check/openstack-tox-pypy/17c38e8/ : SUCCESS in 8m 57s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/49/538349/1/check/legacy-tempest-dsvm-neutron-src/c358251/ : SUCCESS in 1h 12m 23s\n- legacy-swift-dsvm-functional http://logs.openstack.org/49/538349/1/check/legacy-swift-dsvm-functional/0fd515d/ : SUCCESS in 23m 30s\n- legacy-swift-dsvm-functional-identity-v3-only http://logs.openstack.org/49/538349/1/check/legacy-swift-dsvm-functional-identity-v3-only/ee3a100/ : SUCCESS in 24m 17s (non-voting)\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/49/538349/1/check/legacy-swiftclient-dsvm-functional/b31011a/ : SUCCESS in 18m 05s\n- legacy-swiftclient-dsvm-functional-identity-v3-only http://logs.openstack.org/49/538349/1/check/legacy-swiftclient-dsvm-functional-identity-v3-only/fb11bee/ : SUCCESS in 15m 58s (non-voting)\n- openstack-tox-py36 http://logs.openstack.org/49/538349/1/check/openstack-tox-py36/78ff956/ : SUCCESS in 12m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6993b9960ed9eabc7afd59b9e3071b7653720fd3","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2018-01-29 16:02:32.000000000","message":"Patch Set 1: Code-Review+1\n\nI think not returning the traceback makes sense.  We could maybe do better in the general sense for *any* ClientError?\n\nBut if I swift delete something that 404\u0027s I exit 1 - why is it obvious that deleting segments should silently squash 404?  Does it cause the remaining segments to not get DELETEs issued or the command to exit early?  Loss of information seems dubious?","accounts_in_message":[],"_revision_number":1},{"id":"7d3b0540b95437a6be837f45625a251444de0097","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-01-29 18:23:32.000000000","message":"Patch Set 1:\n\nWe call this in two places: _delete_object and _upload_object_job. In both cases, we\u0027re trying to clean up a large object. I\u0027m not sure that it matters to us whether the large object was broken or not; we want it (and all of its segments) gone. I don\u0027t think it\u0027s terribly valuable to know that some segments were missing or your container listings are out-of-date.","accounts_in_message":[],"_revision_number":1},{"id":"c966b01d8ceffc9132857e6795f4130657311c58","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2018-07-11 23:29:08.000000000","message":"Patch Set 1: Workflow+1\n\nlanding based on existing reviews","accounts_in_message":[],"_revision_number":1},{"id":"0233913bb9c1939f6901206b92a12a4395459d6f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-11 23:29:28.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2e19bb9bf61f46ab7126da20ab46e0512a2b41ef","author":{"_account_id":27190,"name":"Leopard Ma","email":"mabao@inspur.com","username":"LeopardMa"},"date":"2018-07-12 00:24:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e9dbe22434ff6dbee4e208684cac8c1aa5145c12","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 01:46:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/49/538349/1/gate/openstack-tox-pep8/0b8c3a0/ : SUCCESS in 2m 33s\n- openstack-tox-py27 http://logs.openstack.org/49/538349/1/gate/openstack-tox-py27/241b653/ : SUCCESS in 3m 44s\n- openstack-tox-py35 http://logs.openstack.org/49/538349/1/gate/openstack-tox-py35/58f4157/ : SUCCESS in 3m 14s\n- build-openstack-sphinx-docs http://logs.openstack.org/49/538349/1/gate/build-openstack-sphinx-docs/e991f88/html/ : SUCCESS in 3m 07s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/49/538349/1/gate/legacy-tempest-dsvm-neutron-src/869d4b8/ : SUCCESS in 1h 18m 40s\n- legacy-swift-dsvm-functional http://logs.openstack.org/49/538349/1/gate/legacy-swift-dsvm-functional/78cf84c/ : SUCCESS in 22m 57s\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/49/538349/1/gate/legacy-swiftclient-dsvm-functional/48be8a4/ : SUCCESS in 15m 20s\n- openstack-tox-lower-constraints http://logs.openstack.org/49/538349/1/gate/openstack-tox-lower-constraints/d3a8215/ : SUCCESS in 4m 32s","accounts_in_message":[],"_revision_number":1},{"id":"39f57cf9121fa0d4f518f5ed39b96b1beb30a936","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 01:46:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2901e1e9ef1932b0b3874e608422bbfdfbd1448a","revisions":{"2901e1e9ef1932b0b3874e608422bbfdfbd1448a":{"kind":"REWORK","_number":1,"created":"2018-01-26 22:14:32.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/49/538349/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/49/538349/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/49/538349/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/49/538349/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/49/538349/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/49/538349/1"}}},"commit":{"parents":[{"commit":"2faea932870956583f83226886d33304ee1eee46","subject":"Allow for object uploads \u003e 5GB from stdin.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2faea932870956583f83226886d33304ee1eee46"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-01-26 22:14:18.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-01-26 22:14:18.000000000","tz":-480},"subject":"Treat 404 as success when deleting segments","message":"Treat 404 as success when deleting segments\n\nChange-Id: I76be70ddb289bd4f1054a684a247279ab16ca34a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2901e1e9ef1932b0b3874e608422bbfdfbd1448a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2901e1e9ef1932b0b3874e608422bbfdfbd1448a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}