)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ba83e5cbf13e32045f454d5d302a446ea1899da9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"HOWEVER, the current python\u0027s httplib and requests module used by python-swiftclient doesn\u0027t"},{"line_number":60,"context_line":"support expects: 100-continue header [2] and the thread proposed a fix [3] is not super active."},{"line_number":61,"context_line":"And we know the reason we depends on the library is to fix a security issue that existed"},{"line_number":62,"context_line":"in older python-swiftclient [4] so that we should touch around it super carefully."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"In the reality, as the hot fix, this patch try to mitigate the unfortunate situation"},{"line_number":65,"context_line":"described above WITHOUT 100-continue fix, just users can force to re-auth when any errors"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_fda19ff9","line":62,"range":{"start_line":62,"start_character":28,"end_line":62,"end_character":31},"updated":"2018-03-13 03:22:46.000000000","message":"There is no 4. below.","commit_id":"2e7fae4c4c58cb236d349699c56b8584397bc20c"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"bd497ff8a74a171f95503e2b3d7decdca6514ff9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"HOWEVER, the current python\u0027s httplib and requests module used by python-swiftclient doesn\u0027t"},{"line_number":60,"context_line":"support expects: 100-continue header [2] and the thread proposed a fix [3] is not super active."},{"line_number":61,"context_line":"And we know the reason we depends on the library is to fix a security issue that existed"},{"line_number":62,"context_line":"in older python-swiftclient [4] so that we should touch around it super carefully."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"In the reality, as the hot fix, this patch try to mitigate the unfortunate situation"},{"line_number":65,"context_line":"described above WITHOUT 100-continue fix, just users can force to re-auth when any errors"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_1de253a1","line":62,"range":{"start_line":62,"start_character":28,"end_line":62,"end_character":31},"in_reply_to":"df7087c5_fda19ff9","updated":"2018-03-13 03:30:51.000000000","message":"Done","commit_id":"2e7fae4c4c58cb236d349699c56b8584397bc20c"}],"swiftclient/client.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"18693b563d2359dab3abf444f31e20c81bfc3e94","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"                    self.url \u003d self.token \u003d self.service_token \u003d None"},{"line_number":1716,"context_line":""},{"line_number":1717,"context_line":"                    if retried_auth or not should_retry:"},{"line_number":1718,"context_line":"                        raise"},{"line_number":1719,"context_line":"                    retried_auth \u003d True"},{"line_number":1720,"context_line":"                elif self.attempts \u003e self.retries or err.http_status is None:"},{"line_number":1721,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_d9ea8fd6","line":1718,"updated":"2018-03-13 23:10:19.000000000","message":"with 401 we only get once shot to retry before we just re-raise the 401","commit_id":"e65070964c7b1e04119c87e5f344d39358780d18"}],"swiftclient/shell.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ba83e5cbf13e32045f454d5d302a446ea1899da9","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"    parser.add_argument(\u0027--force-auth-retry\u0027,"},{"line_number":1615,"context_line":"                        action\u003d\u0027store_true\u0027, dest\u003d\u0027force_auth_retry\u0027,"},{"line_number":1616,"context_line":"                        default\u003dFalse,"},{"line_number":1617,"context_line":"                        help\u003d\u0027Force to try to re-auth when swiftclient got \u0027"},{"line_number":1618,"context_line":"                             \u0027any errors other than 401 unauthorized\u0027)"},{"line_number":1619,"context_line":""},{"line_number":1620,"context_line":"    os_grp \u003d parser.add_argument_group(\"OpenStack authentication options\")"},{"line_number":1621,"context_line":"    os_grp.add_argument(\u0027--os-username\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_9ddae348","line":1618,"range":{"start_line":1617,"start_character":30,"end_line":1618,"end_character":68},"updated":"2018-03-13 03:22:46.000000000","message":"Maybe worded as:\n\n Force a re-auth attempt on any error other than a 401 unauthorized.","commit_id":"2e7fae4c4c58cb236d349699c56b8584397bc20c"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"bd497ff8a74a171f95503e2b3d7decdca6514ff9","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"    parser.add_argument(\u0027--force-auth-retry\u0027,"},{"line_number":1615,"context_line":"                        action\u003d\u0027store_true\u0027, dest\u003d\u0027force_auth_retry\u0027,"},{"line_number":1616,"context_line":"                        default\u003dFalse,"},{"line_number":1617,"context_line":"                        help\u003d\u0027Force to try to re-auth when swiftclient got \u0027"},{"line_number":1618,"context_line":"                             \u0027any errors other than 401 unauthorized\u0027)"},{"line_number":1619,"context_line":""},{"line_number":1620,"context_line":"    os_grp \u003d parser.add_argument_group(\"OpenStack authentication options\")"},{"line_number":1621,"context_line":"    os_grp.add_argument(\u0027--os-username\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_3d71570d","line":1618,"range":{"start_line":1617,"start_character":30,"end_line":1618,"end_character":68},"in_reply_to":"df7087c5_9ddae348","updated":"2018-03-13 03:30:51.000000000","message":"Done","commit_id":"2e7fae4c4c58cb236d349699c56b8584397bc20c"}]}
