)]}'
{"id":"openstack%2Fpython-swiftclient~566380","triplet_id":"openstack%2Fpython-swiftclient~master~I671016d7992a1922b786b4eb8876b3fbb2532e15","project":"openstack/python-swiftclient","branch":"master","topic":"cleanup/auth_version","hashtags":[],"change_id":"I671016d7992a1922b786b4eb8876b3fbb2532e15","subject":"Use a valid default for auth_version","status":"MERGED","created":"2018-05-04 18:37:25.000000000","updated":"2018-06-06 04:11:31.000000000","submitted":"2018-06-06 04:11:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"566380-1528258291645-b4e09746","meta_rev_id":"01233a024b294d6b68fbc949ce0dcc0b0744cc68","_number":566380,"virtual_id_number":566380,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"date":"2018-06-05 18:01:40.000000000","_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2018-06-06 04:11:31.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-06-05 22:07:12.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":2,"date":"2018-06-05 16:51:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":2,"date":"2018-05-07 20:00:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":1,"date":"2018-06-05 16:51:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-05-07 20:00:44.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2018-06-05 16:51:13.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2018-06-05 18:01:40.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2018-06-05 22:07:12.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2018-06-06 04:11:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fa352a2a3ab3854a9be97078e6eadbb69b95ab62","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2018-05-04 18:37:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a3b2f5b9ff4db8785ff33fcbdb04686e272a2b63","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-04 19:57:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/80/566380/1/check/openstack-tox-pep8/0de9e0c/ : SUCCESS in 2m 56s\n- openstack-tox-py27 http://logs.openstack.org/80/566380/1/check/openstack-tox-py27/79c0a4f/ : SUCCESS in 4m 05s\n- openstack-tox-py35 http://logs.openstack.org/80/566380/1/check/openstack-tox-py35/c84d319/ : SUCCESS in 2m 41s\n- build-openstack-sphinx-docs http://logs.openstack.org/80/566380/1/check/build-openstack-sphinx-docs/e87a784/html/ : SUCCESS in 3m 04s\n- openstack-tox-pypy http://logs.openstack.org/80/566380/1/check/openstack-tox-pypy/c41804d/ : SUCCESS in 3m 21s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/80/566380/1/check/legacy-tempest-dsvm-neutron-src/c50ad4b/ : SUCCESS in 1h 18m 36s\n- legacy-swift-dsvm-functional http://logs.openstack.org/80/566380/1/check/legacy-swift-dsvm-functional/be93b9c/ : SUCCESS in 27m 27s\n- legacy-swift-dsvm-functional-identity-v3-only http://logs.openstack.org/80/566380/1/check/legacy-swift-dsvm-functional-identity-v3-only/c7175c8/ : SUCCESS in 25m 21s (non-voting)\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/80/566380/1/check/legacy-swiftclient-dsvm-functional/1308c77/ : SUCCESS in 18m 57s\n- legacy-swiftclient-dsvm-functional-identity-v3-only http://logs.openstack.org/80/566380/1/check/legacy-swiftclient-dsvm-functional-identity-v3-only/912b1ba/ : SUCCESS in 17m 02s (non-voting)\n- openstack-tox-py36 http://logs.openstack.org/80/566380/1/check/openstack-tox-py36/b9fbac5/ : SUCCESS in 4m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6e598691deb4af663256507d738842811ae1e2a6","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2018-05-07 20:00:44.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f3bfcd1f154db4b92dddb7686a23930aa8a35ab9","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2018-06-05 16:51:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c23b7ccda115dabe3bec6510258b0c8b5f51028d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-05 16:51:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8e7a8442ad291267299322589c3fe015455d15e5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-05 17:53:16.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/80/566380/1/gate/openstack-tox-pep8/0d4edcb/ : SUCCESS in 2m 35s\n- openstack-tox-py27 http://logs.openstack.org/80/566380/1/gate/openstack-tox-py27/ec7c9f8/ : SUCCESS in 2m 54s\n- openstack-tox-py35 http://logs.openstack.org/80/566380/1/gate/openstack-tox-py35/27be4a2/ : SUCCESS in 3m 22s\n- build-openstack-sphinx-docs http://logs.openstack.org/80/566380/1/gate/build-openstack-sphinx-docs/70e798f/html/ : SUCCESS in 3m 57s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/80/566380/1/gate/legacy-tempest-dsvm-neutron-src/a032b3d/ : FAILURE in 59m 17s\n- legacy-swift-dsvm-functional http://logs.openstack.org/80/566380/1/gate/legacy-swift-dsvm-functional/cfd5b4e/ : SUCCESS in 26m 16s\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/80/566380/1/gate/legacy-swiftclient-dsvm-functional/b9ad280/ : SUCCESS in 18m 10s\n- openstack-tox-lower-constraints http://logs.openstack.org/80/566380/1/gate/openstack-tox-lower-constraints/7b6a522/ : SUCCESS in 4m 10s","accounts_in_message":[],"_revision_number":1},{"id":"b77b54132bc0d0e73cafc8156693a973bcdb74a8","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2018-06-05 18:01:40.000000000","message":"Patch Set 1:\n\nI noticed Zuul failed, I think you hit bug(s):\n\n- legacy-tempest-dsvm-neutron-src: https://bugs.launchpad.net/bugs/1770786\n\nIf you believe we\u0027ve correctly identified the failure, feel free to leave a \u0027recheck\u0027 comment to run the tests again.\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":1},{"id":"0e7675238f2d5e183ea9ddda1d5caf81ec56ddad","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-06-05 22:07:12.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e5f105f9c33484910739c5983dfced98ad9cae4b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-05 23:26:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/80/566380/1/check/openstack-tox-pep8/2e1c81f/ : SUCCESS in 3m 01s\n- openstack-tox-py27 http://logs.openstack.org/80/566380/1/check/openstack-tox-py27/77543be/ : SUCCESS in 2m 45s\n- openstack-tox-py35 http://logs.openstack.org/80/566380/1/check/openstack-tox-py35/e716f87/ : SUCCESS in 2m 27s\n- build-openstack-sphinx-docs http://logs.openstack.org/80/566380/1/check/build-openstack-sphinx-docs/2ec5ad0/html/ : SUCCESS in 2m 09s\n- openstack-tox-pypy http://logs.openstack.org/80/566380/1/check/openstack-tox-pypy/86e60bf/ : SUCCESS in 3m 49s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/80/566380/1/check/legacy-tempest-dsvm-neutron-src/99eebb5/ : SUCCESS in 1h 16m 18s\n- legacy-swift-dsvm-functional http://logs.openstack.org/80/566380/1/check/legacy-swift-dsvm-functional/65af490/ : SUCCESS in 25m 22s\n- legacy-swift-dsvm-functional-identity-v3-only http://logs.openstack.org/80/566380/1/check/legacy-swift-dsvm-functional-identity-v3-only/93f337a/ : SUCCESS in 28m 46s (non-voting)\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/80/566380/1/check/legacy-swiftclient-dsvm-functional/d7e3ba5/ : SUCCESS in 18m 36s\n- legacy-swiftclient-dsvm-functional-identity-v3-only http://logs.openstack.org/80/566380/1/check/legacy-swiftclient-dsvm-functional-identity-v3-only/5f47ca0/ : SUCCESS in 14m 39s (non-voting)\n- openstack-tox-py36 http://logs.openstack.org/80/566380/1/check/openstack-tox-py36/d402374/ : SUCCESS in 2m 16s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/80/566380/1/check/openstack-tox-lower-constraints/cbf138a/ : SUCCESS in 4m 14s","accounts_in_message":[],"_revision_number":1},{"id":"d091117c4e892dfd546695a61aa7a09397a1e392","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-05 23:26:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ea3311cdaaa8abea1cdbf3ca7eecfe8137a9ae6f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-06 04:11:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"c096e89b178998b327126fa05699a3f5dae64473","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-06 04:11:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/80/566380/1/gate/openstack-tox-pep8/7032f29/ : SUCCESS in 3m 30s\n- openstack-tox-py27 http://logs.openstack.org/80/566380/1/gate/openstack-tox-py27/3386045/ : SUCCESS in 3m 41s\n- openstack-tox-py35 http://logs.openstack.org/80/566380/1/gate/openstack-tox-py35/6db82c7/ : SUCCESS in 4m 21s\n- build-openstack-sphinx-docs http://logs.openstack.org/80/566380/1/gate/build-openstack-sphinx-docs/8a961ce/html/ : SUCCESS in 3m 39s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/80/566380/1/gate/legacy-tempest-dsvm-neutron-src/8367059/ : SUCCESS in 1h 28m 34s\n- legacy-swift-dsvm-functional http://logs.openstack.org/80/566380/1/gate/legacy-swift-dsvm-functional/fd14ecc/ : SUCCESS in 25m 29s\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/80/566380/1/gate/legacy-swiftclient-dsvm-functional/c8380fd/ : SUCCESS in 16m 59s\n- openstack-tox-lower-constraints http://logs.openstack.org/80/566380/1/gate/openstack-tox-lower-constraints/6f26970/ : SUCCESS in 6m 24s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7a13754eebb15a3c7fa507ad1d58e3c4460e302c","revisions":{"7a13754eebb15a3c7fa507ad1d58e3c4460e302c":{"kind":"REWORK","_number":1,"created":"2018-05-04 18:37:25.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/80/566380/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/80/566380/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/80/566380/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/80/566380/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/80/566380/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/80/566380/1"}}},"commit":{"parents":[{"commit":"5ed910cd32b0148b086ba4102a082aadb5e283bc","subject":"Trivial: Update pypi url to new url","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/5ed910cd32b0148b086ba4102a082aadb5e283bc"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2018-05-04 18:31:03.000000000","tz":-300},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2018-05-04 18:31:03.000000000","tz":-300},"subject":"Use a valid default for auth_version","message":"Use a valid default for auth_version\n\nThe valid set of values for auth_version does not include\nvalues starting with the \u0027v\u0027.\n\nIn this particular function, the auth_version variable is\nonly used for comparisons with v3. So, the code worked\ncorrectly. However, let\u0027s clean this up in order to reduce\nreview confusion and defuse possible future landmine in case\nof code changes.\n\nChange-Id: I671016d7992a1922b786b4eb8876b3fbb2532e15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7a13754eebb15a3c7fa507ad1d58e3c4460e302c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7a13754eebb15a3c7fa507ad1d58e3c4460e302c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}