)]}'
{"swiftclient/shell.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e69c817972ecc9ef0d401107cefad83ddebacb2f","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"        print(\u0027export OS_AUTH_TOKEN\u003d%s\u0027 % sh_quote(token))"},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"st_tempurl_options \u003d \u0027\u0027\u0027[--absolute] [--prefix-based] [--iso8601]"},{"line_number":1274,"context_line":"                     \u003cmethod\u003e \u003ctime\u003e \u003cpath\u003e \u003ckey\u003e\u0027\u0027\u0027"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"st_tempurl_help \u003d \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d1b751d7","line":1274,"range":{"start_line":1273,"start_character":24,"end_line":1274,"end_character":49},"updated":"2018-07-11 23:08:47.000000000","message":"Could use a\n\n [--ip-range \u003crange\u003e]","commit_id":"47fb18c41b4851ba6071f0215e96e222b8ccef29"}],"swiftclient/utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e69c817972ecc9ef0d401107cefad83ddebacb2f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    if ip_range:"},{"line_number":165,"context_line":"        if isinstance(ip_range, six.binary_type):"},{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                ip_range \u003d ip_range.decode(\u0027utf-8\u0027)"},{"line_number":168,"context_line":"            except UnicodeDecodeError:"},{"line_number":169,"context_line":"                raise ValueError("},{"line_number":170,"context_line":"                    \u0027ip_range must be representable as UTF-8\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7be41ca9","line":167,"range":{"start_line":167,"start_character":44,"end_line":167,"end_character":49},"updated":"2018-07-11 23:08:47.000000000","message":"Should even be safe to require ASCII, yeah? I can\u0027t think of an IP range that would be representable in UTF-8 but not ASCII, at any rate...","commit_id":"47fb18c41b4851ba6071f0215e96e222b8ccef29"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e69c817972ecc9ef0d401107cefad83ddebacb2f","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                ip_range \u003d ip_range.decode(\u0027utf-8\u0027)"},{"line_number":168,"context_line":"            except UnicodeDecodeError:"},{"line_number":169,"context_line":"                raise ValueError("},{"line_number":170,"context_line":"                    \u0027ip_range must be representable as UTF-8\u0027"},{"line_number":171,"context_line":"                )"},{"line_number":172,"context_line":"        hmac_parts.insert(0, \"ip\u003d%s\" % ip_range)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d64bc783","line":170,"updated":"2018-07-11 23:08:47.000000000","message":"I wonder if it would be worth having more validation than just \"is UTF-8\"... even just something like\n\n base, sep, bits \u003d ip_range.partition(\u0027/\u0027)\n for af in (socket.AF_INET, socket.AF_INET6):\n     try:\n         socket.pton(af, base)\n         break\n     except socket.error:\n         pass\n else:\n     raise ValueError(\u0027Bad ip_range: %r\u0027 % ip_range)\n if sep:\n     try:\n         int(bits)\n     except ValueError:\n         raise ValueError(\u0027Bad ip_range: %r\u0027 % ip_range)\n\nought to help catch simple errors early.","commit_id":"47fb18c41b4851ba6071f0215e96e222b8ccef29"}]}
