)]}'
{"id":"openstack%2Fpython-swiftclient~581374","triplet_id":"openstack%2Fpython-swiftclient~master~I4734599886e4f4a563162390d0ff3bb1ef639db4","project":"openstack/python-swiftclient","branch":"master","topic":"tempurl-ip-ranges","hashtags":[],"change_id":"I4734599886e4f4a563162390d0ff3bb1ef639db4","subject":"Add ability to generate a temporary URL with an IP range restriction","status":"MERGED","created":"2018-07-10 14:13:15.000000000","updated":"2018-07-12 07:55:47.000000000","submitted":"2018-07-12 01:46:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"581374-1531360008487-4337d0c3","meta_rev_id":"5430f2ff8917da148dbf174938e4f41bffaa081a","_number":581374,"virtual_id_number":581374,"owner":{"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2018-07-12 01:46:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-07-11 23:08:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-07-11 23:08:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-11 23:08:47.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2018-07-12 01:46:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3cdf531a3db20dad3871afdf9d063889f1543d0f","author":{"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"},"date":"2018-07-10 14:13:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a35287116ca354815033a084445ea0bc30e594ce","author":{"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"},"date":"2018-07-10 14:15:02.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"db27b0ae4d1f764d8ffa7b8189e3aa742e94cbf5","author":{"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"},"date":"2018-07-10 14:23:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"523336f4cbec92512b14c8d859d6757d4d70ab91","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-10 16:41:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/74/581374/2/check/openstack-tox-pep8/fc69888/ : SUCCESS in 4m 28s\n- openstack-tox-py27 http://logs.openstack.org/74/581374/2/check/openstack-tox-py27/aa01f82/ : SUCCESS in 4m 32s\n- openstack-tox-py35 http://logs.openstack.org/74/581374/2/check/openstack-tox-py35/8b377af/ : SUCCESS in 3m 31s\n- build-openstack-sphinx-docs http://logs.openstack.org/74/581374/2/check/build-openstack-sphinx-docs/6532f1f/html/ : SUCCESS in 5m 09s\n- openstack-tox-pypy http://logs.openstack.org/74/581374/2/check/openstack-tox-pypy/1787581/ : SUCCESS in 4m 41s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/74/581374/2/check/legacy-tempest-dsvm-neutron-src/1ee2d80/ : SUCCESS in 1h 45m 37s\n- legacy-swift-dsvm-functional http://logs.openstack.org/74/581374/2/check/legacy-swift-dsvm-functional/35fc7d7/ : SUCCESS in 23m 55s\n- legacy-swift-dsvm-functional-identity-v3-only http://logs.openstack.org/74/581374/2/check/legacy-swift-dsvm-functional-identity-v3-only/c497f8d/ : SUCCESS in 28m 36s (non-voting)\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/74/581374/2/check/legacy-swiftclient-dsvm-functional/984175c/ : SUCCESS in 17m 07s\n- legacy-swiftclient-dsvm-functional-identity-v3-only http://logs.openstack.org/74/581374/2/check/legacy-swiftclient-dsvm-functional-identity-v3-only/91325e3/ : SUCCESS in 19m 36s (non-voting)\n- openstack-tox-py36 http://logs.openstack.org/74/581374/2/check/openstack-tox-py36/772de50/ : SUCCESS in 3m 52s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/74/581374/2/check/openstack-tox-lower-constraints/be142e4/ : SUCCESS in 4m 52s","accounts_in_message":[],"_revision_number":2},{"id":"e69c817972ecc9ef0d401107cefad83ddebacb2f","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-07-11 23:08:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(3 comments)\n\nPushed up https://review.openstack.org/#/c/581906/ as a follow-up, but this WFM as-is.","accounts_in_message":[],"_revision_number":2},{"id":"2dcd2e0afd979299ca627ddfc1dd45888f10cefe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-11 23:11:09.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1de139e549d16ff2b371c04b9917ad595830ecfd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 01:46:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/74/581374/2/gate/openstack-tox-pep8/f0bd293/ : SUCCESS in 2m 55s\n- openstack-tox-py27 http://logs.openstack.org/74/581374/2/gate/openstack-tox-py27/6940fae/ : SUCCESS in 3m 02s\n- openstack-tox-py35 http://logs.openstack.org/74/581374/2/gate/openstack-tox-py35/493e9b0/ : SUCCESS in 4m 15s\n- build-openstack-sphinx-docs http://logs.openstack.org/74/581374/2/gate/build-openstack-sphinx-docs/798cc8f/html/ : SUCCESS in 2m 36s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/74/581374/2/gate/legacy-tempest-dsvm-neutron-src/302e8a6/ : SUCCESS in 1h 26m 43s\n- legacy-swift-dsvm-functional http://logs.openstack.org/74/581374/2/gate/legacy-swift-dsvm-functional/1ac21c6/ : SUCCESS in 27m 02s\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/74/581374/2/gate/legacy-swiftclient-dsvm-functional/ba40353/ : SUCCESS in 19m 40s\n- openstack-tox-lower-constraints http://logs.openstack.org/74/581374/2/gate/openstack-tox-lower-constraints/90f3296/ : SUCCESS in 5m 00s","accounts_in_message":[],"_revision_number":2},{"id":"78395606178336955b8c33792b29fdd8f88166a3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 01:46:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"1a2b1a4cd861de7882532c16105c108a4fc0dffb","author":{"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"},"date":"2018-07-12 07:55:47.000000000","message":"Patch Set 2:\n\n\u003e (3 comments)\n \u003e \n \u003e Pushed up https://review.openstack.org/#/c/581906/ as a follow-up,\n \u003e but this WFM as-is.\n\nHi Tim,\n\nThanks for the review. I am assuming we don\u0027t have(or want to add) the ipaddress module to the requirements for parsing valid ip ranges?","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"47fb18c41b4851ba6071f0215e96e222b8ccef29","revisions":{"90fe8d461b546ed4829a20b0ada024b07a84a5eb":{"kind":"REWORK","_number":1,"created":"2018-07-10 14:13:15.000000000","uploader":{"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"},"ref":"refs/changes/74/581374/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/74/581374/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/74/581374/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/74/581374/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/74/581374/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/74/581374/1"}}},"commit":{"parents":[{"commit":"c2c5af603f8ae25be052a20b02dc109b0f8f014a","subject":"Merge \"Add option for user to enter password\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c2c5af603f8ae25be052a20b02dc109b0f8f014a"}]}],"author":{"name":"mmcardle","email":"mark.mcardle@sohonet.com","date":"2018-07-10 13:45:32.000000000","tz":60},"committer":{"name":"mmcardle","email":"mark.mcardle@sohonet.com","date":"2018-07-10 14:11:49.000000000","tz":60},"subject":"Add ability to generate a temporary URL with an IP range restriction","message":"Add ability to generate a temporary URL with an IP range restriction\n\nChange-Id: I4734599886e4f4a563162390d0ff3bb1ef639db4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/90fe8d461b546ed4829a20b0ada024b07a84a5eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/90fe8d461b546ed4829a20b0ada024b07a84a5eb"}]},"branch":"refs/heads/master"},"47fb18c41b4851ba6071f0215e96e222b8ccef29":{"kind":"REWORK","_number":2,"created":"2018-07-10 14:23:54.000000000","uploader":{"_account_id":10303,"name":"Mark McArdle","email":"mark.mcardle@sohonet.com","username":"mmcardle"},"ref":"refs/changes/74/581374/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/74/581374/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/74/581374/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/74/581374/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/74/581374/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/74/581374/2"}}},"commit":{"parents":[{"commit":"c2c5af603f8ae25be052a20b02dc109b0f8f014a","subject":"Merge \"Add option for user to enter password\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c2c5af603f8ae25be052a20b02dc109b0f8f014a"}]}],"author":{"name":"mmcardle","email":"mark.mcardle@sohonet.com","date":"2018-07-10 13:45:32.000000000","tz":60},"committer":{"name":"mmcardle","email":"mark.mcardle@sohonet.com","date":"2018-07-10 14:23:30.000000000","tz":60},"subject":"Add ability to generate a temporary URL with an IP range restriction","message":"Add ability to generate a temporary URL with an\nIP range restriction\n\nChange-Id: I4734599886e4f4a563162390d0ff3bb1ef639db4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/47fb18c41b4851ba6071f0215e96e222b8ccef29"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/47fb18c41b4851ba6071f0215e96e222b8ccef29"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
