)]}'
{"id":"openstack%2Fpython-swiftclient~600883","triplet_id":"openstack%2Fpython-swiftclient~master~I2367310aac74f1b7c5ea0cb1a822a491e4ba8e68","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"I2367310aac74f1b7c5ea0cb1a822a491e4ba8e68","subject":"Stop lazy importing keystoneclient","status":"MERGED","created":"2018-09-07 23:58:02.000000000","updated":"2018-10-18 18:58:15.000000000","submitted":"2018-10-18 18:58:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"600883-1539889095685-c438f33c","meta_rev_id":"db7d1a20b10501c26622332b79282a4dc1c06de0","_number":600883,"virtual_id_number":600883,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2018-10-18 18:58:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"recommended":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"all":[{"value":1,"date":"2018-09-26 22:43:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":2,"date":"2018-10-18 01:55:46.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":1,"date":"2018-10-18 02:45:46.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-09-26 22:43:51.000000000","updated_by":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"reviewer":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"state":"REVIEWER"},{"updated":"2018-10-18 02:45:46.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2018-10-18 18:58:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5e267d6f208dc6688faf99918cdbb236156b83d5","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-09-07 23:58:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"53ba2323916417b1e9862ad1ac8f44de5a359f18","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-08 01:50:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/83/600883/1/check/openstack-tox-pep8/2ca5745/ : SUCCESS in 2m 53s\n- openstack-tox-py27 http://logs.openstack.org/83/600883/1/check/openstack-tox-py27/f1eb33b/ : SUCCESS in 3m 42s\n- openstack-tox-py35 http://logs.openstack.org/83/600883/1/check/openstack-tox-py35/c9b02f8/ : SUCCESS in 3m 17s\n- openstack-tox-py36 http://logs.openstack.org/83/600883/1/check/openstack-tox-py36/bf05210/ : SUCCESS in 3m 47s\n- openstack-tox-docs http://logs.openstack.org/83/600883/1/check/openstack-tox-docs/0190c6f/html/ : SUCCESS in 2m 51s\n- openstack-tox-pypy http://logs.openstack.org/83/600883/1/check/openstack-tox-pypy/675c608/ : SUCCESS in 4m 14s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/83/600883/1/check/legacy-tempest-dsvm-neutron-src/a6484b6/ : SUCCESS in 1h 50m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/83/600883/1/check/openstack-tox-lower-constraints/790916e/ : SUCCESS in 4m 38s\n- legacy-swift-dsvm-functional http://logs.openstack.org/83/600883/1/check/legacy-swift-dsvm-functional/a1cac98/ : SUCCESS in 26m 51s\n- legacy-swift-dsvm-functional-identity-v3-only http://logs.openstack.org/83/600883/1/check/legacy-swift-dsvm-functional-identity-v3-only/8f8dca7/ : SUCCESS in 29m 19s (non-voting)\n- legacy-swiftclient-dsvm-functional http://logs.openstack.org/83/600883/1/check/legacy-swiftclient-dsvm-functional/0d02223/ : SUCCESS in 18m 13s\n- legacy-swiftclient-dsvm-functional-identity-v3-only http://logs.openstack.org/83/600883/1/check/legacy-swiftclient-dsvm-functional-identity-v3-only/71eff65/ : SUCCESS in 16m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"02c7e468e80014e6e443fc73d97aa541ec7a3107","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2018-09-26 22:43:51.000000000","message":"Patch Set 1: Code-Review+1\n\nI tested the patch after removing the workaround in the 1space project. It resolved our issue that involved green threads and importing keystone in the threads.","accounts_in_message":[],"_revision_number":1},{"id":"87fd2cf49dbcbe05907cfa51eb902701ffc816f4","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2018-10-18 01:55:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"51d1de63e368256b7dd6dd82f9570df6f086e9a1","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2018-10-18 02:45:46.000000000","message":"Patch Set 1: Workflow+1\n\nActually you know, I think I like this enough to just land it. Changing my vote to +2+A.","accounts_in_message":[],"_revision_number":1},{"id":"398904927dca122b72fe31c7933bd2a737ad072b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-18 14:55:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"03844869f9b92c49d4cf1cbeec522adb25a4a3d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-18 18:58:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/83/600883/1/gate/openstack-tox-pep8/f6964af/ : SUCCESS in 4m 31s\n- openstack-tox-py27 http://logs.openstack.org/83/600883/1/gate/openstack-tox-py27/37f75b9/ : SUCCESS in 4m 07s\n- openstack-tox-py35 http://logs.openstack.org/83/600883/1/gate/openstack-tox-py35/725c0b0/ : SUCCESS in 5m 03s\n- openstack-tox-py36 http://logs.openstack.org/83/600883/1/gate/openstack-tox-py36/97ffb47/ : SUCCESS in 3m 21s\n- openstack-tox-docs http://logs.openstack.org/83/600883/1/gate/openstack-tox-docs/6dc3c51/html/ : SUCCESS in 3m 30s\n- tempest-full http://logs.openstack.org/83/600883/1/gate/tempest-full/538ec16/ : SUCCESS in 1h 51m 25s\n- swiftclient-swift-functional http://logs.openstack.org/83/600883/1/gate/swiftclient-swift-functional/5099976/ : SUCCESS in 28m 53s\n- swiftclient-functional http://logs.openstack.org/83/600883/1/gate/swiftclient-functional/45e75b2/ : SUCCESS in 19m 05s\n- swiftclient-functional-py2 http://logs.openstack.org/83/600883/1/gate/swiftclient-functional-py2/017000e/ : SUCCESS in 18m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/83/600883/1/gate/openstack-tox-lower-constraints/79bf0cb/ : SUCCESS in 5m 22s","accounts_in_message":[],"_revision_number":1},{"id":"db7d1a20b10501c26622332b79282a4dc1c06de0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-18 18:58:15.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d1e1f8d8d6a8890c71eea8a3c2a488af30a8147b","revisions":{"d1e1f8d8d6a8890c71eea8a3c2a488af30a8147b":{"kind":"REWORK","_number":1,"created":"2018-09-07 23:58:02.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/83/600883/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/83/600883/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/83/600883/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/83/600883/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/83/600883/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/83/600883/1"}}},"commit":{"parents":[{"commit":"4330d036cd40299c3fd12d68d319e20757ccadcf","subject":"Merge \"Make py36 unit test job voting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4330d036cd40299c3fd12d68d319e20757ccadcf"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-09-07 23:50:10.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-09-07 23:56:13.000000000","tz":-420},"subject":"Stop lazy importing keystoneclient","message":"Stop lazy importing keystoneclient\n\nThere were two basic problems:\n\n  - We\u0027d try to import on every attempt at getting auth, even when we\n    already know keystoneclient isn\u0027t available.\n  - Sometimes devs would hit some crazy import race involving (some\n    combination of?) greenthreads and OS threads.\n\nSo let\u0027s just try the imports *once*, at import time, and have None\nsentinels if it fails. Try both versions separately to decouple\nfailures; this should let us support a wider range of keystoneclient\nversions.\n\nChange-Id: I2367310aac74f1b7c5ea0cb1a822a491e4ba8e68\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/d1e1f8d8d6a8890c71eea8a3c2a488af30a8147b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/d1e1f8d8d6a8890c71eea8a3c2a488af30a8147b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}