)]}'
{"id":"openstack%2Fpython-swiftclient~617391","triplet_id":"openstack%2Fpython-swiftclient~master~I0679d5663a3ae72271ef728b9bdcff540ee2053a","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"I0679d5663a3ae72271ef728b9bdcff540ee2053a","subject":"Include success flag when downloading to stdout","status":"ABANDONED","created":"2018-11-12 23:06:58.000000000","updated":"2026-04-17 21:19:12.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e3cc911914a9f82ae8e1abc7093e1f5976b25bc5","_number":617391,"virtual_id_number":617391,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":1,"date":"2018-12-05 22:23:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-02-11 18:53:15.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":-1,"date":"2019-02-19 01:58:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-12-05 22:23:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-02-19 01:58:46.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"}],"messages":[{"id":"d920bea9b86a83ec8ca3ebdbcdbabbf00ef02ee0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-11-12 23:06:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"39e37cc38803dfa214e2ee7a44a62c6f30c1b5bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-13 00:34:15.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/91/617391/1/check/openstack-tox-pep8/3fe40ee/ : SUCCESS in 2m 46s\n- openstack-tox-py27 http://logs.openstack.org/91/617391/1/check/openstack-tox-py27/7dc04da/ : SUCCESS in 2m 46s\n- openstack-tox-py35 http://logs.openstack.org/91/617391/1/check/openstack-tox-py35/caca3d6/ : SUCCESS in 3m 11s\n- openstack-tox-py36 http://logs.openstack.org/91/617391/1/check/openstack-tox-py36/f46ede2/ : SUCCESS in 3m 06s\n- openstack-tox-docs http://logs.openstack.org/91/617391/1/check/openstack-tox-docs/341819b/html/ : SUCCESS in 3m 04s\n- openstack-tox-pypy http://logs.openstack.org/91/617391/1/check/openstack-tox-pypy/538db53/ : SUCCESS in 3m 36s (non-voting)\n- tempest-full http://logs.openstack.org/91/617391/1/check/tempest-full/36451d9/ : SUCCESS in 1h 24m 45s\n- swiftclient-swift-functional http://logs.openstack.org/91/617391/1/check/swiftclient-swift-functional/c0db6c6/ : SUCCESS in 28m 30s\n- swiftclient-functional http://logs.openstack.org/91/617391/1/check/swiftclient-functional/50e7b17/ : SUCCESS in 12m 41s\n- swiftclient-functional-py2 http://logs.openstack.org/91/617391/1/check/swiftclient-functional-py2/3843d40/ : SUCCESS in 13m 40s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/617391/1/check/openstack-tox-lower-constraints/9c868f5/ : FAILURE in 2m 50s","accounts_in_message":[],"_revision_number":1},{"id":"51e5c0e0823454bd7906afc03b91bd30f540312d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-12-05 19:46:39.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e5acf49af31609cc7296cb906ccebf8ca5e8e28b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-05 22:23:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/91/617391/1/check/openstack-tox-pep8/0166f52/ : SUCCESS in 4m 14s\n- openstack-tox-py27 http://logs.openstack.org/91/617391/1/check/openstack-tox-py27/65a98ca/ : SUCCESS in 4m 07s\n- openstack-tox-py35 http://logs.openstack.org/91/617391/1/check/openstack-tox-py35/c215d52/ : SUCCESS in 4m 19s\n- openstack-tox-py36 http://logs.openstack.org/91/617391/1/check/openstack-tox-py36/23dd171/ : SUCCESS in 4m 23s\n- openstack-tox-docs http://logs.openstack.org/91/617391/1/check/openstack-tox-docs/396912f/html/ : SUCCESS in 4m 33s\n- openstack-tox-pypy http://logs.openstack.org/91/617391/1/check/openstack-tox-pypy/b4c517d/ : SUCCESS in 5m 57s (non-voting)\n- tempest-full http://logs.openstack.org/91/617391/1/check/tempest-full/e8a9662/ : SUCCESS in 1h 29m 03s\n- swiftclient-swift-functional http://logs.openstack.org/91/617391/1/check/swiftclient-swift-functional/1fb3167/ : SUCCESS in 30m 28s\n- swiftclient-functional http://logs.openstack.org/91/617391/1/check/swiftclient-functional/875c215/ : SUCCESS in 20m 09s\n- swiftclient-functional-py2 http://logs.openstack.org/91/617391/1/check/swiftclient-functional-py2/63a857d/ : SUCCESS in 16m 06s\n- openstack-tox-lower-constraints http://logs.openstack.org/91/617391/1/check/openstack-tox-lower-constraints/45e13ef/ : SUCCESS in 6m 37s","accounts_in_message":[],"_revision_number":1},{"id":"ff8972e7c9266ccb7505f23a32a3388e5f9ca543","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-02-11 08:02:13.000000000","message":"Patch Set 1:\n\nIt\u0027s not like I disagree, but... why?","accounts_in_message":[],"_revision_number":1},{"id":"c04815470b6860abe006cd19a867de4b03f8d071","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-02-11 18:53:15.000000000","message":"Patch Set 1:\n\nI had a test script along the lines of http://paste.openstack.org/show/744880/ -- everywhere else, I could look at result[\u0027success\u0027], but on download to stdout (normal files are fine!) I had to do result.get(\u0027success\u0027, True). That\u0027s just weird, and rather ugly.\n\nThat same test script prompted me to write https://review.openstack.org/#/c/617386/ (see line 9 of the paste), but it needs more cleanup.","accounts_in_message":[],"_revision_number":1},{"id":"1144608afaf485e1ee948537701c5ec44dc32f4d","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-02-19 01:58:46.000000000","message":"Patch Set 1: Code-Review-1\n\n\u003e I had a test script along the lines of http://paste.openstack.org/show/744880/\n \u003e -- everywhere else, I could look at result[\u0027success\u0027], but on\n \u003e download to stdout (normal files are fine!) I had to do\n \u003e result.get(\u0027success\u0027, True). That\u0027s just weird, and rather ugly.\n\nI see. This complaint sounded absurd to me at first, because \u0027success\u0027 key is only set when it\u0027s known if the operation was successful, obviously. Since the download is not finished, yet, we don\u0027t know if it\u0027s actually a success or not. But I guess what you\u0027re trying to do here is to re-define \u0027success\u0027 as the result of the .download() method.\n\nOf course you were supposed to do the same result.get(\u0027contents\u0027) first. But the code is the same in that you still have a get(), just a \"more correct\" one. You can see how shell.py does it (well, it uses \u0027in\u0027).\n\nWhat is going to happen if someone already has a script in your paste and now you\u0027re adding that \u0027success\u0027 that wasn\u0027t there previously? If his script was checking \u0027contents\u0027 first, he\u0027s fine. But you did not, so I\u0027m not sure how solid our case is.","accounts_in_message":[],"_revision_number":1},{"id":"e3cc911914a9f82ae8e1abc7093e1f5976b25bc5","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2026-04-17 21:19:12.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b0e2713a7ba42ea6060581e1db42cacc49675143","revisions":{"b0e2713a7ba42ea6060581e1db42cacc49675143":{"kind":"REWORK","_number":1,"created":"2018-11-12 23:06:58.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/91/617391/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/91/617391/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/91/617391/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/91/617391/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/91/617391/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/91/617391/1"}}},"commit":{"parents":[{"commit":"8778c91c71e83a40cfeedc4875ae3b66c7effb85","subject":"Merge \"Stop leaking quite so many connections\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/8778c91c71e83a40cfeedc4875ae3b66c7effb85"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-11-12 22:21:17.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-11-12 23:04:01.000000000","tz":-480},"subject":"Include success flag when downloading to stdout","message":"Include success flag when downloading to stdout\n\nChange-Id: I0679d5663a3ae72271ef728b9bdcff540ee2053a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b0e2713a7ba42ea6060581e1db42cacc49675143"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b0e2713a7ba42ea6060581e1db42cacc49675143"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}