)]}'
{"id":"openstack%2Fpython-swiftclient~721051","triplet_id":"openstack%2Fpython-swiftclient~master~Id62e63afc6f2ffa32eb8640787c78559481050f9","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1873435","hashtags":[],"change_id":"Id62e63afc6f2ffa32eb8640787c78559481050f9","subject":"Close connections created when calling module-level functions","status":"MERGED","created":"2020-04-19 05:46:53.000000000","updated":"2020-10-15 22:42:39.000000000","submitted":"2020-10-15 22:41:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"721051-1602801670600-76a6aaaf","meta_rev_id":"c8e2e094d05fc52b2bb0db73ee14b5a4fa4694c5","_number":721051,"virtual_id_number":721051,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-15 22:41:10.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-10-14 00:42:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-10-14 00:42:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-13 17:20:12.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2020-10-15 22:41:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"083a96c739ff4562f4c4fe6ba0ca5a3bebd7a9e5","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-04-19 05:46:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b30840ece84ab589d1478f89fe622dd7484f4329","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-19 07:17:13.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a606fda8a9da45a4983ea5a536bf5969 : SUCCESS in 1h 28m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5123ebc286db4555a020660aae01e492 : SUCCESS in 3m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/73282394b73d42d0b53bb93cd9b1e203 : FAILURE in 3m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8d13b25d3a5645aba22fcf793ef764d2 : SUCCESS in 3m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/439cb70cc33e4a168bdad288fbd6b856 : SUCCESS in 3m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/baf6e772342645d3b0688597df7939b6 : SUCCESS in 3m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/715d6761da744b81a17b9897d99393ed : SUCCESS in 4m 56s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/90ab615a72164a10af55ca945cdb739f : SUCCESS in 28m 19s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/ed562928251045158618893467fdb991 : SUCCESS in 15m 37s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/2af509be2ace41fbbb030b8be37d011d : SUCCESS in 15m 42s","accounts_in_message":[],"_revision_number":1},{"id":"4570c93383b1dc4481d697143093fd12a23b457d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-04-20 02:08:04.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"a11f3b19459a30290af45cca3c58b486fc552949","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-20 03:28:19.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a71566cf2f5742518416f15fbb5df9fc : SUCCESS in 1h 19m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/beb28b1a3b3e42cf99640b1e8d462b34 : SUCCESS in 3m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b1cce308555643d884040b2bf6d7ea4d : SUCCESS in 3m 35s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7e5aebdd7e4b492483a5dc9277642d85 : FAILURE in 3m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b26107c777fe4b1c82e88380e9bcc1b4 : SUCCESS in 4m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/80fbf273c77a4f969bf5a8f7b158b091 : SUCCESS in 4m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/98378965e68841bca2baaa29b5de5e9e : SUCCESS in 5m 02s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/3e6b3f25547a47e1b39bff74e394eaa5 : SUCCESS in 30m 19s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/152a0080b009409d94740707ae8b06d5 : SUCCESS in 19m 35s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/9b30b9adf7aa4ff6901312fe1518b641 : SUCCESS in 18m 36s","accounts_in_message":[],"_revision_number":2},{"id":"72ad12dc99d4a0e49d0d77421ad2f9c0a56b8924","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-04-20 14:59:33.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"406f32b4d3a4d9ac06101c566dfa26eaea104836","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-20 23:43:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7a7d4428734e49e0a77cf8c193c0f093 : SUCCESS in 1h 28m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9d69859bc3ee4c07a7ef50875e476901 : SUCCESS in 6m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3bde2b239b1147ce89b7bb5c7a2c6205 : SUCCESS in 5m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8ee256c1ec304900bb78b7998608f1e8 : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/46ebf9de86bf4bef873e52a6913d6b9a : SUCCESS in 5m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a656e24968ec4d89a6a2d7dd225c739c : SUCCESS in 4m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/12c44fb5cb8c4fd59af124f6fb2541a3 : SUCCESS in 7m 59s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/56710380bb3042029a26eae605882dfd : SUCCESS in 32m 37s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/9f728584bd2e45ccb6b22e0d0b199559 : SUCCESS in 21m 09s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/c4a66c1d809741cf98cc1b1e68ffc7b8 : SUCCESS in 20m 51s","accounts_in_message":[],"_revision_number":2},{"id":"d452a5c182d50d6320ddca6f8737c71a87dcb968","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-06-17 20:43:04.000000000","message":"Patch Set 2: Code-Review-1\n\nthis is really two changes\n\n1) make __del__ only happen on py3 (which is what seems to have the desired effect in py3 but introduced the regression in py2)\n2) make close explicit\n\nIt\u0027s not obvious to me that we couldn\u0027t just make *one* of these changes.  I don\u0027t find the __del__ particularly desirable, and the commit makes it sound like the explicit close isn\u0027t entirely sufficient\n\nIf we *could* add a request.session.close to a wrapped iterator close that\u0027s returned by get_object maybe we could drop the __del__ on both py2 AND py3!\n\nIf we ultimately need both for belts and braces, I\u0027d guess I\u0027d suggest we split up the changes; but for now maybe it\u0027d make the most sense to just revert the regression for py2 and re-evaluate what\u0027s next.","accounts_in_message":[],"_revision_number":2},{"id":"7429927f3af49684ee79e194306675a5006536e4","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-06-17 23:14:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1e6c9f2b8429c2284bb52bfbc29cf9e16815413c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-18 01:44:19.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1a208015409040ddb873e2c68c62c918 : SUCCESS in 1h 19m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c8b72cf21fd0421ca2711323149e1008 : SUCCESS in 4m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c6b567fb88be435d94e9075320af3890 : SUCCESS in 5m 14s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4166427a64e94749a4720e8741377b2e : FAILURE in 4m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fba441987a4d4fad9d901f74f78b2280 : SUCCESS in 7m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/209282dae1f24114ae93c26aa16c936b : SUCCESS in 7m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b013f03fbc3049f09ebfa7be220f3a2c : SUCCESS in 5m 38s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/f24b592399c94b3899ae7b0d6c799648 : SUCCESS in 47m 36s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/1aa566c6cb684c76a96c7f248b4801ea : SUCCESS in 24m 44s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/7c2686828e2b4aa5805b69e15b619b9d : SUCCESS in 24m 42s","accounts_in_message":[],"_revision_number":3},{"id":"acba044d3059ad369029881ecb16d8d939f7dec4","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-06-18 03:00:05.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"2273d98778963600d7d1ad7d6335dec0a473755e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-18 05:08:27.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/389c9889598f4a22abae5c5b5c07f0b2 : TIMED_OUT in 2h 07m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0ece187b063b45ea8e20c03a932618fc : SUCCESS in 5m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3c9c38961ec34356aa526348fd7a0869 : SUCCESS in 3m 23s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/782afe9d7b284b98aafa7f4f6e4343ba : FAILURE in 5m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/57b57fa4775f43af8b95712e13051894 : SUCCESS in 4m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/61c5d69ea4184b6c86850795ff83fe94 : SUCCESS in 6m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/46227e6b60734b5e996f7d0b40c55bd6 : SUCCESS in 6m 59s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/f247b7196d1944448ca798b9f7f00f45 : SUCCESS in 47m 31s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/35c27f78c8b242bbb75caa70abfa4a3a : SUCCESS in 21m 53s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/34493f72777347798036370af266c4b9 : SUCCESS in 18m 11s","accounts_in_message":[],"_revision_number":3},{"id":"036a3db9cb4235423172641a3c5c2c0f889b184a","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-06-18 14:58:46.000000000","message":"Patch Set 3: Code-Review-1\n\nduring the review of https://review.opendev.org/#/c/674320/ suggested that closing the connection/session every request would have a performance hit:\n\nYou don\u0027t want to close the connection every request because you\u0027ll take a perf hit for more complex usage\n\nAnd that makes sense to me, maybe modern OSes can optimize it some with idle sockets or something... is this necessary?","accounts_in_message":[],"_revision_number":3},{"id":"524734170d17c8a1f60b30e42cc29634ecd9cd60","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-03 00:37:21.000000000","message":"Patch Set 3:\n\n\u003e You don\u0027t want to close the connection every request because you\u0027ll take a perf hit for more complex usage\n\nI\u0027m not buying it, at least with the way we currently handle requests Sessions. Every new HTTPConnection makes a new requests.Session, and has for years: https://github.com/openstack/python-swiftclient/blame/3.10.0/swiftclient/client.py#L409 -- so I don\u0027t expect they\u0027d share any pools between them.\n\nIf you\u0027re really concerned about performance and *correctly* using connection pools, you use one of our Connection classes, not the module-level functions.","accounts_in_message":[],"_revision_number":3},{"id":"8dbf6299873809e75c48b642332570547d79e211","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-08 18:39:19.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"ba1f522f567d17bd6184aafc9fadc267e9218405","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-08 21:32:32.000000000","message":"Patch Set 4: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/748420de6c7c47fea6fd1e258245ff2b : SUCCESS in 54m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/aa6d0f9e8092429a9fc113bbf0cc5b4f : SUCCESS in 7m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/479646fb54a44c9ca0c3af9c2197ae5c : FAILURE in 7m 25s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2d49b19d74ad491294c36d4325c3d023 : SUCCESS in 6m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3f8bf5b84f1c4af190611f4daa74db58 : SUCCESS in 4m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/db979bf3b3424c0b89b777a76e48e1ab : SUCCESS in 5m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d4907f08fd2a4588808c22abaec92605 : SUCCESS in 7m 00s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/aefea411ffbb4836931d8e07a9702573 : SUCCESS in 44m 21s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/5126443ed4d048d9bc6fc021e6b54800 : SUCCESS in 22m 12s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/68a1337b48924027a896f922ee30cbdd : SUCCESS in 23m 08s","accounts_in_message":[],"_revision_number":4},{"id":"c8bdfa846fdf14fbb97b5ca8d80da95faa235699","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-08 22:05:13.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"5cdc61c7e2397a679f28cf5c91cf87860dc51dc7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-08 23:55:16.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5971e32c8cf6439382f645e670899ba3 : SUCCESS in 1h 16m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ec8a3d13de28448bbaa35fa8baaa984a : SUCCESS in 4m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b600c8cad6eb42a2a86c4d08f8778ab8 : SUCCESS in 4m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d9fc9a40ca794e3194b601e219011344 : SUCCESS in 4m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5fd2da852a84a518f1a1f83abf7d793 : SUCCESS in 4m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fc10f5077b08414b9f171de5bfb08e6d : SUCCESS in 4m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/68657586704e4d5d920a71f00c25c9b1 : SUCCESS in 6m 03s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/5e915f4f6db44b44baf65c5463f98fb4 : SUCCESS in 42m 01s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/7e7a10113bf4402aad46392c8318763a : SUCCESS in 24m 54s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/2a0bdf3bfc7c4a37b1837744f8415b29 : SUCCESS in 21m 43s","accounts_in_message":[],"_revision_number":5},{"id":"69faee710cd18b310ff375e4618de13aa64f3e77","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-09-11 19:47:36.000000000","message":"Patch Set 5: Code-Review+1\n\n(3 comments)\n\nI\u0027m lukewarm here.  I like that doing the manual close when using the module level functions directly w/o any connection management is explicit and clean - but forcing an explicit close of every session/connection feels a little OCD - I think \"just let the gc and os handle it\" strategy has been working ok until someone goes poking at warnings with -W \n\nI could be convinced there\u0027s a small performance hit, but I couldn\u0027t really measure it (it\u0027s not like we get to skip the open just because we didn\u0027t close the one we lost track of).  Moreover, I expect typical use of this module *should* be to use the Client class - not the module level functions - so maybe if you\u0027re doing it quick and dirty we care enough to keep it tidy, but not enough to try and re-use a global connection and get in trouble with thread-safety.\n\nMy *real* problem with this change is probably just having to see it update every methods `if http_conn` boilerplate and then extending the mess to the bottom of every method - it\u0027s just begging for a context manager!\n\nBut that mess is mostly pre-existing; so I guess my only reservation left is that this change would be A LOT better with some updates to the test fake_http_connection infra that let us make assertions about the closed/open status of the returned or passed in conn:\n\n    https://review.opendev.org/751418","accounts_in_message":[],"_revision_number":5},{"id":"f84d1291f18b4336f5eed0c93437d629d9c7481a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-11 22:07:32.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nSpeaking of ugly boilerplate... I would *love* to do a major overhaul to swiftclient -- reduce the duplication by routing everything through some central make_request function (not unlike what requests does), make sure all functions can take some common set of args (query_string *still* isn\u0027t plumbed everywhere), get rid of the stupid httplib-\u003erequests shim, use keystoneauth1, ...","accounts_in_message":[],"_revision_number":5},{"id":"b3493d8126991c93c33a4506818b1d88f953bd7b","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-11 22:09:34.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"4781b7250644265821210f6ffa6cd11e111521d9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-21 18:31:06.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"0c69750083a0acea66a97cfaf79e8f71a6d3b9bd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-22 00:29:02.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/05f75fdf59b14fb8afaba13ecfdc7a62 : SUCCESS in 1h 14m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a3e56a162ba94b9598692c41e5c7ce89 : SUCCESS in 4m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/063c312081e94030bd36bd69b27c1128 : SUCCESS in 4m 45s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/796bdb76693f4669b85a05318d79baaa : FAILURE in 3m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/29f9427522e14e9a8990ca2c15cec3f0 : SUCCESS in 4m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c01aa9d72d20449b831752b80cc9c44d : SUCCESS in 5m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7b55907a48204598b7221258454d94fc : SUCCESS in 12m 12s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/cfda2d7330f6473fa3225e02f7f2779b : SUCCESS in 43m 37s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/c8c36258f0e646f286d643030cc6d455 : SUCCESS in 19m 48s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/430f586046eb448085e4341b4e0d13cb : SUCCESS in 21m 36s","accounts_in_message":[],"_revision_number":6},{"id":"ea6b48ac624777d2e52ac14f5c1739ea43286e04","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-22 16:29:31.000000000","message":"Patch Set 6:\n\nrecheck","accounts_in_message":[],"_revision_number":6},{"id":"c54167bb2180604ca2eb99e2280323c56119b9be","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-22 23:31:59.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/142dddcdd62b4d448ce2a063ac25fccd : SUCCESS in 1h 12m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/70ab679c994048f6819a6c2170cbb195 : SUCCESS in 4m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4e6704acb1ec4b5a89e5677fe47b9dd0 : SUCCESS in 5m 06s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a2af797a3af54099a7d32f2c67c7e18b : SUCCESS in 4m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cf797681178c4d89890adef40cb847a5 : SUCCESS in 3m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cd95cc91fe464460a40c702bbcf266ed : SUCCESS in 6m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/597130f3da464b9e8c9da73121aa4131 : SUCCESS in 11m 41s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/1b8bacdab87a45e498e5ce4400796fb3 : SUCCESS in 38m 13s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/a2c75c359e7b4649b173655462a1b08e : SUCCESS in 18m 37s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/d2dd2c4d2bdc4f14b823acb467b3980c : SUCCESS in 22m 47s","accounts_in_message":[],"_revision_number":6},{"id":"218299bc8b6d63e8f60599dd2c313a7febd90629","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-10-13 17:20:12.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)\n\nThis is ok, if it make someone less unhappy - let\u0027s just merge it","accounts_in_message":[],"_revision_number":6},{"id":"805f6a196d52808fcd50bc2de24f0abaffe8ca1c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-10-13 17:45:41.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"d190bbe9f054f7265600d91adc8531cb1804dba4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-13 22:02:41.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7f3b8e8bb5c34b13b2360861310ded81 : SUCCESS in 1h 30m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/931ec5e47dd441d4b736cd1d24101671 : SUCCESS in 4m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ff56a88c8b4f4329b6d3180c99e626f9 : SUCCESS in 4m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/cc7382161be142b7b817c622a87f83bd : SUCCESS in 4m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7c16b344c18b4568a253d6000525fd5d : SUCCESS in 4m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/22d47f0ce6a84bc7a39379797cf75d6d : SUCCESS in 3m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5c2a89a4cb5542d683b2ba1c8904d2d2 : SUCCESS in 6m 34s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/74ca0eb192bb403f8319ad842e51e032 : SUCCESS in 41m 11s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/931513f5989e4430a4537a5dc9a7f698 : SUCCESS in 20m 03s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/900f757128ea4a879fac34595db18ba4 : SUCCESS in 17m 56s","accounts_in_message":[],"_revision_number":7},{"id":"621dd849c1b40ef1b79947c27251c0f5bdbb2d9c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-10-14 00:42:45.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":7},{"id":"c2874fce15b9ff6101aebb1c21370e250806010b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-14 01:28:25.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"b53d3259c26d428ff6fe24cb78e52cc3484134a6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-14 06:25:12.000000000","message":"Patch Set 7: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f9ebac3d483f4220a5ea1d331a6f8569 : FAILURE in 1h 01m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/df8d7d8ea3be4a98b92db7675d3ed7fe : SUCCESS in 4m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/768bac7135cf427a810a6f540483cf1e : SUCCESS in 3m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/071e0bf544674526bb7c42b79e298b0a : SUCCESS in 4m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/219ae6b2387a48bebf6beba6daafd247 : SUCCESS in 4m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/36faf10665b442bba90503051f615318 : SUCCESS in 4m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7692e68cd0ad4022963f01aec34c4db7 : SUCCESS in 5m 44s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/43f434f277304c41b5790ee22fa39c65 : SUCCESS in 46m 00s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/5aca31eb741246f4b17153b069e7e80f : SUCCESS in 23m 17s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/115c8cf352f94b79912a9b0bd72ed26a : SUCCESS in 19m 47s","accounts_in_message":[],"_revision_number":7},{"id":"fef6fd9c3c381a34390c6828ca44b711046776f4","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-10-15 17:04:37.000000000","message":"Patch Set 7:\n\nrecheck","accounts_in_message":[],"_revision_number":7},{"id":"de018c62bc89a7347093ce0a29d1257dececeec2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-15 21:20:26.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2ea359c8b34349909a2ee69de936acb2 : SUCCESS in 1h 16m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dadcb3aa90b446d0abd0138ae875aa72 : SUCCESS in 6m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/01829de4fab640398e00d5692c4b38f8 : SUCCESS in 5m 23s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/62522501a2e24870b6ebe9177237a945 : SUCCESS in 6m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7a8ec108e3b9449c87cf932f07e2f42a : SUCCESS in 5m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1de9d9616d88488a868c9a4935f6a97a : SUCCESS in 5m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c97c48cdf47f4f4393bcb658d7f815ef : SUCCESS in 8m 36s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/e9f1d55b69c24d8b98c2c682e2a4b29b : SUCCESS in 49m 40s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/4362eb50408e416c858a0cc751f636c6 : SUCCESS in 20m 36s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/27b172b8155c4b54b0ec0e59d9109bca : SUCCESS in 25m 20s","accounts_in_message":[],"_revision_number":7},{"id":"69f7410f3ed853d352d9a5f18ddae2d05d8e5545","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-15 21:20:51.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"b9b66affbd5699aeda98af4f19d6eb5c6833e49c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-15 22:41:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7},{"id":"93916942aac46c02fd9bf9cb24e1a9fd23c9707d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-15 22:41:10.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/cc1fa0a07f844a4eb85506733fa1fd3b : SUCCESS in 1h 16m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b55220c576564c7ba5d588ed837321d0 : SUCCESS in 6m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/86944bb4f0d8465eb2d111ebb71a71de : SUCCESS in 6m 22s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/cb1467d47f354763b0c43da06e571f8a : SUCCESS in 7m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/35122f96e08c400db31477e10c936429 : SUCCESS in 6m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/208afa0a530f480eb02dae52a289f3aa : SUCCESS in 7m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f6981156c5e349af855178d1d18aa885 : SUCCESS in 8m 37s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/47eb5d8649474b8b8cbdb927236b11af : SUCCESS in 43m 54s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/f7c2cac0d94043c59cf790b72999f4ce : SUCCESS in 26m 19s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/a20fd8e11aff42bbaff927b8d7ae38ef : SUCCESS in 21m 52s","accounts_in_message":[],"_revision_number":7},{"id":"00c4ef76dfe7d0ac56476b6c5c5b39cd181acdb9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-15 22:42:39.000000000","message":"Patch Set 7:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e766cdad3dc34d2bad4705343831a286 : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"97aa3e65412ee241fce7721927b0b003daf51ed4","revisions":{"cb17f95e797f0151f8a20195b156be5baa0d692d":{"kind":"REWORK","_number":1,"created":"2020-04-19 05:46:53.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/51/721051/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/721051/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/1"}}},"commit":{"parents":[{"commit":"a0608f223a70169655d073b296374e6c8cf180fa","subject":"Merge \"Update master for stable/ussuri\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a0608f223a70169655d073b296374e6c8cf180fa"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-04-19 05:41:55.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-04-19 05:46:32.000000000","tz":-420},"subject":"Only add __del__ to HTTPConnection shim on py3","message":"Only add __del__ to HTTPConnection shim on py3\n\nApparently, on py2, this causes the connection to *not* get cleaned up\nduring normal GC (??).\n\nAdditionally, when safe, close the connection inline with whatever\nfunction call created it. The lone hold-out is get_object, which may\nneed the connection to be open until the iterators is drained or closed.\n\nChange-Id: Id62e63afc6f2ffa32eb8640787c78559481050f9\nRelated-Change: I200ad0cdc8b7999c3f5521b9a822122bd18714bf\nCloses-Bug: #1873435\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/cb17f95e797f0151f8a20195b156be5baa0d692d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/cb17f95e797f0151f8a20195b156be5baa0d692d"}]},"branch":"refs/heads/master"},"2832354a419610a3e31d6e44fba313949eafbe7d":{"kind":"REWORK","_number":2,"created":"2020-04-20 02:08:04.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/51/721051/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/721051/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/2"}}},"commit":{"parents":[{"commit":"a0608f223a70169655d073b296374e6c8cf180fa","subject":"Merge \"Update master for stable/ussuri\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/a0608f223a70169655d073b296374e6c8cf180fa"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-04-19 05:41:55.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tburke@nvidia.com","date":"2020-04-20 02:07:38.000000000","tz":0},"subject":"Only add __del__ to HTTPConnection shim on py3","message":"Only add __del__ to HTTPConnection shim on py3\n\nApparently, on py2, this causes the connection to *not* get cleaned up\nduring normal GC (??).\n\nAdditionally, when safe, close the connection inline with whatever\nfunction call created it. The lone hold-out is get_object, which may\nneed the connection to be open until the iterators is drained or closed.\n\nChange-Id: Id62e63afc6f2ffa32eb8640787c78559481050f9\nRelated-Change: I200ad0cdc8b7999c3f5521b9a822122bd18714bf\nCloses-Bug: #1873435\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2832354a419610a3e31d6e44fba313949eafbe7d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/2832354a419610a3e31d6e44fba313949eafbe7d"}]},"branch":"refs/heads/master"},"df61f35356555b3002a55e49bbaa4e4f34b1c2ae":{"kind":"REWORK","_number":3,"created":"2020-06-17 23:14:52.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/51/721051/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/721051/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/3"}}},"commit":{"parents":[{"commit":"c47d72a4fe1445110ba19a7656e9a37b676e2599","subject":"Revert \"Cleanup session on delete\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c47d72a4fe1445110ba19a7656e9a37b676e2599"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-04-19 05:41:55.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-06-17 22:55:39.000000000","tz":-420},"subject":"Close connections created when calling module-level functions","message":"Close connections created when calling module-level functions\n\nChange-Id: Id62e63afc6f2ffa32eb8640787c78559481050f9\nRelated-Change: I200ad0cdc8b7999c3f5521b9a822122bd18714bf\nRelated-Bug: #1873435\nCloses-Bug: #1838775\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/df61f35356555b3002a55e49bbaa4e4f34b1c2ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/df61f35356555b3002a55e49bbaa4e4f34b1c2ae"}]},"branch":"refs/heads/master"},"65c3e31634a584beb69a83143ab9dfb537f97f02":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2020-09-08 18:39:19.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/51/721051/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/721051/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/4"}}},"commit":{"parents":[{"commit":"6f1a66fc45df20da92894487d074170e37382853","subject":"(Mostly) revert \"Cleanup session on delete\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6f1a66fc45df20da92894487d074170e37382853"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-04-19 05:41:55.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-08 18:36:30.000000000","tz":-420},"subject":"Close connections created when calling module-level functions","message":"Close connections created when calling module-level functions\n\nChange-Id: Id62e63afc6f2ffa32eb8640787c78559481050f9\nRelated-Change: I200ad0cdc8b7999c3f5521b9a822122bd18714bf\nRelated-Bug: #1873435\nCloses-Bug: #1838775\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/65c3e31634a584beb69a83143ab9dfb537f97f02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/65c3e31634a584beb69a83143ab9dfb537f97f02"}]},"branch":"refs/heads/master"},"338d66e493c9677542e851fdb62c461f187d037f":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2020-09-08 22:05:13.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/51/721051/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/721051/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/5"}}},"commit":{"parents":[{"commit":"0c70d164ba52d76a6dbbbe8765d15fb969fc07ff","subject":"(Mostly) revert \"Cleanup session on delete\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0c70d164ba52d76a6dbbbe8765d15fb969fc07ff"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-04-19 05:41:55.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-08 22:04:54.000000000","tz":-420},"subject":"Close connections created when calling module-level functions","message":"Close connections created when calling module-level functions\n\nChange-Id: Id62e63afc6f2ffa32eb8640787c78559481050f9\nRelated-Change: I200ad0cdc8b7999c3f5521b9a822122bd18714bf\nRelated-Bug: #1873435\nCloses-Bug: #1838775\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/338d66e493c9677542e851fdb62c461f187d037f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/338d66e493c9677542e851fdb62c461f187d037f"}]},"branch":"refs/heads/master"},"82672b9deeff5547e960e673afce2f73cf902090":{"kind":"REWORK","_number":6,"created":"2020-09-21 18:31:06.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/51/721051/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/721051/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/6"}}},"commit":{"parents":[{"commit":"b13712949fd58ba1332cb0507dd39853c0ee0efe","subject":"Merge \"(Mostly) revert \"Cleanup session on delete\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b13712949fd58ba1332cb0507dd39853c0ee0efe"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-04-19 05:41:55.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-21 18:30:01.000000000","tz":-420},"subject":"Close connections created when calling module-level functions","message":"Close connections created when calling module-level functions\n\nCo-Authored-By: Clay Gerrard \u003cclay.gerrard@gmail.com\u003e\nChange-Id: Id62e63afc6f2ffa32eb8640787c78559481050f9\nRelated-Change: I200ad0cdc8b7999c3f5521b9a822122bd18714bf\nRelated-Bug: #1873435\nCloses-Bug: #1838775\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/82672b9deeff5547e960e673afce2f73cf902090"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/82672b9deeff5547e960e673afce2f73cf902090"}]},"branch":"refs/heads/master"},"97aa3e65412ee241fce7721927b0b003daf51ed4":{"kind":"REWORK","_number":7,"created":"2020-10-13 17:45:41.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/51/721051/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/51/721051/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/51/721051/7"}}},"commit":{"parents":[{"commit":"b13712949fd58ba1332cb0507dd39853c0ee0efe","subject":"Merge \"(Mostly) revert \"Cleanup session on delete\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b13712949fd58ba1332cb0507dd39853c0ee0efe"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-04-19 05:41:55.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-10-13 17:45:07.000000000","tz":-420},"subject":"Close connections created when calling module-level functions","message":"Close connections created when calling module-level functions\n\nCo-Authored-By: Clay Gerrard \u003cclay.gerrard@gmail.com\u003e\nChange-Id: Id62e63afc6f2ffa32eb8640787c78559481050f9\nRelated-Change: I200ad0cdc8b7999c3f5521b9a822122bd18714bf\nRelated-Bug: #1873435\nCloses-Bug: #1838775\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/97aa3e65412ee241fce7721927b0b003daf51ed4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/97aa3e65412ee241fce7721927b0b003daf51ed4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}