)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f9f5d5fbf1c52448602d2cfacb107a77c520e1c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Burke \u003ctim.burke@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-15 10:25:15 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Application credential support follow-up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id7ea9c3ea8278ae86a04d057a472a8f8a87b8eae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_957a1eb7","line":7,"updated":"2020-05-19 14:50:09.000000000","message":"what is this patch supposed to do?  how should one review it?","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"eb6fd8893f6c2af58e88774487ed95a0037076d9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   +------------+----------------------------+"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"   $ swift stat"},{"line_number":33,"context_line":"   Only \"v3applicationcredential\" is supported for --os-auth-type"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"We don\u0027t really want to allow (and mostly ignore) arbitrary OS_AUTH_TYPE"},{"line_number":36,"context_line":"values, though -- there are a whole bunch of plugins we don\u0027t remotely"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_fac66149","line":33,"updated":"2020-06-17 20:30:42.000000000","message":"that seems annoying - if I used both clients I\u0027m sure a fix would be quite desirable\n\nUnfortunately, I\u0027ve never tried to install openstack\n\nnit: would it be better to have a bug (with all the \"effects me too\" goodness so we don\u0027t have to put a bug description in the commit message?","commit_id":"257a7185a8d5fdc11d91058f1735fa4273719aa9"}],"swiftclient/client.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f9f5d5fbf1c52448602d2cfacb107a77c520e1c6","unresolved":false,"context_lines":[{"line_number":628,"context_line":"        filter_kwargs[\u0027filter_value\u0027] \u003d os_options[\u0027region_name\u0027]"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    if os_options.get(\u0027auth_type\u0027) \u003d\u003d \u0027v3applicationcredential\u0027:"},{"line_number":631,"context_line":"        if ksa_v3 is None:"},{"line_number":632,"context_line":"            raise ClientException(\u0027Auth v3applicationcredential requires \u0027"},{"line_number":633,"context_line":"                                  \u0027keystoneauth1 package; consider upgrading \u0027"},{"line_number":634,"context_line":"                                  \u0027to python-keystoneclient\u003e\u003d2.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_95de9ed7","line":631,"updated":"2020-05-19 14:50:09.000000000","message":"better","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f9f5d5fbf1c52448602d2cfacb107a77c520e1c6","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                    \u0027application_credential_secret\u0027),"},{"line_number":641,"context_line":"                application_credential_id\u003dos_options.get("},{"line_number":642,"context_line":"                    \u0027application_credential_id\u0027))"},{"line_number":643,"context_line":"            sess \u003d ksa_session.Session(auth\u003dauth)"},{"line_number":644,"context_line":"            token \u003d sess.get_token()"},{"line_number":645,"context_line":"        except ksauthexceptions.Unauthorized:"},{"line_number":646,"context_line":"            msg \u003d \u0027Unauthorized. Check application credential id and secret.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5586c6ba","line":643,"updated":"2020-05-19 14:50:09.000000000","message":"this could in theory NameError if a keystoneclient\u003e\u003d2.0.0 changes the import paths a slightly?","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d79c21f932b34a5f941e5f9bb81030c84ce6d916","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                    \u0027application_credential_secret\u0027),"},{"line_number":641,"context_line":"                application_credential_id\u003dos_options.get("},{"line_number":642,"context_line":"                    \u0027application_credential_id\u0027))"},{"line_number":643,"context_line":"            sess \u003d ksa_session.Session(auth\u003dauth)"},{"line_number":644,"context_line":"            token \u003d sess.get_token()"},{"line_number":645,"context_line":"        except ksauthexceptions.Unauthorized:"},{"line_number":646,"context_line":"            msg \u003d \u0027Unauthorized. Check application credential id and secret.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_cc624bd8","line":643,"in_reply_to":"ff570b3c_5586c6ba","updated":"2020-05-19 17:16:01.000000000","message":"Might could. I\u0027d be very surprised if they ever did that, though.","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f9f5d5fbf1c52448602d2cfacb107a77c520e1c6","unresolved":false,"context_lines":[{"line_number":662,"context_line":"            \u0027password\u0027, \u0027v1password\u0027, \u0027v2password\u0027, \u0027v3password\u0027):"},{"line_number":663,"context_line":"        raise ClientException("},{"line_number":664,"context_line":"            \u0027Swiftclient currently only supports v3applicationcredential \u0027"},{"line_number":665,"context_line":"            \u0027for auth_type\u0027)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    try:"},{"line_number":668,"context_line":"        _ksclient \u003d ksclient.Client("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_75794ac6","line":665,"updated":"2020-05-19 14:50:09.000000000","message":"again the error message doesn\u0027t obviously match the code","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d79c21f932b34a5f941e5f9bb81030c84ce6d916","unresolved":false,"context_lines":[{"line_number":662,"context_line":"            \u0027password\u0027, \u0027v1password\u0027, \u0027v2password\u0027, \u0027v3password\u0027):"},{"line_number":663,"context_line":"        raise ClientException("},{"line_number":664,"context_line":"            \u0027Swiftclient currently only supports v3applicationcredential \u0027"},{"line_number":665,"context_line":"            \u0027for auth_type\u0027)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    try:"},{"line_number":668,"context_line":"        _ksclient \u003d ksclient.Client("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_ecee2f20","line":665,"in_reply_to":"ff570b3c_75794ac6","updated":"2020-05-19 17:16:01.000000000","message":"Well -- we don\u0027t exactly -- if someone sends in auth_type\u003d\u0027v3password\u0027, we\u0027re not actually going to end up using keystoneauth1\u0027s v3password plugin. I just don\u0027t want to needlessly break things when people have env vars set up to allow access via openstackclient for example.","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"}],"swiftclient/shell.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f9f5d5fbf1c52448602d2cfacb107a77c520e1c6","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"        elif options[\u0027os_auth_type\u0027] and options[\u0027os_auth_type\u0027] not in ("},{"line_number":1663,"context_line":"                \u0027password\u0027, \u0027v1password\u0027, \u0027v2password\u0027, \u0027v3password\u0027):"},{"line_number":1664,"context_line":"            exit(\u0027Only \"v3applicationcredential\" is supported for \u0027"},{"line_number":1665,"context_line":"                 \u0027--os-auth-type\u0027)"},{"line_number":1666,"context_line":"        elif options[\u0027auth_version\u0027] \u003d\u003d \u00273\u0027:"},{"line_number":1667,"context_line":"            if not options[\u0027auth\u0027]:"},{"line_number":1668,"context_line":"                exit(\u0027Auth version 3 requires OS_AUTH_URL to be set or \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5553666b","line":1665,"updated":"2020-05-19 14:50:09.000000000","message":"what?  why would we exit saying we only support v3applicationcredential if we apparently \"support\" (or at least allow) a host of other values?  which (surprisingly?) doesn\u0027t include v3applicationcredential!?","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"eb6fd8893f6c2af58e88774487ed95a0037076d9","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"        elif options[\u0027os_auth_type\u0027] and options[\u0027os_auth_type\u0027] not in ("},{"line_number":1663,"context_line":"                \u0027password\u0027, \u0027v1password\u0027, \u0027v2password\u0027, \u0027v3password\u0027):"},{"line_number":1664,"context_line":"            exit(\u0027Only \"v3applicationcredential\" is supported for \u0027"},{"line_number":1665,"context_line":"                 \u0027--os-auth-type\u0027)"},{"line_number":1666,"context_line":"        elif options[\u0027auth_version\u0027] \u003d\u003d \u00273\u0027:"},{"line_number":1667,"context_line":"            if not options[\u0027auth\u0027]:"},{"line_number":1668,"context_line":"                exit(\u0027Auth version 3 requires OS_AUTH_URL to be set or \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_5adb0d1a","line":1665,"in_reply_to":"ff570b3c_0c50c30a","updated":"2020-06-17 20:30:42.000000000","message":"oic elif, that might have made the code more obvious - but that\u0027s fine.","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d79c21f932b34a5f941e5f9bb81030c84ce6d916","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"        elif options[\u0027os_auth_type\u0027] and options[\u0027os_auth_type\u0027] not in ("},{"line_number":1663,"context_line":"                \u0027password\u0027, \u0027v1password\u0027, \u0027v2password\u0027, \u0027v3password\u0027):"},{"line_number":1664,"context_line":"            exit(\u0027Only \"v3applicationcredential\" is supported for \u0027"},{"line_number":1665,"context_line":"                 \u0027--os-auth-type\u0027)"},{"line_number":1666,"context_line":"        elif options[\u0027auth_version\u0027] \u003d\u003d \u00273\u0027:"},{"line_number":1667,"context_line":"            if not options[\u0027auth\u0027]:"},{"line_number":1668,"context_line":"                exit(\u0027Auth version 3 requires OS_AUTH_URL to be set or \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_0c50c30a","line":1665,"in_reply_to":"ff570b3c_5553666b","updated":"2020-05-19 17:16:01.000000000","message":"So my concern in the original review was that users would see the newly-available --os-auth-type option, then try everything under the sun: https://github.com/openstack/keystoneauth/blob/3.18.0/setup.cfg#L41-L61\n\nv3applicationcredential is covered above, but maybe it\u0027d be better to include it in this list and not have the nested ifs?","commit_id":"84e06ffd7ce66109ce52c43caad83c6fd0a82f24"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"eb6fd8893f6c2af58e88774487ed95a0037076d9","unresolved":false,"context_lines":[{"line_number":1656,"context_line":"                \u0027v3applicationcredential\u0027):"},{"line_number":1657,"context_line":"            exit(\u0027Only \"v3applicationcredential\" is supported for \u0027"},{"line_number":1658,"context_line":"                 \u0027--os-auth-type\u0027)"},{"line_number":1659,"context_line":"        elif options[\u0027os_auth_type\u0027] \u003d\u003d \u0027v3applicationcredential\u0027:"},{"line_number":1660,"context_line":"            if not (options[\u0027os_application_credential_id\u0027] and"},{"line_number":1661,"context_line":"                    options[\u0027os_application_credential_secret\u0027]):"},{"line_number":1662,"context_line":"                exit(\u0027Auth version 3 (application credential) requires \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_3aef39b1","line":1659,"updated":"2020-06-17 20:30:42.000000000","message":"i missed the elif in the last patch set - this makes the diff more clear that we DO support v3applicationcredential - but less obvious is that with this change we also attempt to \"support\" the password plugins","commit_id":"257a7185a8d5fdc11d91058f1735fa4273719aa9"}]}