)]}'
{"id":"openstack%2Fpython-swiftclient~736401","triplet_id":"openstack%2Fpython-swiftclient~master~Id6cff5dd7b9faf9c4240c0cb26b74d05ed37da5b","project":"openstack/python-swiftclient","branch":"master","topic":"bug/1873435","hashtags":[],"change_id":"Id6cff5dd7b9faf9c4240c0cb26b74d05ed37da5b","subject":"(Mostly) revert \"Cleanup session on delete\"","status":"MERGED","created":"2020-06-17 23:14:52.000000000","updated":"2020-09-19 03:48:16.000000000","submitted":"2020-09-19 03:44:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"736401-1600487071202-0e5654ba","meta_rev_id":"70c34f24735bae07724d3c6e1017d9995fa54af2","_number":736401,"virtual_id_number":736401,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-19 03:44:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-09-19 00:55:35.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":2,"date":"2020-09-11 19:08:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":1,"date":"2020-09-11 19:08:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-11 19:08:53.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2020-09-19 03:44:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ee5a47cda25d5ff18b4fdab257fb1648b59b4f76","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-06-17 23:14:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d2ca2541560627c72070029c43918891574195d0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-18 01:52:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7066b2a5080e4ae7ad137481dce3fec4 : SUCCESS in 1h 21m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/eb22a3543e9e4eeb8a2496e5e3cc6868 : SUCCESS in 5m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9ebcde9afeb643849e9367df5aa3b70c : SUCCESS in 4m 09s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/01d2b9ea4a654e9ca0e6f47981604a2b : SUCCESS in 4m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/31f755eae0c740c4bb547f3680259c4b : SUCCESS in 5m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/188ebe033b1240bea1fb616fa9c8135a : SUCCESS in 4m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/08ed878e755a436bb0a1776b9f1630a3 : SUCCESS in 7m 08s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/b066386daf7e4c60ba96535257c5de1c : SUCCESS in 55m 04s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/5328d31ada63453fa0e9ab1e978ada88 : SUCCESS in 22m 49s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/becd2e1ed8ef4ad0a61b8c6a082c2960 : SUCCESS in 22m 28s","accounts_in_message":[],"_revision_number":1},{"id":"132bed3b0dc0aef42afc71aa3849296757b39db4","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-06-18 14:54:21.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nAFAIK w/o this __del__ in py3 there\u0027s a leak, that was the gist behind behind the related bug:\n\n\n(py3) vagrant@saio:~$ cat /vagrant/.scratch/py3_leak.py\n#!/home/vagrant/.tox-swift/py3/bin/python3 -Wd\nfrom swiftclient import client\nsc \u003d client.head_object(url\u003d\u0027http://saio:8080/v1/AUTH_test\u0027,\n                        container\u003d\u0027test\u0027, name\u003d\u0027test\u0027,\n                        token\u003d\u0027AUTH_tk5631379a5ed24355a62921238961de29\u0027)\nprint(sc)\n(py3) vagrant@saio:~$ /vagrant/.scratch/py3_leak.py \n{\u0027content-length\u0027: \u00279\u0027, \u0027content-type\u0027: \u0027application/octet-stream\u0027, \u0027accept-ranges\u0027: \u0027bytes\u0027, \u0027last-modified\u0027: \u0027Thu, 18 Jun 2020 14:45:56 GMT\u0027, \u0027etag\u0027: \u0027\"8f8f647b6f9c48bc992cbbc2b545f8a9\"\u0027, \u0027x-timestamp\u0027: \u00271592491555.67851\u0027, \u0027x-object-meta-mtime\u0027: \u00271591823172.006491\u0027, \u0027x-trans-id\u0027: \u0027txb09052c67cf04bfab2d4c-005eeb7fa9\u0027, \u0027x-openstack-request-id\u0027: \u0027txb09052c67cf04bfab2d4c-005eeb7fa9\u0027, \u0027date\u0027: \u0027Thu, 18 Jun 2020 14:52:25 GMT\u0027}\nsys:1: ResourceWarning: unclosed \u003csocket.socket fd\u003d3, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027127.0.0.1\u0027, 54508), raddr\u003d(\u0027127.0.1.1\u0027, 8080)\u003e\n\nso this seems to make (at least py3) worse?","accounts_in_message":[],"_revision_number":1},{"id":"9939e8621d9d494e7156c43f21421cd5203e9597","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-08 18:39:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7e5ae906cd315695be7d8effff771eb53e271db1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-08 21:59:42.000000000","message":"Patch Set 2: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3610218396024e4e87e6cd57c43f19cf : SUCCESS in 1h 19m 48s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c6b2c16a993143bd854b243ca7e6badd : SUCCESS in 6m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cbc8c654083041f5a9a18325354501bc : FAILURE in 6m 14s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/036a84e7a20b4b3f985520c9e7bf2783 : SUCCESS in 7m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/91792c40afce428589c899641f836ece : SUCCESS in 5m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/af555c90e5b049bda87185d4d8cc5555 : SUCCESS in 7m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fbc7a86d45164f5eb88890977c776861 : SUCCESS in 7m 52s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/086f15785c384d968101467e2efd3f21 : SUCCESS in 47m 53s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/a276ba9d768f46c69e7d39ee68f2c4e1 : SUCCESS in 19m 38s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/44baf3900ed148809e7ba7b87de39936 : SUCCESS in 18m 17s","accounts_in_message":[],"_revision_number":2},{"id":"eded4193620c6e8d95fddd6bc455cc8e1ef78d50","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-08 22:05:13.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4d9ce7a58e1e25f2b4e09ae5279ff0aa670b0d5d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-09 00:00:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b2e791c921244f8f967751b1fd3c2ead : SUCCESS in 1h 22m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6c251d1f83ec459ca97f599ba3213070 : SUCCESS in 3m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d4f72ee99c2e4aae8838c58f17da86da : SUCCESS in 3m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7730726dd4804ad197839284e6e03336 : SUCCESS in 3m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dfa1ed9847584213a7a8557a43b97c03 : SUCCESS in 3m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ff759d02836e43fa9fcc4df34fe6878b : SUCCESS in 4m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9a8307c902ce45b8aac73357a2327ac3 : SUCCESS in 6m 39s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/335e822367a1476293cb4984ef0ad28e : SUCCESS in 39m 31s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/db2c86ac99704d98912133e993902198 : SUCCESS in 21m 33s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/9536f2d995884e4e8f1ccfe46c150f00 : SUCCESS in 23m 16s","accounts_in_message":[],"_revision_number":3},{"id":"d4ca468e9d81f3a9576facbbbdde3318bc81a4c8","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-09-11 19:08:53.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nI\u0027m testing with:\n\n    https://gist.github.com/clayg/e0dd6d9e01235b12bffc92643fe49328\n\nand watching open connections with something like:\n\n    while true; do lsof -p $(pgrep -f py3_leak) | grep EST | wc -l; sleep 1; done\n\nwith py2 we definitely have a resource leak on master, every connection seems to stay open (30 in my test) - with py3 idle connections got closed and the total established never got higher than 8 OMM.\n\nWhat\u0027s interesting about trying to use the __del__ in HTTPConnection is that I still see:\n\n    sys:1: ResourceWarning: unclosed \u003csocket.socket fd\u003d7, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027127.0.0.1\u0027, 33880), raddr\u003d(\u0027127.0.1.1\u0027, 8080)\u003e\n\ncoming off the socket opened for my get_auth - which uses a (different?) Connection class - when I run like:\n\n    (py3) vagrant@saio:~$ python -Wd /vagrant/.scratch/py3_leak.py \n\nWith this change I\u0027m seeing py2 close idle connections just like py3 and py3 isn\u0027t making any more resource warnings that it does already so it seems like a solid way to fix the regression.","accounts_in_message":[],"_revision_number":3},{"id":"82f0e35a664031cf8da88f72066066acdb8d80b6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-11 19:10:16.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"e73211d76be54a4e600aa372e91aa0b61220f112","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-12 03:17:26.000000000","message":"Patch Set 3: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/c7b2f77dc92e4f65a877657dff311714 : SUCCESS in 1h 13m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a394e7a73a75495686cac625a05505c3 : SUCCESS in 4m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b07d66f4bb3245ca80897b080095360b : FAILURE in 3m 47s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/79d34f5a18a542bbac8b7553eacc100b : FAILURE in 3m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/294d8442dcfc46c2afbcf2935747202d : SUCCESS in 4m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/761169ac3dba4370aa94ff69e61f4558 : SUCCESS in 4m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d9a8775cbfd147e2a11792d6eda6f53c : SUCCESS in 15m 08s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/5c6de539ec454c37b2430224b14af3b7 : SUCCESS in 43m 24s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/e546f393f27049f58b0bfff8bdc6e326 : SUCCESS in 17m 03s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/803cc1aae55349218aa1a93a5bb62dae : SUCCESS in 18m 57s","accounts_in_message":[],"_revision_number":3},{"id":"7b6c7f067aeb204db00a51255e09e1e21038a678","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-19 00:55:35.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"457fba2afe76fc9e49b1caed709da2c0cb123e8e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-19 02:13:05.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/bfe7b8712a5d4d5cb42b4824a33ecbf6 : SUCCESS in 1h 16m 25s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f133ab7170bf42e3ad3d4af214248d97 : SUCCESS in 3m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4303d6181f4645d8832e3a77d4088d04 : SUCCESS in 3m 07s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f74842c2731f4097bd20d103413015e6 : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f37703ad1a9846148f09a8e9713b2374 : SUCCESS in 5m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0a4b97bf1c2c46629320144c11328e31 : SUCCESS in 3m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/77b1c59542544576889ad2abd1c91b46 : SUCCESS in 13m 03s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/095b6ec8a68740d49c2006f2271c2a03 : SUCCESS in 34m 01s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/6aa9e6dbeba14195a1f278cc562ccf1d : SUCCESS in 21m 33s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/12e68e71f6da41d4a716a4c71d26c711 : SUCCESS in 21m 41s","accounts_in_message":[],"_revision_number":3},{"id":"fbc4cbe563809505b07b3111ef7f658c9ad7be26","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-19 02:13:19.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"5ccba42a9a0bca3101a79b4dfd543a0693c7c7e4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-19 03:44:30.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4c0b930169ba4493846de1b671820682 : SUCCESS in 1h 25m 10s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/96ce1d5924524ea7bd9a681160432e27 : SUCCESS in 3m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e9fa0ef29ee64707b9ba617694b9b4d2 : SUCCESS in 3m 13s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/03f1c183bf804ed4a80d2bfbdaeb6658 : SUCCESS in 3m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2449fba86e624854bad3f80b80c7aefa : SUCCESS in 4m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/49731425e97a4525acb58bccfdb9fb86 : SUCCESS in 2m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/619c88c220d24a7e8b691096c37f2470 : SUCCESS in 14m 31s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/ce34cafa08ae4fccac613ccea1303203 : SUCCESS in 43m 10s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/7148b6f947f047948d8224845d5dc48d : SUCCESS in 17m 03s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/9e26acf5f229436b944f36286f481aea : SUCCESS in 17m 47s","accounts_in_message":[],"_revision_number":3},{"id":"629e2edd434c48aa73f39934041cdd9cf2647b55","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-19 03:44:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"ad94b4fdb1c545f1749031802de67ea16a4a15be","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-19 03:48:16.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f5bcf0db879842b2b55751a226dda182 : SUCCESS in 1m 34s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0c70d164ba52d76a6dbbbe8765d15fb969fc07ff","revisions":{"c47d72a4fe1445110ba19a7656e9a37b676e2599":{"kind":"REWORK","_number":1,"created":"2020-06-17 23:14:52.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/01/736401/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/01/736401/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/1"}}},"commit":{"parents":[{"commit":"b63d9a3e96663753f643df41a420b1228210f9fa","subject":"Merge \"Application credential support follow-up\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b63d9a3e96663753f643df41a420b1228210f9fa"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-06-17 22:44:22.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-06-17 22:44:28.000000000","tz":-420},"subject":"Revert \"Cleanup session on delete\"","message":"Revert \"Cleanup session on delete\"\n\nThis reverts commit 1f26c5736949e1c3b57c024a315e33fc419f126e.\n\nChange-Id: Id6cff5dd7b9faf9c4240c0cb26b74d05ed37da5b\nCloses-Bug: #1873435\nRelated-Bug: #1838775\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c47d72a4fe1445110ba19a7656e9a37b676e2599"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/c47d72a4fe1445110ba19a7656e9a37b676e2599"}]},"branch":"refs/heads/master"},"6f1a66fc45df20da92894487d074170e37382853":{"kind":"REWORK","_number":2,"created":"2020-09-08 18:39:19.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/01/736401/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/01/736401/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/2"}}},"commit":{"parents":[{"commit":"9d8db8f6126542dc18ea1b14e078d64cc1a254e4","subject":"Merge \"Speed up test_lazy_connections\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9d8db8f6126542dc18ea1b14e078d64cc1a254e4"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-06-17 22:44:22.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-08 18:34:43.000000000","tz":-420},"subject":"(Mostly) revert \"Cleanup session on delete\"","message":"(Mostly) revert \"Cleanup session on delete\"\n\nThis reverts commit 1f26c5736949e1c3b57c024a315e33fc419f126e for py2.\nApparently the existence of the __del__ method on Python 2 prevents us\nfrom cleaning up all file descriptors.\n\nChange-Id: Id6cff5dd7b9faf9c4240c0cb26b74d05ed37da5b\nCloses-Bug: #1873435\nRelated-Bug: #1838775\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6f1a66fc45df20da92894487d074170e37382853"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/6f1a66fc45df20da92894487d074170e37382853"}]},"branch":"refs/heads/master"},"0c70d164ba52d76a6dbbbe8765d15fb969fc07ff":{"kind":"REWORK","_number":3,"created":"2020-09-08 22:05:13.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/01/736401/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/01/736401/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/01/736401/3"}}},"commit":{"parents":[{"commit":"9d8db8f6126542dc18ea1b14e078d64cc1a254e4","subject":"Merge \"Speed up test_lazy_connections\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/9d8db8f6126542dc18ea1b14e078d64cc1a254e4"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-06-17 22:44:22.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-08 22:04:54.000000000","tz":-420},"subject":"(Mostly) revert \"Cleanup session on delete\"","message":"(Mostly) revert \"Cleanup session on delete\"\n\nThis reverts commit 1f26c5736949e1c3b57c024a315e33fc419f126e for py2.\nApparently the existence of the __del__ method on Python 2 prevents us\nfrom cleaning up all file descriptors.\n\nChange-Id: Id6cff5dd7b9faf9c4240c0cb26b74d05ed37da5b\nCloses-Bug: #1873435\nRelated-Bug: #1838775\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0c70d164ba52d76a6dbbbe8765d15fb969fc07ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/0c70d164ba52d76a6dbbbe8765d15fb969fc07ff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}