)]}'
{"id":"openstack%2Fpython-swiftclient~736426","triplet_id":"openstack%2Fpython-swiftclient~master~Iae149533d04c7b173c4ef88fb775f5fe13c16466","project":"openstack/python-swiftclient","branch":"master","hashtags":[],"change_id":"Iae149533d04c7b173c4ef88fb775f5fe13c16466","subject":"Clean up some warnings","status":"MERGED","created":"2020-06-18 04:05:37.000000000","updated":"2020-06-23 05:24:15.000000000","submitted":"2020-06-23 05:22:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"736426-1592889779623-3d5ab54e","meta_rev_id":"974b0b73b97db6679b5d86bb5fe6af3221836f41","_number":736426,"virtual_id_number":736426,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-23 05:22:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":2,"date":"2020-06-18 14:41:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-06-23 04:04:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-18 14:41:00.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2020-06-23 05:22:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0ee93f526cc5f270291ca6af17656a86ba98d728","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-06-18 04:05:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"46c464f741a1d144df64cd90dd4e80a6dad43974","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-18 05:35:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7fef4052bb714627b2a0137e35ad3aea : SUCCESS in 1h 28m 46s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e1a45412ed0646f3be068107317afae9 : SUCCESS in 4m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bdeb8449f8084ebb83a087f53d056637 : SUCCESS in 4m 03s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4938e403df634b5b8bdf66083f5c1b5e : SUCCESS in 3m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2084553716394ff79a2766598ea39cff : SUCCESS in 3m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e54ed110063a461b8253c8dc0adbe0cd : SUCCESS in 4m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2c46ee38e9ed473aa448e601942e89a5 : SUCCESS in 5m 08s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/ac6d1a8f9a164db4a4fe454eaccff776 : SUCCESS in 44m 08s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/b7c26838b9cd494db7a9c7683e65c0b8 : SUCCESS in 21m 35s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/eccc2ddbbdbf48bd9742092c4a8bacf7 : SUCCESS in 19m 06s","accounts_in_message":[],"_revision_number":1},{"id":"b795b6798ac832d81794183e0d050ce0e522f3a9","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-06-18 14:41:00.000000000","message":"Patch Set 1: Code-Review+2\n\nboth changes seem reasonable - where did you see these \"warnings\" ?","accounts_in_message":[],"_revision_number":1},{"id":"c78adb472ee25863f4de444750edadd49a5e776a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-06-18 17:59:00.000000000","message":"Patch Set 1:\n\nI was trying out pytest as a test runner like\n\n pytest -Wall test/unit/\n\nand seeing things like\n\ntest/unit/test_command_helpers.py::TestStatHelpers::test_stat_account_human\n  /home/tburke/code/python-swiftclient/swiftclient/utils.py:221: DeprecationWarning: Using or importing the ABCs from \u0027collections\u0027 instead of from \u0027collections.abc\u0027 is deprecated since Python 3.3,and in 3.9 it will stop working\n    if isinstance(options, collections.Mapping):\n\ntest/unit/test_shell.py::TestParsing::test_password_prompt\n  /home/tburke/code/python-swiftclient/swiftclient/shell.py:1605: GetPassWarning: Can not control echo on the terminal.\n    return getpass.getpass()\n\ntest/unit/test_utils.py::TestLengthWrapper::test_segmented_file\ntest/unit/test_utils.py::TestLengthWrapper::test_segmented_file\ntest/unit/test_utils.py::TestLengthWrapper::test_segmented_file\n  /home/tburke/code/python-swiftclient/test/unit/test_utils.py:544: ResourceWarning: unclosed file \u003c_io.BufferedReader name\u003d\u0027/tmp/tmpspjz2iel\u0027\u003e\n    data \u003d u.LengthWrapper(contents, segment_length, True)\n\ntest/unit/test_utils.py::TestLengthWrapper::test_segmented_file\n  /usr/lib64/python3.7/unittest/case.py:628: ResourceWarning: unclosed file \u003c_io.BufferedReader name\u003d\u0027/tmp/tmpspjz2iel\u0027\u003e\n    testMethod()\n\ntest/unit/test_utils.py::TestLengthWrapper::test_tempfile\n  /usr/lib64/python3.7/unittest/case.py:628: ResourceWarning: unclosed file \u003c_io.BufferedReader name\u003d\u0027/tmp/tmpi90bqp07\u0027\u003e\n    testMethod()\n\nThe getpass() warning actually causes a test failure since it no longer raises an exception :-/\n\nThere were a couple other issues, too -- I\u0027m not actually sure how hard we want to try to make our unit tests runnable under pytest -- I mainly was poking at it because I knew it could catch \u0026 display the ResourceWarning at the heart of https://review.opendev.org/#/c/736401/ \u0026 https://review.opendev.org/#/c/721051/","accounts_in_message":[],"_revision_number":1},{"id":"4608293c28054c6c17eeeac575b07092051ed82b","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-06-23 04:04:27.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"08ca38a5323db3a9f5293d659d106c19be8b4a54","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 04:04:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8f676c52c810b836cf99d544f79e3e6009a54616","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 05:22:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/95e4e52268b047e59ed2b7996e79a394 : SUCCESS in 1h 17m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/867c3a6410bc4f54a90f204e51e7ce45 : SUCCESS in 5m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/890681367d6148e99f71686f568d32e4 : SUCCESS in 4m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a25367afd62b4805a9efbed03ba74d06 : SUCCESS in 4m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/33ba70d2a04341ba8c3b891808d733e6 : SUCCESS in 4m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/33fd4cf011c24e939fd690a24fb005de : SUCCESS in 5m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5aa640f12ba74ebdb356809dc6ff0a64 : SUCCESS in 8m 07s\n- swiftclient-swift-functional https://zuul.opendev.org/t/openstack/build/b6668c4e9bde44e8a02e94120cb0a297 : SUCCESS in 45m 06s\n- swiftclient-functional https://zuul.opendev.org/t/openstack/build/3683f7c7291c4a2a9f4e0fe9e5cc1047 : SUCCESS in 21m 43s\n- swiftclient-functional-py2 https://zuul.opendev.org/t/openstack/build/0fdc5c8698b246ffa32927cba7f093e7 : SUCCESS in 19m 07s","accounts_in_message":[],"_revision_number":1},{"id":"3003afc50374b89cd589a434b28d28326c945cc3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 05:22:59.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"974b0b73b97db6679b5d86bb5fe6af3221836f41","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 05:24:15.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fb49862416294ba8895855100d42f943 : SUCCESS in 1m 02s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"22d1f3a39a9b23a62f443c2bd8ab9639c1b5a669","revisions":{"22d1f3a39a9b23a62f443c2bd8ab9639c1b5a669":{"kind":"REWORK","_number":1,"created":"2020-06-18 04:05:37.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/26/736426/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/26/736426/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/26/736426/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/26/736426/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/26/736426/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/26/736426/1"}}},"commit":{"parents":[{"commit":"b63d9a3e96663753f643df41a420b1228210f9fa","subject":"Merge \"Application credential support follow-up\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/b63d9a3e96663753f643df41a420b1228210f9fa"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-06-18 04:05:03.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-06-18 04:05:25.000000000","tz":-420},"subject":"Clean up some warnings","message":"Clean up some warnings\n\nChange-Id: Iae149533d04c7b173c4ef88fb775f5fe13c16466\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/22d1f3a39a9b23a62f443c2bd8ab9639c1b5a669"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/22d1f3a39a9b23a62f443c2bd8ab9639c1b5a669"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}