)]}'
{"tests/test_shell.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"9cae20dc73bce2667cf4ede2a22f858df0d818e8","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(TestShell, self).__init__(*args, **kwargs)"},{"line_number":29,"context_line":"        os.environ[\u0027ST_AUTH\u0027] \u003d \"http://localhost:8080/auth/v1.0\""},{"line_number":30,"context_line":"        os.environ[\u0027ST_USER\u0027] \u003d \"test:tester\""},{"line_number":31,"context_line":"        os.environ[\u0027ST_KEY\u0027] \u003d \"testing\""},{"line_number":32,"context_line":"        tmpfile \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BMQ8%3D","line":29,"updated":"2014-03-28 14:55:39.000000000","message":"most people mock.patch.dict for os.environ but i don\u0027t know if there is much a difference in this case (except maybe be sure there is no side effects)","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"58cd42a70b6e3f981b1a815232580e2cbd69b543","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(TestShell, self).__init__(*args, **kwargs)"},{"line_number":29,"context_line":"        os.environ[\u0027ST_AUTH\u0027] \u003d \"http://localhost:8080/auth/v1.0\""},{"line_number":30,"context_line":"        os.environ[\u0027ST_USER\u0027] \u003d \"test:tester\""},{"line_number":31,"context_line":"        os.environ[\u0027ST_KEY\u0027] \u003d \"testing\""},{"line_number":32,"context_line":"        tmpfile \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAW3%2F%2Ffr0%3D","line":29,"in_reply_to":"AAAAWH%2F%2BMQ8%3D","updated":"2014-04-14 08:29:27.000000000","message":"I just checked this; mocking this is no longer required in this patchset, thus I remove these statements.","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"d5c90f5eca76653a4ae548e8f2e82b94bbea91f7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(TestShell, self).__init__(*args, **kwargs)"},{"line_number":29,"context_line":"        os.environ[\u0027ST_AUTH\u0027] \u003d \"http://localhost:8080/auth/v1.0\""},{"line_number":30,"context_line":"        os.environ[\u0027ST_USER\u0027] \u003d \"test:tester\""},{"line_number":31,"context_line":"        os.environ[\u0027ST_KEY\u0027] \u003d \"testing\""},{"line_number":32,"context_line":"        tmpfile \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":33,"context_line":"        self.tmpfile \u003d tmpfile.name"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAW3%2F%2Fe8U%3D","line":30,"updated":"2014-04-14 10:05:47.000000000","message":"Removing this part without any local errors should have raised my suspicion - env variables were still set locally, thus it worked for me.\n\nI updated the patch, now using mock.patch.dict for this.","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"9cae20dc73bce2667cf4ede2a22f858df0d818e8","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def tearDown(self):"},{"line_number":36,"context_line":"        try:"},{"line_number":37,"context_line":"            os.remove(self.tmpfile)"},{"line_number":38,"context_line":"        except OSError:"},{"line_number":39,"context_line":"            pass"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BMP4%3D","line":37,"updated":"2014-03-28 14:55:39.000000000","message":"using fixtures.TempDir would have been nice but i guess we are not using fixtures.","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"58cd42a70b6e3f981b1a815232580e2cbd69b543","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def tearDown(self):"},{"line_number":36,"context_line":"        try:"},{"line_number":37,"context_line":"            os.remove(self.tmpfile)"},{"line_number":38,"context_line":"        except OSError:"},{"line_number":39,"context_line":"            pass"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAW3%2F%2FfsU%3D","line":37,"in_reply_to":"AAAAWH%2F%2BMP4%3D","updated":"2014-04-14 08:29:27.000000000","message":"Would be nice, but as you already said - we\u0027re not (yet) using fixtures, so I keep it as it is - if this is ok :)","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"9cae20dc73bce2667cf4ede2a22f858df0d818e8","unresolved":false,"context_lines":[{"line_number":312,"context_line":"    def test_capabilities(self, connection):"},{"line_number":313,"context_line":"        argv \u003d [\"\", \"capabilities\"]"},{"line_number":314,"context_line":"        connection.return_value.get_capabilities.return_value \u003d {\u0027swift\u0027: None}"},{"line_number":315,"context_line":"        swiftclient.shell.main(argv)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BL%2FQ%3D","line":315,"updated":"2014-03-28 14:55:39.000000000","message":"is it testing something here?","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"58cd42a70b6e3f981b1a815232580e2cbd69b543","unresolved":false,"context_lines":[{"line_number":312,"context_line":"    def test_capabilities(self, connection):"},{"line_number":313,"context_line":"        argv \u003d [\"\", \"capabilities\"]"},{"line_number":314,"context_line":"        connection.return_value.get_capabilities.return_value \u003d {\u0027swift\u0027: None}"},{"line_number":315,"context_line":"        swiftclient.shell.main(argv)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAW3%2F%2Ffss%3D","line":315,"in_reply_to":"AAAAWH%2F%2BL%2FQ%3D","updated":"2014-04-14 08:29:27.000000000","message":"Accidentally removed the test line, will add it again.","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"9cae20dc73bce2667cf4ede2a22f858df0d818e8","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        swiftclient.shell.main(argv)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":319,"context_line":"    unittest.main()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BL%2FI%3D","line":318,"updated":"2014-03-28 14:55:39.000000000","message":"is it needed?","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"58cd42a70b6e3f981b1a815232580e2cbd69b543","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        swiftclient.shell.main(argv)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":319,"context_line":"    unittest.main()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAW3%2F%2FftA%3D","line":318,"in_reply_to":"AAAAWH%2F%2BL%2FI%3D","updated":"2014-04-14 08:29:27.000000000","message":"No - only if you want to run it without nose/testr. Removed","commit_id":"c570cb80b0e62cdf53c3af8df16fc40f4fd84e24"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"1782089bfe443634a3d6767d88dd916d52688e48","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                 mock.call(\u0027\u0027)]"},{"line_number":62,"context_line":"        mock_print.assert_has_calls(calls)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @mock.patch.dict(os.environ, mocked_os_environ)"},{"line_number":65,"context_line":"    @mock.patch(\u0027swiftclient.shell.MultiThreadingManager._print\u0027)"},{"line_number":66,"context_line":"    @mock.patch(\u0027swiftclient.shell.Connection\u0027)"},{"line_number":67,"context_line":"    def test_stat_container(self, connection, mock_print):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAW3%2F%2FdII%3D","line":64,"updated":"2014-04-14 13:55:50.000000000","message":"Just a minor thing to DRY, what about moving all those @mock.patch.dict(os.environ, mocked_os_environ) in setUp() which would make things cleaner IMHO?","commit_id":"953a670f69d60b9873ca73e8c117e5259459b2ac"}]}