)]}'
{"id":"openstack%2Fpython-swiftclient~74039","triplet_id":"openstack%2Fpython-swiftclient~master~If2c64e55cce3650bc493e4c9ad77a5c497d28a36","project":"openstack/python-swiftclient","branch":"master","topic":"replace-with-assertIsNone","hashtags":[],"change_id":"If2c64e55cce3650bc493e4c9ad77a5c497d28a36","subject":"Replace assertEqual(None, *) with assertIsNone in tests","status":"ABANDONED","created":"2014-02-17 13:43:04.000000000","updated":"2014-03-13 06:03:33.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"661dcaadbe1432eda096da3dc4587d0d5f29eaaa","_number":74039,"virtual_id_number":74039,"owner":{"_account_id":8229,"name":"Zhang Jinnan","email":"ben.os@99cloud.net","username":"zhang-jinnan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-03-03 04:40:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":8229,"name":"Zhang Jinnan","email":"ben.os@99cloud.net","username":"zhang-jinnan"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"disliked":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-03-05 18:55:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"date":"2014-03-03 03:45:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8229,"name":"Zhang Jinnan","email":"ben.os@99cloud.net","username":"zhang-jinnan"},{"value":-1,"date":"2014-03-03 19:14:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":2,"date":"2014-02-24 22:41:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-03-05 17:02:21.000000000","_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8229,"name":"Zhang Jinnan","email":"ben.os@99cloud.net","username":"zhang-jinnan"},{"value":0,"date":"2014-03-03 19:14:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"date":"2014-02-24 22:41:58.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":8229,"name":"Zhang Jinnan","email":"ben.os@99cloud.net","username":"zhang-jinnan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-24 22:41:58.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2014-03-03 04:40:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-03-03 19:14:22.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2014-03-05 17:02:21.000000000","updated_by":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"reviewer":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"state":"REVIEWER"}],"messages":[{"id":"7294f2a9c7b3b16510f1b93e85dd85f1bf93d284","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-17 13:43:04.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e078b11a35956cd645c577323b1089a70fafaba7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-17 14:23:04.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-pep8/5cec4a8 : SUCCESS in 46s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/39/74039/1/check/gate-python-swiftclient-docs/2e4f9d4/doc/build/html/ : SUCCESS in 44s\n- gate-python-swiftclient-python26 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python26/129331f : SUCCESS in 1m 08s\n- gate-python-swiftclient-python27 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python27/f7e3969 : SUCCESS in 58s\n- gate-python-swiftclient-python33 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python33/130004d : FAILURE in 4m 16s (non-voting)\n- gate-python-swiftclient-pypy http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-pypy/b89cb1e : SUCCESS in 1m 56s\n- check-swift-dsvm-functional http://logs.openstack.org/39/74039/1/check/check-swift-dsvm-functional/87a4219 : SUCCESS in 12m 03s\n- check-tempest-dsvm-full http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-full/ca97f1f : SUCCESS in 39m 54s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-postgres-full/4680f2b : SUCCESS in 32m 18s\n- check-tempest-dsvm-neutron http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-neutron/34e2e55 : SUCCESS in 30m 00s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/39/74039/1/check/gate-tempest-dsvm-large-ops/9044148 : SUCCESS in 14m 13s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/39/74039/1/check/gate-tempest-dsvm-neutron-large-ops/93ce709 : SUCCESS in 14m 23s\n- check-grenade-dsvm http://logs.openstack.org/39/74039/1/check/check-grenade-dsvm/668772b : SUCCESS in 27m 47s\n","accounts_in_message":[],"_revision_number":1},{"id":"9d14d7ee0ca7b1069ba89aaaff7190fa65cf974b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 22:41:58.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"fd8ebfdbca663d6cd795d09f8cfb25adf24cecd6","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2014-02-24 22:41:58.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nHuh, weird. I thought these would fail like the similar proposal to Swift did, but I guess swiftclient uses a different testing framework that supports these assertions.","accounts_in_message":[],"_revision_number":1},{"id":"2ff96aaa7ffdac611339829cb634ce839e3e4c14","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 23:41:10.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-pep8/5b28181 : SUCCESS in 1m 02s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/39/74039/1/check/gate-python-swiftclient-docs/44c92c5/doc/build/html/ : SUCCESS in 1m 19s\n- gate-python-swiftclient-python26 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python26/e4da8cb : SUCCESS in 1m 00s\n- gate-python-swiftclient-python27 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python27/27a79b9 : SUCCESS in 1m 24s\n- gate-python-swiftclient-python33 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python33/a89f857 : FAILURE in 2m 55s (non-voting)\n- gate-python-swiftclient-pypy http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-pypy/ad7306e : SUCCESS in 1m 48s\n- check-swift-dsvm-functional http://logs.openstack.org/39/74039/1/check/check-swift-dsvm-functional/5f139d0 : SUCCESS in 13m 02s\n- check-tempest-dsvm-full http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-full/5411fad : SUCCESS in 44m 35s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-postgres-full/f7ce772 : SUCCESS in 53m 07s\n- check-tempest-dsvm-neutron http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-neutron/26de792 : SUCCESS in 37m 59s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-neutron-full/1134cf8 : SUCCESS in 55m 13s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/39/74039/1/check/gate-tempest-dsvm-large-ops/d1f085b : SUCCESS in 14m 03s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/39/74039/1/check/gate-tempest-dsvm-neutron-large-ops/046af0b : SUCCESS in 15m 47s\n- check-grenade-dsvm http://logs.openstack.org/39/74039/1/check/check-grenade-dsvm/acfe12a : SUCCESS in 36m 15s\n","accounts_in_message":[],"_revision_number":1},{"id":"07be724cab085be83971985cc45fe6f27ccbbcfc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-03 03:45:45.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e9004a5b21835fff69e7b41f3cb19d29f5f09878","author":{"_account_id":8229,"name":"Zhang Jinnan","email":"ben.os@99cloud.net","username":"zhang-jinnan"},"date":"2014-03-03 03:45:45.000000000","message":"Patch Set 1:\n\nhello?","accounts_in_message":[],"_revision_number":1},{"id":"5eb9aaabc90dcbdedcce1556bb8e637e131c402a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-03 04:40:48.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-pep8/d2a39f9 : SUCCESS in 32s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/39/74039/1/check/gate-python-swiftclient-docs/23241e9/doc/build/html/ : SUCCESS in 57s\n- gate-python-swiftclient-python26 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python26/08b2cf5 : SUCCESS in 35s\n- gate-python-swiftclient-python27 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python27/1e4c883 : SUCCESS in 54s\n- gate-python-swiftclient-python33 http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-python33/271cead : FAILURE in 3m 13s (non-voting)\n- gate-python-swiftclient-pypy http://logs.openstack.org/39/74039/1/check/gate-python-swiftclient-pypy/feeb03e : SUCCESS in 1m 48s\n- check-swift-dsvm-functional http://logs.openstack.org/39/74039/1/check/check-swift-dsvm-functional/d13ba1c : SUCCESS in 13m 50s\n- check-tempest-dsvm-full http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-full/70b41fd : SUCCESS in 45m 14s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-postgres-full/0fda1a5 : SUCCESS in 53m 39s\n- check-tempest-dsvm-neutron http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-neutron/4d76be1 : SUCCESS in 40m 24s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/39/74039/1/check/check-tempest-dsvm-neutron-full/4596c73 : SUCCESS in 52m 17s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/39/74039/1/check/gate-tempest-dsvm-large-ops/8dcbb83 : SUCCESS in 15m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/39/74039/1/check/gate-tempest-dsvm-neutron-large-ops/9ee8e4d : SUCCESS in 15m 53s\n- check-grenade-dsvm http://logs.openstack.org/39/74039/1/check/check-grenade-dsvm/6c8b8bd : SUCCESS in 37m 59s\n","accounts_in_message":[],"_revision_number":1},{"id":"8a926e6abe17562e4d4ca00c76aa7fa6aa953424","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2014-03-03 19:14:22.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nWhy is this needed? This prevents testing on Py26 (assertIsNone is new in Py27). Why should we limit that?","accounts_in_message":[],"_revision_number":1},{"id":"2b0e48d3491cd3dd83fed49f005a580240f66722","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2014-03-05 17:02:21.000000000","message":"Patch Set 1: Do not merge\n\nI\u0027m going to go ahead and -2 this since it would break 2.6 compatibility","accounts_in_message":[],"_revision_number":1},{"id":"e4b34bc95b529d7d387ab83d5c4a7dc33fb764c2","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2014-03-05 17:51:46.000000000","message":"Patch Set 1: (1 inline comment)\n\nGuys, this doesn\u0027t actually break things. The swiftclient tests use testtools.TestCase, not unittest.TestCase, and that comes with fancy assertions.","accounts_in_message":[],"_revision_number":1},{"id":"445a71751acc01fc680c9ddf2d0b635a2dc03f2d","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2014-03-05 18:55:58.000000000","message":"Patch Set 1: No score\n\nhehe... alright...","accounts_in_message":[],"_revision_number":1},{"id":"7886ade11daf70fe1c1e147181e712b24d595930","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-03-13 06:03:33.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"89fc11125f0a8a2b2c2e502e3009597854789850","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-03-13 06:03:33.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7a844340b447049565bc732e614e7c6374b3bd1e","revisions":{"7a844340b447049565bc732e614e7c6374b3bd1e":{"kind":"REWORK","_number":1,"created":"2014-02-17 13:43:04.000000000","uploader":{"_account_id":8229,"name":"Zhang Jinnan","email":"ben.os@99cloud.net","username":"zhang-jinnan"},"ref":"refs/changes/39/74039/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/39/74039/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/39/74039/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/39/74039/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/39/74039/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/39/74039/1"}}},"commit":{"parents":[{"commit":"380e83087447b724458ba16e11f527babb39dd01","subject":"Remove multipart/form-data file upload","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/380e83087447b724458ba16e11f527babb39dd01"}]}],"author":{"name":"zhang-jinnan","email":"ben.os@99cloud.net","date":"2014-02-17 12:16:47.000000000","tz":480},"committer":{"name":"zhang-jinnan","email":"ben.os@99cloud.net","date":"2014-02-17 13:42:43.000000000","tz":480},"subject":"Replace assertEqual(None, *) with assertIsNone in tests","message":"Replace assertEqual(None, *) with assertIsNone in tests\n\nReplace assertEqual(None, *) with assertIsNone in tests to have\nmore clear messages in case of failure.\n\nChange-Id: If2c64e55cce3650bc493e4c9ad77a5c497d28a36\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7a844340b447049565bc732e614e7c6374b3bd1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/7a844340b447049565bc732e614e7c6374b3bd1e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
