)]}'
{"swiftclient/shell.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"1bfcd5d3eb3be0eee4aeaf5cd206078de5cfefc3","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"    if arguments:"},{"line_number":1307,"context_line":"        argv \u003d arguments"},{"line_number":1308,"context_line":"    else:"},{"line_number":1309,"context_line":"        argv \u003d sys_argv"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"    version \u003d client_version"},{"line_number":1312,"context_line":"    parser \u003d OptionParser(version\u003d\u0027%%prog %s\u0027 % version,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FO04%3D","line":1309,"updated":"2014-03-19 09:10:24.000000000","message":"why do you need to have a global like that? The only reason I see its needed is to get argv[0] basename, which can be static right? (if someone wants to call his bin/swift to bin/superman I think he can forgive us if the help doesn\u0027t match the superman name)","commit_id":"f48b3d18e8440259d3a44692a614e3ba1bb45da9"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"baec8072ecd8fc727f55603b99694edf7cf292c9","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"    if arguments:"},{"line_number":1307,"context_line":"        argv \u003d arguments"},{"line_number":1308,"context_line":"    else:"},{"line_number":1309,"context_line":"        argv \u003d sys_argv"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"    version \u003d client_version"},{"line_number":1312,"context_line":"    parser \u003d OptionParser(version\u003d\u0027%%prog %s\u0027 % version,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FOVE%3D","line":1309,"in_reply_to":"AAAAWH%2F%2FO04%3D","updated":"2014-03-19 10:24:42.000000000","message":"You\u0027re right, it\u0027s only needed for basename(argv[0]). I will just add a BASENAME\u003d\u0027swift\u0027 to the top and replace basename(argv[0]) with this and drop these globals.","commit_id":"f48b3d18e8440259d3a44692a614e3ba1bb45da9"}],"tox.ini":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"1bfcd5d3eb3be0eee4aeaf5cd206078de5cfefc3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"commands \u003d python setup.py testr --testr-args\u003d\"{posargs}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[testenv:pypy]"},{"line_number":16,"context_line":"deps \u003d setuptools\u003c3.2"},{"line_number":17,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":18,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAAWH%2F%2FO0k%3D","line":16,"updated":"2014-03-19 09:10:24.000000000","message":"as you noted already i have a standalone patch here, https://review.openstack.org/#/c/81479/","commit_id":"f48b3d18e8440259d3a44692a614e3ba1bb45da9"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"baec8072ecd8fc727f55603b99694edf7cf292c9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"commands \u003d python setup.py testr --testr-args\u003d\"{posargs}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[testenv:pypy]"},{"line_number":16,"context_line":"deps \u003d setuptools\u003c3.2"},{"line_number":17,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":18,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAAWH%2F%2FOU0%3D","line":16,"in_reply_to":"AAAAWH%2F%2FO0k%3D","updated":"2014-03-19 10:24:42.000000000","message":"I will remove this and rebase against your patch","commit_id":"f48b3d18e8440259d3a44692a614e3ba1bb45da9"}]}
