)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0bee086a627507504833492a0549da68168aab92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a1daef20_5eef39f2","updated":"2021-12-18 06:08:52.000000000","message":"Still trying to understand what we\u0027re doing and why... I *think* it comes down to our crazy split-brain of sometimes dealing with keystoneclient and sometimes keystoneauth directly... just want to make sure I\u0027ve got it right.","commit_id":"e9c786863c822d0c37f8ffab63b7d79c44911b4b"}],"swiftclient/client.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0bee086a627507504833492a0549da68168aab92","unresolved":true,"context_lines":[{"line_number":623,"context_line":"    region_name \u003d os_options.get(\u0027region_name\u0027) or \u0027default\u0027"},{"line_number":624,"context_line":"    if os_options.get(\u0027region_name\u0027):"},{"line_number":625,"context_line":"        filter_kwargs[\u0027attr\u0027] \u003d \u0027region\u0027"},{"line_number":626,"context_line":"        filter_kwargs[\u0027filter_value\u0027] \u003d os_options[\u0027region_name\u0027]"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    if os_options.get(\u0027auth_type\u0027) and os_options[\u0027auth_type\u0027] not in ("},{"line_number":629,"context_line":"            \u0027password\u0027, \u0027v2password\u0027, \u0027v3password\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d306c651_ca942250","line":626,"updated":"2021-12-18 06:08:52.000000000","message":"Is this block no longer necessary? Or is it kept for backwards compatibility with some older version of keystoneclient? Do we know at what point this stopped working? Oh... or maybe it never worked *for ksa*... only ksc...","commit_id":"e9c786863c822d0c37f8ffab63b7d79c44911b4b"},{"author":{"_account_id":34379,"name":"Francesco Lombardo","email":"francesco.lombardo@garr.it","username":"zvfvrv"},"change_message_id":"dbf206a910ee60101cc1ccda73f3ba1fb6181366","unresolved":true,"context_lines":[{"line_number":623,"context_line":"    region_name \u003d os_options.get(\u0027region_name\u0027) or \u0027default\u0027"},{"line_number":624,"context_line":"    if os_options.get(\u0027region_name\u0027):"},{"line_number":625,"context_line":"        filter_kwargs[\u0027attr\u0027] \u003d \u0027region\u0027"},{"line_number":626,"context_line":"        filter_kwargs[\u0027filter_value\u0027] \u003d os_options[\u0027region_name\u0027]"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    if os_options.get(\u0027auth_type\u0027) and os_options[\u0027auth_type\u0027] not in ("},{"line_number":629,"context_line":"            \u0027password\u0027, \u0027v2password\u0027, \u0027v3password\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"60abbc91_8020d71d","line":626,"in_reply_to":"d306c651_ca942250","updated":"2021-12-19 21:05:06.000000000","message":"I honestly think it\u0027s not needed anymore and if that\u0027s okay with you I can remove it, honestly I don\u0027t know when it stopped working with ksa.","commit_id":"e9c786863c822d0c37f8ffab63b7d79c44911b4b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0bee086a627507504833492a0549da68168aab92","unresolved":true,"context_lines":[{"line_number":696,"context_line":"        endpoint \u003d _ksclient.service_catalog.url_for("},{"line_number":697,"context_line":"            service_type\u003dservice_type,"},{"line_number":698,"context_line":"            endpoint_type\u003dendpoint_type,"},{"line_number":699,"context_line":"            **filter_kwargs)"},{"line_number":700,"context_line":"    except ksexceptions.EndpointNotFound:"},{"line_number":701,"context_line":"        raise ClientException(\u0027Endpoint for %s not found - \u0027"},{"line_number":702,"context_line":"                              \u0027have you specified a region?\u0027 % service_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c97e24bb_c0fb7cee","line":699,"updated":"2021-12-18 06:08:52.000000000","message":"Should this have the region_name kwarg, too? Or is attr/filter_value the way to go when dealing with ksc?","commit_id":"e9c786863c822d0c37f8ffab63b7d79c44911b4b"},{"author":{"_account_id":34379,"name":"Francesco Lombardo","email":"francesco.lombardo@garr.it","username":"zvfvrv"},"change_message_id":"dbf206a910ee60101cc1ccda73f3ba1fb6181366","unresolved":true,"context_lines":[{"line_number":696,"context_line":"        endpoint \u003d _ksclient.service_catalog.url_for("},{"line_number":697,"context_line":"            service_type\u003dservice_type,"},{"line_number":698,"context_line":"            endpoint_type\u003dendpoint_type,"},{"line_number":699,"context_line":"            **filter_kwargs)"},{"line_number":700,"context_line":"    except ksexceptions.EndpointNotFound:"},{"line_number":701,"context_line":"        raise ClientException(\u0027Endpoint for %s not found - \u0027"},{"line_number":702,"context_line":"                              \u0027have you specified a region?\u0027 % service_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"83841779_0ba4738d","line":699,"in_reply_to":"c97e24bb_c0fb7cee","updated":"2021-12-19 21:05:06.000000000","message":"Looking at the parameters of the url_for function, region_name is defined as a parameter and kwarg is not really mentioned. So I think we need to explicitly add region_name among the function parameters","commit_id":"e9c786863c822d0c37f8ffab63b7d79c44911b4b"}]}