)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"12cd1e634b0e50abf90e8d0eff7dd5eb0553d1a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e16bf75b_dec58caf","updated":"2022-02-22 18:42:44.000000000","message":"Thanks for this! Much better without the monkey-patching. The swift-specific requests session also gives me some hope for being able to work around https://bugs.python.org/issue37093 at some point... I\u0027ll push up a minor edit; let me know if it still looks good to you.","commit_id":"51d19946b29aa62fc8a255bbcaaf4da95f40b0c0"},{"author":{"_account_id":34556,"name":"Aarni Koskela","email":"akx@iki.fi","username":"akx"},"change_message_id":"ed625080f552f0affdbd6aa0948334cc8b579383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"755eaa34_754c4b48","in_reply_to":"e16bf75b_dec58caf","updated":"2022-02-22 20:03:51.000000000","message":"Thank you for picking this up! :) \n\nPatchset 5 looks good to me too.","commit_id":"51d19946b29aa62fc8a255bbcaaf4da95f40b0c0"},{"author":{"_account_id":34556,"name":"Aarni Koskela","email":"akx@iki.fi","username":"akx"},"change_message_id":"3989a930e0b1612a1d97196c63bf3314520092b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8d9e1daf_7abd7248","updated":"2022-03-21 13:40:41.000000000","message":"Hi Tim (and/or others) – what are the next steps for this? I\u0027m not sure what to do with the Zuul CI failures.","commit_id":"b65e52ca14ea05fb163be03cc56ccdc73b2eb378"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"93a7c6ffc126655f1cff49f5ca91d56a76bb53ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6d33ca98_f25db195","updated":"2022-03-10 16:18:25.000000000","message":"recheck\n\nThe requirements-check job will still fail, but I can propose a fix for that. Just want to make sure everything else is ready to go.","commit_id":"b65e52ca14ea05fb163be03cc56ccdc73b2eb378"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e4a1dcdd295d9ec9bef3004d4d45a88ab4cd964c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f7144f47_9bdc7baf","updated":"2022-03-21 16:52:40.000000000","message":"Just had to rebase on top of the change to drop py2 support :-)\n\nThanks for the nudge!","commit_id":"c09621eb4269e9eaa2c5f386976f356fb0701236"}],"requirements.txt":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"12cd1e634b0e50abf90e8d0eff7dd5eb0553d1a3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"futures\u003e\u003d3.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":2,"context_line":"requests\u003e\u003d2.4.0"},{"line_number":3,"context_line":"six\u003e\u003d1.9.0"}],"source_content_type":"text/plain","patch_set":4,"id":"ce7b97cb_cb994d91","line":2,"updated":"2022-02-22 18:42:44.000000000","message":"Yeah, I\u0027m fine with this. I think the last time we considered our minimum versions was 3-4 years ago, when Trusty still had another year\u0027s worth of general support. Current state of distros:\n\n* Bionic: 2.18.4\n* Focal: 2.22.0\n* Jammy: 2.25.1\n* Centos 7: 2.6.0\n* Centos 8 Stream: 2.20.0\n* Centos 9 Stream: 2.25.1\n* Buster: 2.21.0\n\n(So really, I\u0027d be perfectly content to bring this up to 2.6.0.)","commit_id":"51d19946b29aa62fc8a255bbcaaf4da95f40b0c0"},{"author":{"_account_id":34556,"name":"Aarni Koskela","email":"akx@iki.fi","username":"akx"},"change_message_id":"ed625080f552f0affdbd6aa0948334cc8b579383","unresolved":false,"context_lines":[{"line_number":1,"context_line":"futures\u003e\u003d3.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":2,"context_line":"requests\u003e\u003d2.4.0"},{"line_number":3,"context_line":"six\u003e\u003d1.9.0"}],"source_content_type":"text/plain","patch_set":4,"id":"8cc88d6a_56918b20","line":2,"in_reply_to":"ce7b97cb_cb994d91","updated":"2022-02-22 20:03:51.000000000","message":"Downstream users will, with overwhelming likelihood, use any of those versions, yeah. This is just the most conservative version that should take into account the changes in this patch.","commit_id":"51d19946b29aa62fc8a255bbcaaf4da95f40b0c0"}],"swiftclient/client.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"12cd1e634b0e50abf90e8d0eff7dd5eb0553d1a3","unresolved":true,"context_lines":[{"line_number":1452,"context_line":"        if StrictVersion(requests.__version__) \u003c StrictVersion(\u00272.4.0\u0027):"},{"line_number":1453,"context_line":"            # python-requests sets application/x-www-form-urlencoded otherwise"},{"line_number":1454,"context_line":"            # if using python3."},{"line_number":1455,"context_line":"            headers[\u0027Content-Type\u0027] \u003d \u0027\u0027"},{"line_number":1456,"context_line":"    if not contents:"},{"line_number":1457,"context_line":"        headers[\u0027Content-Length\u0027] \u003d \u00270\u0027"},{"line_number":1458,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f352e63f_11b2874a","side":"PARENT","line":1455,"updated":"2022-02-22 18:42:44.000000000","message":"Dropping this seems to be breaking some tests -- we should just need to update the test expectations, though.","commit_id":"4989d94663b59eac34b7cd5dfaa7e673fc73e862"},{"author":{"_account_id":34556,"name":"Aarni Koskela","email":"akx@iki.fi","username":"akx"},"change_message_id":"ed625080f552f0affdbd6aa0948334cc8b579383","unresolved":false,"context_lines":[{"line_number":1452,"context_line":"        if StrictVersion(requests.__version__) \u003c StrictVersion(\u00272.4.0\u0027):"},{"line_number":1453,"context_line":"            # python-requests sets application/x-www-form-urlencoded otherwise"},{"line_number":1454,"context_line":"            # if using python3."},{"line_number":1455,"context_line":"            headers[\u0027Content-Type\u0027] \u003d \u0027\u0027"},{"line_number":1456,"context_line":"    if not contents:"},{"line_number":1457,"context_line":"        headers[\u0027Content-Length\u0027] \u003d \u00270\u0027"},{"line_number":1458,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"de032f4d_66568440","side":"PARENT","line":1455,"in_reply_to":"f352e63f_11b2874a","updated":"2022-02-22 20:03:51.000000000","message":"Ack","commit_id":"4989d94663b59eac34b7cd5dfaa7e673fc73e862"}],"swiftclient/requests_compat.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"12cd1e634b0e50abf90e8d0eff7dd5eb0553d1a3","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            json\u003drequest.json,"},{"line_number":51,"context_line":"            headers\u003dheaders,"},{"line_number":52,"context_line":"            params\u003dmerge_setting(request.params, self.params),"},{"line_number":53,"context_line":"            auth\u003drequest.auth,"},{"line_number":54,"context_line":"            cookies\u003dNone,"},{"line_number":55,"context_line":"            hooks\u003dmerge_hooks(request.hooks, self.hooks),"},{"line_number":56,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"bc101280_fcee7e72","line":53,"updated":"2022-02-22 18:42:44.000000000","message":"Not\n\n merge_setting(request.auth, self.auth)\n\n? Not that I expect it to matter...","commit_id":"51d19946b29aa62fc8a255bbcaaf4da95f40b0c0"},{"author":{"_account_id":34556,"name":"Aarni Koskela","email":"akx@iki.fi","username":"akx"},"change_message_id":"ed625080f552f0affdbd6aa0948334cc8b579383","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            json\u003drequest.json,"},{"line_number":51,"context_line":"            headers\u003dheaders,"},{"line_number":52,"context_line":"            params\u003dmerge_setting(request.params, self.params),"},{"line_number":53,"context_line":"            auth\u003drequest.auth,"},{"line_number":54,"context_line":"            cookies\u003dNone,"},{"line_number":55,"context_line":"            hooks\u003dmerge_hooks(request.hooks, self.hooks),"},{"line_number":56,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"ac827d12_275e8331","line":53,"in_reply_to":"bc101280_fcee7e72","updated":"2022-02-22 20:03:51.000000000","message":"It shouldn\u0027t matter here, since for a Swift session, authentication should be handled in a header anyway, not the requests auth mechanism.\n\nBut sure, that\u0027s fine :)","commit_id":"51d19946b29aa62fc8a255bbcaaf4da95f40b0c0"}]}