)]}'
{"swiftclient/client.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"b1e639efee204abef9a0ccce274f165cee9dc1f9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        log_method(\"RESP BODY: %s\", body)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"if six.PY2:"},{"line_number":97,"context_line":"    def quote(value, safe\u003d\u0027/\u0027):"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        Patched version of urllib.quote that encodes utf8 strings before"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9pJ0%3D","line":96,"updated":"2014-04-03 05:53:38.000000000","message":"this has the feeling of some of a reminiscent old life when doing C and had bunch of #ifdef scattered in my code. What do you think of having it inside that quote function?","commit_id":"0fe20913348a1875eb3f3a826c56e202129f4fc2"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"bcd8b11073b3a808facdfb9f088efcad4c2976ed","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        log_method(\"RESP BODY: %s\", body)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"if six.PY2:"},{"line_number":97,"context_line":"    def quote(value, safe\u003d\u0027/\u0027):"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        Patched version of urllib.quote that encodes utf8 strings before"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9ebs%3D","line":96,"in_reply_to":"AAAAWH%2F9pJ0%3D","updated":"2014-04-04 09:03:38.000000000","message":"Sometimes it\u0027s better to put it inside the function, but in this specific case I prefer to put the if outside the definition of the function. Read again the docstring of quote: \"patched version ... encodes utf8 ...\". It is no more true with Python 3. In Python 3, \"quote \u003d _quote\" directly reuses urllib.parse.quote, it\u0027s no more patched, and it doesn\u0027t encode the string anymore. urllib.parse.quote(str) returns str.","commit_id":"0fe20913348a1875eb3f3a826c56e202129f4fc2"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"ba711a72850132750e70708ebc2955f2d7375b75","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    Patched version of urllib.quote that encodes utf8 strings before quoting."},{"line_number":101,"context_line":"    On Python 3, call directly urllib.parse.quote()."},{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":"    if six.PY2:"},{"line_number":104,"context_line":"        value \u003d encode_utf8(value)"},{"line_number":105,"context_line":"        if isinstance(value, bytes):"},{"line_number":106,"context_line":"            return _quote(value, safe)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9TlA%3D","line":103,"updated":"2014-04-07 08:26:41.000000000","message":"Please consider the other way around :\n\nif six.PY3:\n   return _quote(value, safe\u003dsafe)\n\n.... and goes on...\n\ni think that fit better than a large spaggehti if","commit_id":"3ad386abdc3a8cd9fa6ff8e03822ea075b1ae934"}]}