)]}'
{"id":"openstack%2Fpython-swiftclient~84205","triplet_id":"openstack%2Fpython-swiftclient~master~Id6a31157582efe47cc3a74e6658679c2bec14767","project":"openstack/python-swiftclient","branch":"master","topic":"py3k-mock","hashtags":[],"change_id":"Id6a31157582efe47cc3a74e6658679c2bec14767","subject":"Use the standard library\u0027s copy of mock when it\u0027s available.","status":"MERGED","created":"2014-03-31 18:35:15.000000000","updated":"2014-04-05 09:46:04.000000000","submitted":"2014-04-05 09:46:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a3692337dd42dfa5d6e402eda6d7e66b85600cc7","_number":84205,"virtual_id_number":84205,"owner":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":2,"date":"2014-04-05 09:46:04.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":0,"date":"2014-04-02 16:23:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},{"value":2,"date":"2014-04-05 07:55:37.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":1,"date":"2014-04-02 08:54:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-04-02 15:51:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2014-04-02 21:04:31.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":0,"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},{"value":1,"date":"2014-04-05 07:55:37.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"date":"2014-04-02 00:52:04.000000000","_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-04-02 15:51:28.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"date":"2014-04-02 21:04:31.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-04-02 00:52:04.000000000","updated_by":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"reviewer":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"state":"REVIEWER"},{"updated":"2014-04-02 15:51:28.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2014-04-02 21:04:31.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2014-04-05 07:55:37.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2014-04-05 09:46:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a80ab9b3f4b7a863e0abcae96caf8b3af80e2341","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 18:35:15.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3e943247f8f8baf6cc402a005fe24000319f8e22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 19:41:20.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-pep8/43d16e5 : SUCCESS in 1m 03s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/05/84205/1/check/gate-python-swiftclient-docs/608f8d4/doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-swiftclient-python26 http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-python26/f090921 : SUCCESS in 1m 27s\n- gate-python-swiftclient-python27 http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-python27/55dbc70 : SUCCESS in 1m 11s\n- check-grenade-dsvm http://logs.openstack.org/05/84205/1/check/check-grenade-dsvm/7398c49 : SUCCESS in 35m 01s\n- check-tempest-dsvm-full http://logs.openstack.org/05/84205/1/check/check-tempest-dsvm-full/7da50ec : SUCCESS in 54m 16s\n- check-tempest-dsvm-neutron http://logs.openstack.org/05/84205/1/check/check-tempest-dsvm-neutron/398066b : SUCCESS in 51m 54s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/05/84205/1/check/check-tempest-dsvm-neutron-heat-slow/ebf7501 : SUCCESS in 25m 45s\n- gate-python-swiftclient-python33 http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-python33/fa1e58e : FAILURE in 3m 34s (non-voting)\n- gate-python-swiftclient-pypy http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-pypy/0bd62aa : SUCCESS in 1m 38s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/05/84205/1/check/check-swift-dsvm-functional/09a303e : SUCCESS in 13m 11s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/05/84205/1/check/check-tempest-dsvm-postgres-full/4ec6444 : SUCCESS in 1h 02m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/05/84205/1/check/gate-tempest-dsvm-large-ops/10986c1 : SUCCESS in 15m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/05/84205/1/check/gate-tempest-dsvm-neutron-large-ops/75b5e34 : SUCCESS in 15m 12s\n\n","accounts_in_message":[],"_revision_number":1},{"id":"f879db847e703f757b2e4d986c3c3502c08eda9c","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-04-02 08:54:25.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"677fb51c9c3375735884af95c63b592c3fdc3fef","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2014-04-02 15:51:28.000000000","message":"Patch Set 1:\n\npardon my ignorance, but there are no expressions in test-requirements.txt, right? So no mock\u003e\u003dN||python\u003e\u003d3.3?","accounts_in_message":[],"_revision_number":1},{"id":"0a0d7f567b803cc2594275a21e4e4a0bce7b5236","author":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"date":"2014-04-02 16:23:44.000000000","message":"Patch Set 1:\n\nUnfortunately no, so mock will still be installed on newer Python 3s, but not used.","accounts_in_message":[],"_revision_number":1},{"id":"e020a06735e2782935eb052e68fab59151f61eda","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2014-04-02 21:04:31.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a79acec916063f65e81d974255df5c315db1c491","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-04-03 08:38:36.000000000","message":"Patch Set 1:\n\n\u003e Unfortunately no, so mock will still be installed on newer Python 3s, but not used.\n\nYou may move mock from test-requirements.txt to test-requirements-py2.txt, but it would break support of Python 3.2. Debian Stable is still using Python 3.2.\n\nIt should not hurt to install an useless dependency.\n\nIf you are worried by the unneeded dependency, come to help me to integrate my change in pip:\n\nhttps://github.com/pypa/pip/pull/1472\n\nUsing my change, you can write this in test-requirements.txt:\n\n{\u0027name\u0027: \u0027mock\u0027, \u0027markers\u0027: \u0027python_version \u003c \"3.3\"\u0027} # swiftclient uses builtin unittest.mock on Python 3.3+","accounts_in_message":[],"_revision_number":1},{"id":"03344b44a2394c46ed361dd79769a8e95c7f46ff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-05 07:55:37.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a0c583b839acbdaa487b05e91321126af56113a3","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2014-04-05 07:55:37.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d71da6dbcf407509d227e8908dfc12bf890b52e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-05 08:47:27.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-pep8/8159b8a : SUCCESS in 55s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/05/84205/1/check/gate-python-swiftclient-docs/30a10ba/doc/build/html/ : SUCCESS in 56s\n- gate-python-swiftclient-python26 http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-python26/cd30f7d : SUCCESS in 59s\n- gate-python-swiftclient-python27 http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-python27/10876b3 : SUCCESS in 53s\n- check-grenade-dsvm http://logs.openstack.org/05/84205/1/check/check-grenade-dsvm/4edc4fc : SUCCESS in 37m 53s\n- check-tempest-dsvm-full http://logs.openstack.org/05/84205/1/check/check-tempest-dsvm-full/c3faca6 : SUCCESS in 51m 47s\n- check-tempest-dsvm-neutron http://logs.openstack.org/05/84205/1/check/check-tempest-dsvm-neutron/c1e2000 : SUCCESS in 47m 12s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/05/84205/1/check/check-tempest-dsvm-neutron-heat-slow/7904ba4 : SUCCESS in 20m 09s\n- gate-python-swiftclient-python33 http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-python33/127aaec : FAILURE in 3m 40s (non-voting)\n- gate-python-swiftclient-pypy http://logs.openstack.org/05/84205/1/check/gate-python-swiftclient-pypy/626db63 : SUCCESS in 1m 53s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/05/84205/1/check/check-swift-dsvm-functional/4f41d3a : SUCCESS in 11m 58s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/05/84205/1/check/check-tempest-dsvm-postgres-full/0a79350 : SUCCESS in 49m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/05/84205/1/check/gate-tempest-dsvm-large-ops/b705f8a : SUCCESS in 14m 13s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/05/84205/1/check/gate-tempest-dsvm-neutron-large-ops/e088342 : SUCCESS in 16m 31s\n\n","accounts_in_message":[],"_revision_number":1},{"id":"56f6be4e8c26eff87e62c81dadac88b34f84cbda","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-05 08:47:27.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"911e1f4a8f7623267a56151f700054167d0eb9dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-05 09:46:04.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"6ff6cd83494d51763d61857061e3bf832fa13857","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-05 09:46:04.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/05/84205/1/gate/gate-python-swiftclient-docs/cd73e7b/doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/05/84205/1/gate/gate-python-swiftclient-pep8/8a01825 : SUCCESS in 51s\n- gate-python-swiftclient-python26 http://logs.openstack.org/05/84205/1/gate/gate-python-swiftclient-python26/6901c64 : SUCCESS in 1m 02s\n- gate-python-swiftclient-python27 http://logs.openstack.org/05/84205/1/gate/gate-python-swiftclient-python27/b4a06de : SUCCESS in 55s\n- gate-grenade-dsvm http://logs.openstack.org/05/84205/1/gate/gate-grenade-dsvm/6b9e306 : SUCCESS in 37m 44s\n- gate-tempest-dsvm-full http://logs.openstack.org/05/84205/1/gate/gate-tempest-dsvm-full/a24fadc : SUCCESS in 58m 34s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/05/84205/1/gate/gate-tempest-dsvm-neutron/3dd3fba : SUCCESS in 52m 29s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/05/84205/1/gate/gate-tempest-dsvm-neutron-heat-slow/9732ebe : SUCCESS in 21m 38s\n- gate-python-swiftclient-pypy http://logs.openstack.org/05/84205/1/gate/gate-python-swiftclient-pypy/96d71ce : SUCCESS in 1m 40s (non-voting)\n- gate-swift-dsvm-functional http://logs.openstack.org/05/84205/1/gate/gate-swift-dsvm-functional/6e234b0 : SUCCESS in 11m 47s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/05/84205/1/gate/gate-tempest-dsvm-postgres-full/442d98b : SUCCESS in 56m 12s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/05/84205/1/gate/gate-tempest-dsvm-large-ops/f455767 : SUCCESS in 15m 29s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/05/84205/1/gate/gate-tempest-dsvm-neutron-large-ops/39a1a4c : SUCCESS in 16m 29s\n\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4e7bc75432d366eb32190d8a9e9582be564fbace","revisions":{"4e7bc75432d366eb32190d8a9e9582be564fbace":{"kind":"REWORK","_number":1,"created":"2014-03-31 18:35:15.000000000","uploader":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"ref":"refs/changes/05/84205/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/05/84205/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/05/84205/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/05/84205/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/05/84205/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/05/84205/1"}}},"commit":{"parents":[{"commit":"21db1bf83670f284b8f3d1dab4dc2be548ffb57e","subject":"Merge \"Python 3: Get compatible types from six\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/21db1bf83670f284b8f3d1dab4dc2be548ffb57e"}]}],"author":{"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","date":"2014-03-31 18:34:49.000000000","tz":-420},"committer":{"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","date":"2014-03-31 18:34:49.000000000","tz":-420},"subject":"Use the standard library\u0027s copy of mock when it\u0027s available.","message":"Use the standard library\u0027s copy of mock when it\u0027s available.\n\nChange-Id: Id6a31157582efe47cc3a74e6658679c2bec14767\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4e7bc75432d366eb32190d8a9e9582be564fbace"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/4e7bc75432d366eb32190d8a9e9582be564fbace"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}