)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"273beb21bdffd5cc3d2adfd590eafb74476abb55","unresolved":true,"context_lines":[{"line_number":9,"context_line":"We have seen middlewares that return ratelimit responses as 498 or 429."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The SwiftService class will now use the retry_on_ratelimit option by"},{"line_number":12,"context_line":"default."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1879572"},{"line_number":15,"context_line":"Change-Id: I027222157f6c2ad7882a0508302c9de097baae4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fdf8f6fc_b94ae7e1","line":12,"updated":"2022-08-17 20:15:11.000000000","message":"Might even be worth adding an UpgradeImpact tag here, and including a note about how to return to old behavior.","commit_id":"29324739fa5094a615a98a8d13ba37588f4d0ab4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"671f30142be8e33926ad9ad5bf3e16a35b32d926","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b561991_3ae27b56","updated":"2022-08-10 18:14:14.000000000","message":"this change should have tests and reference https://bugs.launchpad.net/python-swiftclient/+bug/1879572 in the commit message","commit_id":"57d2b69cebea5fd93c241f8e96a3c3e2d2d665d6"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"273beb21bdffd5cc3d2adfd590eafb74476abb55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc8e2c62_df6b53dd","in_reply_to":"3b561991_3ae27b56","updated":"2022-08-17 20:15:11.000000000","message":"Bug\u0027s linked now; submitted https://review.opendev.org/c/openstack/python-swiftclient/+/853538 for a test.","commit_id":"57d2b69cebea5fd93c241f8e96a3c3e2d2d665d6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7e81d90537cb9baafc39cf031d92c144ff82d68f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ed680ed3_71591b1f","updated":"2022-08-18 22:55:48.000000000","message":"429s all day long!","commit_id":"653cbcb686fc34cc28f9c7889e8746e77b95371a"}],"swiftclient/service.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"273beb21bdffd5cc3d2adfd590eafb74476abb55","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        \"auth_version\": environ.get(\u0027ST_AUTH_VERSION\u0027, \u00271.0\u0027),"},{"line_number":155,"context_line":"        \"user\": environ.get(\u0027ST_USER\u0027),"},{"line_number":156,"context_line":"        \"key\": environ.get(\u0027ST_KEY\u0027),"},{"line_number":157,"context_line":"        \"retries\": 5,"},{"line_number":158,"context_line":"        \"force_auth_retry\": False,"},{"line_number":159,"context_line":"        \"os_username\": environ.get(\u0027OS_USERNAME\u0027),"},{"line_number":160,"context_line":"        \"os_user_id\": environ.get(\u0027OS_USER_ID\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1a00f29_5e7cc829","line":157,"updated":"2022-08-17 20:15:11.000000000","message":"Should we add\n\n \"retry_on_ratelimit\": True,\n\nsomewhere around here?","commit_id":"29324739fa5094a615a98a8d13ba37588f4d0ab4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"273beb21bdffd5cc3d2adfd590eafb74476abb55","unresolved":true,"context_lines":[{"line_number":275,"context_line":"                      options[\u0027key\u0027],"},{"line_number":276,"context_line":"                      timeout\u003doptions.get(\u0027timeout\u0027),"},{"line_number":277,"context_line":"                      retry_on_ratelimit\u003doptions.get("},{"line_number":278,"context_line":"                          \u0027retry_on_ratelimit\u0027, True),"},{"line_number":279,"context_line":"                      retries\u003doptions[\u0027retries\u0027],"},{"line_number":280,"context_line":"                      auth_version\u003doptions[\u0027auth_version\u0027],"},{"line_number":281,"context_line":"                      os_options\u003doptions[\u0027os_options\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"f2824de6_7fdb8858","line":278,"updated":"2022-08-17 20:15:11.000000000","message":"Notable change in behavior. Really, we should probably have done this ages ago, though. Apparently we added support for this to the Connection class more than eight years ago! https://github.com/openstack/python-swiftclient/commit/5187fd31\n\nNot obvious to me how to test this part within the context of our existing testing :-/","commit_id":"29324739fa5094a615a98a8d13ba37588f4d0ab4"}]}