)]}'
{"swiftclient/client.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0fdfc267b58c5278a3e60c1a08475bc4098f6c70","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    # there by default and if not this would implictely be converted"},{"line_number":128,"context_line":"    # as string."},{"line_number":129,"context_line":"    if six.PY3:"},{"line_number":130,"context_line":"        return value"},{"line_number":131,"context_line":"    if isinstance(value, six.text_type):"},{"line_number":132,"context_line":"        value \u003d value.encode(\u0027utf8\u0027)"},{"line_number":133,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2Fbfc%3D","line":130,"updated":"2014-04-14 16:28:06.000000000","message":"This seems expedient, but it also makes the function do something other than what its name implies. I only see 2 calls to this function in this repository. Is this part of the public API of the client, or is it just a utility function? If it\u0027s a utility function I would modify the callers instead of changing what the function does. Alternately, you could rename the function to something like prepare_string_for_request(), but that assumes it is not part of a public API in the library.","commit_id":"a66e64348d2f894ae4231e1a0c74cf4e543b2381"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3cd7ea537249e479855a63508b185916155013ca","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        if headers is None:"},{"line_number":198,"context_line":"            headers \u003d {}"},{"line_number":199,"context_line":"        if six.PY2:"},{"line_number":200,"context_line":"            headers \u003d dict((encode_utf8(x.lower()), encode_utf8(y)) for x, y in"},{"line_number":201,"context_line":"                           headers.items())"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            headers \u003d dict((x.lower(), y) for x, y in headers.items())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FZ8o%3D","line":200,"updated":"2014-04-14 19:51:15.000000000","message":"I\u0027m not sure that encoding headers to UTF-8 is compliant with the HTTP standard:\nhttp://stackoverflow.com/questions/4400678/http-header-should-use-what-character-encoding\n\nISO- 8859-1 (utf8) should be used. If you would like to use UTF-8 (to support any Unicode character), MIME encoding should be used. Example: \"\u003d?UTF-8?Q?\u003dE2\u003d9C\u003dB0?\u003d\".\n\nBut it looks like encoding to UTF-8 works with Python 2. Maybe because all OpenStack clients use the same code base which decodes headers from UTF-8?","commit_id":"d55e807f546b9d1e96a67c600ead19bc471e3a81"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"5c2c85aa702b4159f1d0c5bb80b4e81f14abbf2a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            headers \u003d dict((encode_utf8(x.lower()), encode_utf8(y)) for x, y in"},{"line_number":201,"context_line":"                           headers.items())"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            headers \u003d dict((x.lower(), y) for x, y in headers.items())"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # set a default User-Agent header if it wasn\u0027t passed in"},{"line_number":206,"context_line":"        if \u0027user-agent\u0027 not in headers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FZ0Q%3D","line":203,"updated":"2014-04-14 20:13:04.000000000","message":"Which encoding is used on Python 3? Latin1 or UTF-8?","commit_id":"d55e807f546b9d1e96a67c600ead19bc471e3a81"}]}