)]}'
{"swiftclient/service.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f5d3342722704844dcf505407148ce4960e378f7","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        return str(self)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def process_options(options):"},{"line_number":93,"context_line":"    if options.get(\u0027os_auth_type\u0027) \u003d\u003d \u0027v1password\u0027:"},{"line_number":94,"context_line":"        options[\u0027auth_version\u0027] \u003d \u00271.0\u0027"},{"line_number":95,"context_line":"    elif options.get(\u0027os_auth_type\u0027) \u003d\u003d \u0027v2password\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e4c2cb2_fbacb499","line":92,"updated":"2023-03-22 16:19:05.000000000","message":"Ugh, I kinda hate this function. There\u0027s just *so much* swapping things around on callers in ways that aren\u0027t necessarily obvious...","commit_id":"41e70c506c94a2de9d802179620d47b749e3d508"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f5d3342722704844dcf505407148ce4960e378f7","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        options[\u0027auth_version\u0027] \u003d \u00272.0\u0027"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if options.get(\u0027auth_version\u0027) not in (\u00272.0\u0027, \u00273\u0027) and \\"},{"line_number":107,"context_line":"            options.get(\u0027os_auth_type\u0027) !\u003d \u0027v1password\u0027 and \\"},{"line_number":108,"context_line":"            not all(options.get(key) for key in (\u0027auth\u0027, \u0027user\u0027, \u0027key\u0027)):"},{"line_number":109,"context_line":"        # Use keystone auth if any of the new-style args are present"},{"line_number":110,"context_line":"        if any(options.get(k) for k in ("}],"source_content_type":"text/x-python","patch_set":2,"id":"6e362e28_8c551c91","line":107,"updated":"2023-03-22 16:19:05.000000000","message":"I wonder if the better/more-obvious-for-callers thing would be to have something like\n\n    if options.get(\u0027auth_version\u0027) is None:\n        if any(options.get(k) for k in (\n                \u0027os_user_domain_id\u0027,\n                \u0027os_user_domain_name\u0027,\n                \u0027os_project_domain_id\u0027,\n                \u0027os_project_domain_name\u0027)):\n            # Use v3 if there\u0027s any reference to domains\n            options[\u0027auth_version\u0027] \u003d \u00273\u0027\n        elif not all(options.get(key) for key in (\u0027auth\u0027, \u0027user\u0027, \u0027key\u0027)):\n            options[\u0027auth_version\u0027] \u003d \u00272.0\u0027\n        else:\n            options[\u0027auth_version\u0027] \u003d \u00271.0\u0027\n\nand stop defaulting in 1.0 for auth_version, wherever that\u0027s coming in.","commit_id":"41e70c506c94a2de9d802179620d47b749e3d508"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5c7fc6ee1e4f7352754cf5d28dc6818f59fe1846","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        options[\u0027auth_version\u0027] \u003d \u00272.0\u0027"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if options.get(\u0027auth_version\u0027) not in (\u00272.0\u0027, \u00273\u0027) and \\"},{"line_number":107,"context_line":"            options.get(\u0027os_auth_type\u0027) !\u003d \u0027v1password\u0027 and \\"},{"line_number":108,"context_line":"            not all(options.get(key) for key in (\u0027auth\u0027, \u0027user\u0027, \u0027key\u0027)):"},{"line_number":109,"context_line":"        # Use keystone auth if any of the new-style args are present"},{"line_number":110,"context_line":"        if any(options.get(k) for k in ("}],"source_content_type":"text/x-python","patch_set":2,"id":"d43b3615_eba03baa","line":107,"in_reply_to":"6e362e28_8c551c91","updated":"2023-03-24 15:37:17.000000000","message":"Done in https://review.opendev.org/c/openstack/python-swiftclient/+/878503/","commit_id":"41e70c506c94a2de9d802179620d47b749e3d508"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f5d3342722704844dcf505407148ce4960e378f7","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            options[\u0027auth_version\u0027] \u003d \u00272.0\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    if options.get(\u0027os_auth_type\u0027, None) \u003d\u003d \u0027v3applicationcredential\u0027:"},{"line_number":121,"context_line":"        options[\u0027auth_version\u0027] \u003d\u003d \u00273\u0027"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Use new-style args if old ones not present"},{"line_number":124,"context_line":"    if not options[\u0027auth\u0027] and options[\u0027os_auth_url\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1938f7de_96168e2f","line":121,"updated":"2023-03-22 16:19:05.000000000","message":"This should probably scoot up to be with the other `os_auth_type` -\u003e `auth_version` mappings.","commit_id":"41e70c506c94a2de9d802179620d47b749e3d508"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5c7fc6ee1e4f7352754cf5d28dc6818f59fe1846","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            options[\u0027auth_version\u0027] \u003d \u00272.0\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    if options.get(\u0027os_auth_type\u0027, None) \u003d\u003d \u0027v3applicationcredential\u0027:"},{"line_number":121,"context_line":"        options[\u0027auth_version\u0027] \u003d\u003d \u00273\u0027"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Use new-style args if old ones not present"},{"line_number":124,"context_line":"    if not options[\u0027auth\u0027] and options[\u0027os_auth_url\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a937092_7d16a1eb","line":121,"in_reply_to":"1938f7de_96168e2f","updated":"2023-03-24 15:37:17.000000000","message":"Done","commit_id":"41e70c506c94a2de9d802179620d47b749e3d508"}]}