)]}'
{"tests/test_shell.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"da53d55b82049a0ad732054e5891418c400edc56","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                 mock.call(\u0027           0\u0027)]"},{"line_number":173,"context_line":"        mock_print.assert_has_calls(calls)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @mock.patch(BUILTIN_OPEN, mock.MagicMock())"},{"line_number":176,"context_line":"    @mock.patch(\u0027swiftclient.shell.Connection\u0027)"},{"line_number":177,"context_line":"    def test_download(self, connection):"},{"line_number":178,"context_line":"        connection.return_value.get_object.return_value \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FEYM%3D","line":175,"updated":"2014-04-24 09:00:04.000000000","message":"I am not totally sure why mocking BUILTIN_OPEN is needed since the tests are passing without it, will ping cshweede to see why we need that","commit_id":"fe80349bee06fddadb4bfa0e82d88eb4bc9818f2"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"80732110df9533be72e1a75130175ba574a625dd","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                 mock.call(\u0027           0\u0027)]"},{"line_number":173,"context_line":"        mock_print.assert_has_calls(calls)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @mock.patch(BUILTIN_OPEN, mock.MagicMock())"},{"line_number":176,"context_line":"    @mock.patch(\u0027swiftclient.shell.Connection\u0027)"},{"line_number":177,"context_line":"    def test_download(self, connection):"},{"line_number":178,"context_line":"        connection.return_value.get_object.return_value \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F8BM%3D","line":175,"in_reply_to":"AAAAXH%2F%2FEYM%3D","updated":"2014-04-25 07:32:28.000000000","message":"The mocking is not really required; but if open() is not mocked there will be a file called \"object\" in the directory where the tests where started from. The idea was simply to avoid polluting the local filesystem.\n\nMight be worth to add a\n\n mock_open.assert_called_with(\u0027object\u0027, \u0027wb\u0027)\n\ninstead of using mock.MagickMock() ?","commit_id":"fe80349bee06fddadb4bfa0e82d88eb4bc9818f2"}]}