)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2d0de3093e1ac3a8b5008db8a31b7929dde446d0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The entry_point option already defines the /bin/swift script implicitly."},{"line_number":10,"context_line":"The definition of `scripts\u003dbin/swift` ontop of that leads to a corrupt wheel build and can lead to a collision error during installation:"},{"line_number":11,"context_line":"FileExistsError: File already exists: [...]/bin/swift"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I17d0c2b02555172eeedaa164aad956691ccb3b0a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4e8e5ce8_56e00bb1","line":12,"updated":"2024-01-11 11:18:42.000000000","message":"please add \n\n```\nCloses-Bug: #1996959\n```","commit_id":"67a37c48cf2d7fa99fc756366094d8f59063e670"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2d0de3093e1ac3a8b5008db8a31b7929dde446d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5acb9b2_2d78245e","updated":"2024-01-11 11:18:42.000000000","message":"LGTM but should reference the bug","commit_id":"67a37c48cf2d7fa99fc756366094d8f59063e670"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"075dd3762cc8745fd5a1729ec9648abfcfcea8c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d649f3ea_e290d859","updated":"2024-01-03 18:33:13.000000000","message":"This seems to close bug #1996959 -- but I like this approach more than https://review.opendev.org/c/openstack/python-swiftclient/+/864965\n\nMy only concern is that it may not go *far enough* -- what do you think about dropping the `bin/swift` script entirely?\n\nI wonder whether [`0a5a88b9`](https://github.com/openstack/python-swiftclient/commit/0a5a88b9e6ee8b9e289dd221a2760114e40e7048) was always misguided, and we should only ever have had the `entry_point` -- we wound up adding it back just a few months later in [`cb059f2f`](https://github.com/openstack/python-swiftclient/commit/cb059f2f3ea821ead1ab2a93077dd40d86aa57d2)","commit_id":"67a37c48cf2d7fa99fc756366094d8f59063e670"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"185306bea9f59c81917b65a3c871d1fcca0b42d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e8082c59_6df11b16","updated":"2024-01-11 22:29:37.000000000","message":"I\u0027m okay with it. I can always run \"python setup.py build\", right?","commit_id":"45a311fc621324742f6d981a94ab93a3b30422e1"}],"setup.cfg":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"075dd3762cc8745fd5a1729ec9648abfcfcea8c3","unresolved":true,"context_lines":[{"line_number":35,"context_line":"packages \u003d"},{"line_number":36,"context_line":"    swiftclient"},{"line_number":37,"context_line":"scripts \u003d"},{"line_number":38,"context_line":"    bin/swift"},{"line_number":39,"context_line":"data_files \u003d"},{"line_number":40,"context_line":"    share/man/man1 \u003d doc/manpages/swift.1"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"83bc61d9_b976a4d9","side":"PARENT","line":38,"updated":"2024-01-03 18:33:13.000000000","message":"Should we just delete this file? Seems silly to hold on to that little shim.\n\nOTOH, I suppose some users might expect to be able to just clone and use it... but presumably they could switch to running something like `python -m swiftclient.shell ...` instead?","commit_id":"7e65d10199be3214f5c7adf66a041fb7264eb07d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2d0de3093e1ac3a8b5008db8a31b7929dde446d0","unresolved":true,"context_lines":[{"line_number":35,"context_line":"packages \u003d"},{"line_number":36,"context_line":"    swiftclient"},{"line_number":37,"context_line":"scripts \u003d"},{"line_number":38,"context_line":"    bin/swift"},{"line_number":39,"context_line":"data_files \u003d"},{"line_number":40,"context_line":"    share/man/man1 \u003d doc/manpages/swift.1"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"115d634f_7203336a","side":"PARENT","line":38,"in_reply_to":"83bc61d9_b976a4d9","updated":"2024-01-11 11:18:42.000000000","message":"We could, but it IMHO that doesn\u0027t need to prevent this patch merging","commit_id":"7e65d10199be3214f5c7adf66a041fb7264eb07d"}]}