)]}'
{"swiftclient/client.py":[{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"823a9d98f6885079c0e2267de80b7c426deb3d9b","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        if kwargs.get(\u0027tenant_name\u0027):"},{"line_number":360,"context_line":"            os_options[\u0027tenant_name\u0027] \u003d kwargs[\u0027tenant_name\u0027]"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if not (\u0027tenant_name\u0027 in os_options or \u0027tenant_id\u0027 in os_options):"},{"line_number":363,"context_line":"            raise ClientException(\u0027No tenant specified\u0027)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        cacert \u003d kwargs.get(\u0027cacert\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_44ba82c1","line":362,"updated":"2014-05-20 16:53:39.000000000","message":"This might be better as:\n\n    if not (os_options.get(\u0027tenant_name\u0027) or os_options.get(\u0027tenant_id\u0027)):\n\nReason: I think bin/swift sets os_options.get(\u0027tenant_name\u0027) to None if not specified by OS_TENANT_NAME. So the \"not in\" check is not sufficient; also need to check that is has a value","commit_id":"1df56981ddc7bf555e727541a03ac4e36a72d8f9"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cbf4738a0f87129e4f63863d1b8fc82fe53df01b","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        if kwargs.get(\u0027tenant_name\u0027):"},{"line_number":360,"context_line":"            os_options[\u0027tenant_name\u0027] \u003d kwargs[\u0027tenant_name\u0027]"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if not (\u0027tenant_name\u0027 in os_options or \u0027tenant_id\u0027 in os_options):"},{"line_number":363,"context_line":"            raise ClientException(\u0027No tenant specified\u0027)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        cacert \u003d kwargs.get(\u0027cacert\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_13b51e31","line":362,"in_reply_to":"7adec928_44ba82c1","updated":"2014-05-20 19:55:28.000000000","message":"Done","commit_id":"1df56981ddc7bf555e727541a03ac4e36a72d8f9"}],"tests/unit/test_swiftclient.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"d2ef2ddfb2a99f12c62a5c8d684c88630758f5d0","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        self.assertTrue(url.startswith(\"http\"))"},{"line_number":304,"context_line":"        self.assertTrue(token)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def test_auth_v2_no_tenant_name(self):"},{"line_number":307,"context_line":"        c.get_keystoneclient_2_0 \u003d fake_get_keystoneclient_2_0({})"},{"line_number":308,"context_line":"        self.assertRaises(c.ClientException, c.get_auth,"},{"line_number":309,"context_line":"                          \u0027http://www.tests.com\u0027, \u0027asdf\u0027, \u0027asdf\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_d5ef29e7","line":306,"updated":"2014-05-20 12:44:31.000000000","message":"(nit) you may want to rename this test then to something :\n\n    def test_auth_v2_no_tenant_name_or_tenant_id(self):","commit_id":"791ee7a6e9b9ddc828e769bb22ef3e4a237d5987"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"84c232c592d4f55cfecfda25d7d72da06fc05c5b","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        self.assertTrue(url.startswith(\"http\"))"},{"line_number":304,"context_line":"        self.assertTrue(token)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def test_auth_v2_no_tenant_name(self):"},{"line_number":307,"context_line":"        c.get_keystoneclient_2_0 \u003d fake_get_keystoneclient_2_0({})"},{"line_number":308,"context_line":"        self.assertRaises(c.ClientException, c.get_auth,"},{"line_number":309,"context_line":"                          \u0027http://www.tests.com\u0027, \u0027asdf\u0027, \u0027asdf\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_588270c8","line":306,"in_reply_to":"7adec928_d5ef29e7","updated":"2014-05-20 13:43:41.000000000","message":"Done","commit_id":"791ee7a6e9b9ddc828e769bb22ef3e4a237d5987"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"a732c44ce0379968064c36605a4241da846ded6c","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                          \u0027asdf\u0027, \u0027asdf\u0027,"},{"line_number":286,"context_line":"                          auth_version\u003d\u00271.0\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def test_auth_v2(self):"},{"line_number":289,"context_line":"        os_options \u003d {\u0027tenant_name\u0027: \u0027asdf\u0027}"},{"line_number":290,"context_line":"        c.get_keystoneclient_2_0 \u003d fake_get_keystoneclient_2_0(os_options)"},{"line_number":291,"context_line":"        url, token \u003d c.get_auth(\u0027http://www.test.com\u0027, \u0027asdf\u0027, \u0027asdf\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_dec66568","line":288,"updated":"2014-05-20 16:00:36.000000000","message":"I should have mention earlier in my review that this test now is called test_auth_v2_with_tenant_name but i\u0027m sure people can just figure out this by reading the code :) sorry for nitpicking you don\u0027t have to upload a new patchset for that","commit_id":"1df56981ddc7bf555e727541a03ac4e36a72d8f9"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cbf4738a0f87129e4f63863d1b8fc82fe53df01b","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                          \u0027asdf\u0027, \u0027asdf\u0027,"},{"line_number":286,"context_line":"                          auth_version\u003d\u00271.0\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def test_auth_v2(self):"},{"line_number":289,"context_line":"        os_options \u003d {\u0027tenant_name\u0027: \u0027asdf\u0027}"},{"line_number":290,"context_line":"        c.get_keystoneclient_2_0 \u003d fake_get_keystoneclient_2_0(os_options)"},{"line_number":291,"context_line":"        url, token \u003d c.get_auth(\u0027http://www.test.com\u0027, \u0027asdf\u0027, \u0027asdf\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_5386c666","line":288,"in_reply_to":"7adec928_dec66568","updated":"2014-05-20 19:55:28.000000000","message":"Done","commit_id":"1df56981ddc7bf555e727541a03ac4e36a72d8f9"}]}