)]}'
{"id":"openstack%2Fpython-swiftclient~94920","triplet_id":"openstack%2Fpython-swiftclient~master~I7cc1bd60d9ba82d1a28fbae2e1243d3c799451bd","project":"openstack/python-swiftclient","branch":"master","topic":"p-fix-unit-tests","hashtags":[],"change_id":"I7cc1bd60d9ba82d1a28fbae2e1243d3c799451bd","subject":"Fix wrong assertions in unit tests","status":"MERGED","created":"2014-05-22 16:09:16.000000000","updated":"2014-05-23 23:42:55.000000000","submitted":"2014-05-23 23:42:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"71c72e4c98126dead6fdd37219df83d7e49f39cc","_number":94920,"virtual_id_number":94920,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},{"value":2,"date":"2014-05-23 23:42:55.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"recommended":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"all":[{"value":1,"date":"2014-05-22 16:10:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-05-22 19:20:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":2,"date":"2014-05-23 20:02:01.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"all":[{"value":0,"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"value":1,"date":"2014-05-23 20:02:01.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-05-22 16:10:08.000000000","updated_by":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"reviewer":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"state":"REVIEWER"},{"updated":"2014-05-22 19:20:23.000000000","updated_by":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"reviewer":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"state":"REVIEWER"},{"updated":"2014-05-23 20:02:01.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2014-05-23 23:42:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6b49607321267ccf62e4a2b20ebb1ffac7854904","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2014-05-22 16:09:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"52f42d3142c48bd019aee8d73cbde2e6ded4f6b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-22 16:09:17.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"22cd92aaeede17fb3a43c71f6218393005d3197d","author":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"date":"2014-05-22 16:10:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6da2fa10e7b880ef3d00e3247e23a2521a0a65e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-22 17:17:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-pep8/bcac903 : SUCCESS in 1m 05s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/20/94920/1/check/gate-python-swiftclient-docs/3e4fe00/doc/build/html/ : SUCCESS in 1m 18s\n- gate-python-swiftclient-python26 http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-python26/8ae8c8d : SUCCESS in 1m 08s\n- gate-python-swiftclient-python27 http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-python27/725b43f : SUCCESS in 2m 03s\n- check-tempest-dsvm-full http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-full/7cd6316 : SUCCESS in 1h 02m 36s\n- check-tempest-dsvm-neutron http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-neutron/6fd9b90 : SUCCESS in 51m 46s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-neutron-heat-slow/8aa1945 : SUCCESS in 20m 48s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/20/94920/1/check/check-grenade-dsvm/9e22cb6 : SUCCESS in 39m 26s\n- check-grenade-dsvm-neutron http://logs.openstack.org/20/94920/1/check/check-grenade-dsvm-neutron/638402d : FAILURE in 50m 47s (non-voting)\n- check-tempest-dsvm-full-havana http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-full-havana/74de0e5 : SUCCESS in 33m 14s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-neutron-havana/eb49abd : SUCCESS in 32m 18s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-full-icehouse/04477ff : SUCCESS in 52m 51s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-neutron-icehouse/39c05db : SUCCESS in 57m 09s\n- gate-python-swiftclient-python33 http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-python33/fb5dadb : SUCCESS in 4m 53s\n- gate-python-swiftclient-pypy http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-pypy/2a5df9c : SUCCESS in 2m 03s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/20/94920/1/check/check-swift-dsvm-functional/6fc7bb4 : SUCCESS in 12m 40s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-postgres-full/8920821 : SUCCESS in 57m 08s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/20/94920/1/check/gate-tempest-dsvm-large-ops/76fadbb : SUCCESS in 18m 42s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/20/94920/1/check/gate-tempest-dsvm-neutron-large-ops/e67bc50 : SUCCESS in 20m 06s","accounts_in_message":[],"_revision_number":1},{"id":"ae529ea14079903149947e82dd07719b97b39173","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2014-05-22 19:20:23.000000000","message":"Patch Set 1: Code-Review+2\n\nGood spot!","accounts_in_message":[],"_revision_number":1},{"id":"7d9c8c66cb81788a27fccda78a4773cfbc281096","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2014-05-23 20:02:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nHuh. I\u0027m curious how those snuck in there in the first place, but the new assertions are pretty obviously correct.\n\n(Did assert_() have some DWIM stuff in it based on the number of args it was given?)","accounts_in_message":[],"_revision_number":1},{"id":"391b6edca0fe234cc6d12b0e491c54b7cc632c44","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-23 20:02:02.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"7d43bd8843508c52079d46d4db6d2a7c5bc8de78","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-23 21:11:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-swiftclient-pep8 http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-pep8/0efaf87 : SUCCESS in 51s\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/20/94920/1/check/gate-python-swiftclient-docs/c21e62c/doc/build/html/ : SUCCESS in 41s\n- gate-python-swiftclient-python26 http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-python26/274e9f6 : SUCCESS in 34s\n- gate-python-swiftclient-python27 http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-python27/8b285f0 : SUCCESS in 58s\n- check-tempest-dsvm-full http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-full/39ecb81 : SUCCESS in 42m 16s\n- check-tempest-dsvm-neutron http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-neutron/e5345cd : SUCCESS in 54m 40s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-neutron-heat-slow/3129364 : SUCCESS in 16m 24s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/20/94920/1/check/check-grenade-dsvm/821624a : SUCCESS in 38m 52s\n- check-grenade-dsvm-neutron http://logs.openstack.org/20/94920/1/check/check-grenade-dsvm-neutron/709a930 : FAILURE in 42m 55s (non-voting)\n- check-tempest-dsvm-full-havana http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-full-havana/55a3a04 : SUCCESS in 30m 53s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-neutron-havana/cb0c1c7 : SUCCESS in 33m 23s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-full-icehouse/0e58c01 : SUCCESS in 1h 09m 51s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-neutron-icehouse/0b3721e : SUCCESS in 1h 00m 33s\n- gate-python-swiftclient-python33 http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-python33/30de0d3 : SUCCESS in 3m 02s\n- gate-python-swiftclient-pypy http://logs.openstack.org/20/94920/1/check/gate-python-swiftclient-pypy/3bb980f : SUCCESS in 1m 45s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/20/94920/1/check/check-swift-dsvm-functional/cc9babb : SUCCESS in 14m 30s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/20/94920/1/check/check-tempest-dsvm-postgres-full/898c949 : SUCCESS in 59m 26s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/20/94920/1/check/gate-tempest-dsvm-large-ops/64a02d1 : SUCCESS in 21m 02s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/20/94920/1/check/gate-tempest-dsvm-neutron-large-ops/4d8019c : SUCCESS in 20m 46s","accounts_in_message":[],"_revision_number":1},{"id":"adef75f2b18c8e8e2654fb68a79e7a46760cb811","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-23 21:11:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f3c09b6944a593593649789527790c836f8ec60f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-23 21:55:40.000000000","message":"Patch Set 1:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"9d7fb4f90f94e916df5a17342772b696c05b4514","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-23 23:42:55.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"728aacc04b963385c2c738d54063a9c0f66ae99a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-23 23:42:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded.\n\n- gate-python-swiftclient-docs http://docs-draft.openstack.org/20/94920/1/gate/gate-python-swiftclient-docs/a9a24e1/doc/build/html/ : SUCCESS in 1m 25s\n- gate-python-swiftclient-pep8 http://logs.openstack.org/20/94920/1/gate/gate-python-swiftclient-pep8/3901197 : SUCCESS in 1m 02s\n- gate-python-swiftclient-python26 http://logs.openstack.org/20/94920/1/gate/gate-python-swiftclient-python26/438c236 : SUCCESS in 37s\n- gate-python-swiftclient-python27 http://logs.openstack.org/20/94920/1/gate/gate-python-swiftclient-python27/8ab8de2 : SUCCESS in 1m 11s\n- gate-tempest-dsvm-full http://logs.openstack.org/20/94920/1/gate/gate-tempest-dsvm-full/db8e219 : SUCCESS in 58m 18s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/20/94920/1/gate/gate-tempest-dsvm-neutron/4e18b62 : SUCCESS in 58m 05s\n- gate-grenade-dsvm http://logs.openstack.org/20/94920/1/gate/gate-grenade-dsvm/c69371f : SUCCESS in 40m 37s\n- gate-python-swiftclient-python33 http://logs.openstack.org/20/94920/1/gate/gate-python-swiftclient-python33/ae196af : SUCCESS in 3m 40s\n- gate-python-swiftclient-pypy http://logs.openstack.org/20/94920/1/gate/gate-python-swiftclient-pypy/600268b : SUCCESS in 3m 35s (non-voting)\n- gate-swift-dsvm-functional http://logs.openstack.org/20/94920/1/gate/gate-swift-dsvm-functional/b75db40 : SUCCESS in 14m 39s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/20/94920/1/gate/gate-tempest-dsvm-postgres-full/b40a9a2 : SUCCESS in 53m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/20/94920/1/gate/gate-tempest-dsvm-large-ops/eee246c : SUCCESS in 18m 54s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/20/94920/1/gate/gate-tempest-dsvm-neutron-large-ops/bdcab25 : SUCCESS in 19m 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"eaf4fcbb8d00e9e974c9408e550154fa3cfeefea","revisions":{"eaf4fcbb8d00e9e974c9408e550154fa3cfeefea":{"kind":"REWORK","_number":1,"created":"2014-05-22 16:09:16.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/20/94920/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-swiftclient","ref":"refs/changes/20/94920/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/20/94920/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/20/94920/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-swiftclient refs/changes/20/94920/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-swiftclient refs/changes/20/94920/1"}}},"commit":{"parents":[{"commit":"258420f41049d92fc0b59b9263c8381bfe513432","subject":"Fix Python3 bugs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/258420f41049d92fc0b59b9263c8381bfe513432"}]}],"author":{"name":"anc","email":"alistair.coles@hp.com","date":"2014-05-22 15:56:31.000000000","tz":60},"committer":{"name":"anc","email":"alistair.coles@hp.com","date":"2014-05-22 15:56:31.000000000","tz":60},"subject":"Fix wrong assertions in unit tests","message":"Fix wrong assertions in unit tests\n\nA couple of assertTrue in the test_swiftclient.py\nunit tests should be assertEqual. Also, the expected\nvalues now need to be bytes literals.\n\nChange-Id: I7cc1bd60d9ba82d1a28fbae2e1243d3c799451bd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/eaf4fcbb8d00e9e974c9408e550154fa3cfeefea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-swiftclient/commit/eaf4fcbb8d00e9e974c9408e550154fa3cfeefea"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}