)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"0c644178e99cbd51c2036526faed570a11483586","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bob HADDLETON \u003cbob.haddleton@alcatel-lucent.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-10 10:23:22 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Multiple command line changes:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * Name is now a required positional argument for both vnf-create"},{"line_number":10,"context_line":"   and vnfd-create"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_84c63a66","line":7,"updated":"2015-08-12 23:07:36.000000000","message":"Can you provide a bit more specific commit headline, like \"Remove inconsistent CLI parameter options\"","commit_id":"2417863496533485e192e24000b4bf65a3694add"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"0c644178e99cbd51c2036526faed570a11483586","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Multiple command line changes:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * Name is now a required positional argument for both vnf-create"},{"line_number":10,"context_line":"   and vnfd-create"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" * vnfd-create now requires the --vnfd-file option and the --vnfd"},{"line_number":13,"context_line":"   option has been deleted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_e46ffe8f","line":10,"updated":"2015-08-12 23:07:36.000000000","message":"Does \u0027name\u0027 has to be positional ? It seems to make CLI a bit brittle. Is it possible to just make it mandatory but not positional ?","commit_id":"2417863496533485e192e24000b4bf65a3694add"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"0c644178e99cbd51c2036526faed570a11483586","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   both, which was broken anyway"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":" * The vnf-create and vnf-show output has been cleaned up by replacing"},{"line_number":19,"context_line":"   the \"attributes\" value with the content of the attributes dictionary"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I35ab6700bf1565ce6fc95aec40889eef45c4bf10"},{"line_number":22,"context_line":"Closes-Bug: 1474966"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_a4ea56d6","line":19,"updated":"2015-08-12 23:07:36.000000000","message":"This part doesn\u0027t belong to this bug fix. Do you mind spinning a separate patchset? I know it is an hassle but lets resist clubbing changes that is out of scope of a given patchset.","commit_id":"2417863496533485e192e24000b4bf65a3694add"}],"tackerclient/tacker/v1_0/vm/vnf.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"bd2a5a128d4b34bd247a0634d999e41a4c7573cf","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":48,"context_line":"        parser.add_argument("},{"line_number":49,"context_line":"            \u0027name\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Set a name for the vnf\u0027)"},{"line_number":51,"context_line":"        group \u003d parser.add_mutually_exclusive_group(required\u003dTrue)"},{"line_number":52,"context_line":"        group.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_a6880972","line":49,"updated":"2015-11-12 09:17:15.000000000","message":"It will break the back compatibility.","commit_id":"5a7caab5dff79304a8a3e493d485e3f76263dc37"},{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"68d4097a5dcd7bc52368c492bf6937b0f6808654","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":48,"context_line":"        parser.add_argument("},{"line_number":49,"context_line":"            \u0027name\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Set a name for the vnf\u0027)"},{"line_number":51,"context_line":"        group \u003d parser.add_mutually_exclusive_group(required\u003dTrue)"},{"line_number":52,"context_line":"        group.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_ff23c1a5","line":49,"in_reply_to":"da85f559_044f8d37","updated":"2015-11-13 02:30:57.000000000","message":"Exactly.  Many openstack CLI create commands take a positional name argument.  We use heat as a reference model for the tacker commands, and this matches the heat stack-create format.","commit_id":"5a7caab5dff79304a8a3e493d485e3f76263dc37"},{"author":{"_account_id":18401,"name":"Luka Krajger","email":"luka.krajger@gmail.com","username":"KLuka"},"change_message_id":"4e2ac9ca083e6e3098132bdf6da36d9438945a1f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":48,"context_line":"        parser.add_argument("},{"line_number":49,"context_line":"            \u0027name\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Set a name for the vnf\u0027)"},{"line_number":51,"context_line":"        group \u003d parser.add_mutually_exclusive_group(required\u003dTrue)"},{"line_number":52,"context_line":"        group.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_044f8d37","line":49,"in_reply_to":"da85f559_a6880972","updated":"2015-11-12 09:57:45.000000000","message":"IMO, similarity/compatibility with other openstack clients is more important. Also Tacker is still in early phase so I presume that backwards compatibility is not a priority.","commit_id":"5a7caab5dff79304a8a3e493d485e3f76263dc37"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"bd2a5a128d4b34bd247a0634d999e41a4c7573cf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            help\u003d\u0027specify config yaml file\u0027)"},{"line_number":62,"context_line":"        cfggroup.add_argument("},{"line_number":63,"context_line":"            \u0027--config\u0027,"},{"line_number":64,"context_line":"            help\u003d\u0027specify config yaml file\u0027)"},{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--param-file\u0027,"},{"line_number":67,"context_line":"            help\u003d\u0027specify parameter yaml file\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_6670e1a4","line":64,"updated":"2015-11-12 09:17:15.000000000","message":"change it into \u0027config content in the format of yaml\u0027?","commit_id":"5a7caab5dff79304a8a3e493d485e3f76263dc37"},{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"68d4097a5dcd7bc52368c492bf6937b0f6808654","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            help\u003d\u0027specify config yaml file\u0027)"},{"line_number":62,"context_line":"        cfggroup.add_argument("},{"line_number":63,"context_line":"            \u0027--config\u0027,"},{"line_number":64,"context_line":"            help\u003d\u0027specify config yaml file\u0027)"},{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--param-file\u0027,"},{"line_number":67,"context_line":"            help\u003d\u0027specify parameter yaml file\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_7f47d14b","line":64,"in_reply_to":"da85f559_6670e1a4","updated":"2015-11-13 02:30:57.000000000","message":"Good point - I\u0027ll reword it.","commit_id":"5a7caab5dff79304a8a3e493d485e3f76263dc37"},{"author":{"_account_id":18401,"name":"Luka Krajger","email":"luka.krajger@gmail.com","username":"KLuka"},"change_message_id":"97e5546e03116ec7cf7ee4e6256025d7e55364f4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--param-file\u0027,"},{"line_number":67,"context_line":"            help\u003d\u0027specify parameter yaml file\u0027"},{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def args2body(self, parsed_args):"},{"line_number":71,"context_line":"        body \u003d {self.resource: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_8eceb3b2","line":68,"updated":"2015-11-10 09:46:10.000000000","message":"1. I would move the closing bracket in the same line as help arg.\n\n2. Is the \"--param-file\" same as config file or am I missing something?","commit_id":"5a7caab5dff79304a8a3e493d485e3f76263dc37"},{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"68d4097a5dcd7bc52368c492bf6937b0f6808654","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--param-file\u0027,"},{"line_number":67,"context_line":"            help\u003d\u0027specify parameter yaml file\u0027"},{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def args2body(self, parsed_args):"},{"line_number":71,"context_line":"        body \u003d {self.resource: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_bf10da5a","line":68,"in_reply_to":"da85f559_8eceb3b2","updated":"2015-11-13 02:30:57.000000000","message":"This is existing code not related to my change, so I would rather leave it as-is.\n\nParameters are applied to the inputs specified in the template file.  Config values are applied to the running VNF application.","commit_id":"5a7caab5dff79304a8a3e493d485e3f76263dc37"}],"tackerclient/tacker/v1_0/vm/vnfd.py":[{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"b77acf226615955d76e6cb856445318c7bc3e4b2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if parsed_args.vnfd_file:"},{"line_number":62,"context_line":"            with open(parsed_args.vnfd_file) as f:"},{"line_number":63,"context_line":"                vnfd \u003d f.read()"},{"line_number":64,"context_line":"        if parsed_args.vnfd:"},{"line_number":65,"context_line":"            vnfd \u003d parsed_args.vnfd"},{"line_number":66,"context_line":"        body[self.resource][\u0027vnfd\u0027] \u003d vnfd"},{"line_number":67,"context_line":"        tackerV10.update_dict(parsed_args, body[self.resource],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_6d963d96","line":64,"updated":"2015-09-12 19:13:17.000000000","message":"We have to remove this validation, as we don\u0027t have vnfd argument now","commit_id":"2417863496533485e192e24000b4bf65a3694add"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"52f5965cc190558d40b82051384fcc97543d779a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        group.add_argument(\u0027--vnfd-file\u0027, help\u003d\u0027specify vnfd file\u0027)"},{"line_number":55,"context_line":"        group.add_argument(\u0027--vnfd\u0027, help\u003d\u0027specify vnfd\u0027)"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027name\u0027,"},{"line_number":58,"context_line":"            help\u003d\u0027Set a name for the vnfd\u0027)"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_3f1ce976","line":57,"updated":"2015-11-13 03:06:27.000000000","message":"move this after the optional arg please.","commit_id":"aac14f861eb5045cc8835a44ff7fd9250de5c412"}]}