)]}'
{"tackerclient/tacker/v1_0/nfvo/vim_utils.py":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"d2c543aee4455e672eeaeac32ca3d27d56230868","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    vim[\u0027auth_cred\u0027] \u003d {\u0027username\u0027: config_param.pop(\u0027username\u0027, \u0027\u0027),"},{"line_number":34,"context_line":"                        \u0027password\u0027: config_param.pop(\u0027password\u0027, \u0027\u0027),"},{"line_number":35,"context_line":"                        \u0027user_id\u0027: config_param.pop(\u0027user_id\u0027, \u0027\u0027),"},{"line_number":36,"context_line":"                        \u0027project_domain_name\u0027:"},{"line_number":37,"context_line":"                            config_param.pop(\u0027project_domain_name\u0027, \u0027\u0027),"},{"line_number":38,"context_line":"                        \u0027user_domain_name\u0027:"},{"line_number":39,"context_line":"                            config_param.pop(\u0027user_domain_name\u0027, \u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_45b34b9a","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":44},"updated":"2016-07-26 23:48:07.000000000","message":"would it be better putting \u0027project_domain_name\u0027  key in \u0027vim_project\u0027 instead of auth_cred dictionary and handle this change on the server as well?","commit_id":"7753dd1a482603a94cc375c3c21fc97577e2f47c"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"d3a69282afaaca6f5b0de6739e9f4e08abddb752","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    vim[\u0027auth_cred\u0027] \u003d {\u0027username\u0027: config_param.pop(\u0027username\u0027, \u0027\u0027),"},{"line_number":34,"context_line":"                        \u0027password\u0027: config_param.pop(\u0027password\u0027, \u0027\u0027),"},{"line_number":35,"context_line":"                        \u0027user_id\u0027: config_param.pop(\u0027user_id\u0027, \u0027\u0027),"},{"line_number":36,"context_line":"                        \u0027project_domain_name\u0027:"},{"line_number":37,"context_line":"                            config_param.pop(\u0027project_domain_name\u0027, \u0027\u0027),"},{"line_number":38,"context_line":"                        \u0027user_domain_name\u0027:"},{"line_number":39,"context_line":"                            config_param.pop(\u0027user_domain_name\u0027, \u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_a7ffa664","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":44},"in_reply_to":"dada55a8_45b34b9a","updated":"2016-07-27 04:10:40.000000000","message":"Good catch, yes! project_domain_name is more related to tenancy than auth credential. Please move this to \u0027vim_project\u0027. I guess the server patchset should also be fixed for this.","commit_id":"7753dd1a482603a94cc375c3c21fc97577e2f47c"},{"author":{"_account_id":8253,"name":"Murali Birru","email":"mbirru@gmail.com","username":"muralibirru"},"change_message_id":"c2e6e9bfffd23e549d5b2ee89c565d89f7b64ff5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                        \u0027project_domain_name\u0027:"},{"line_number":37,"context_line":"                            config_param.pop(\u0027project_domain_name\u0027, \u0027\u0027),"},{"line_number":38,"context_line":"                        \u0027user_domain_name\u0027:"},{"line_number":39,"context_line":"                            config_param.pop(\u0027user_domain_name\u0027, \u0027\u0027),"},{"line_number":40,"context_line":"                        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_35402434","line":39,"range":{"start_line":39,"start_character":65,"end_line":39,"end_character":69},"updated":"2016-07-20 15:12:50.000000000","message":"you can remove , before you close dict.\nlike \n\n config_param.pop(\u0027user_domain_name\u0027, \u0027\u0027)\n\n}","commit_id":"7753dd1a482603a94cc375c3c21fc97577e2f47c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c6b39a6d15c9d49feddeafa9bdd8787650e2dc9c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                        \u0027project_domain_name\u0027:"},{"line_number":37,"context_line":"                            config_param.pop(\u0027project_domain_name\u0027, \u0027\u0027),"},{"line_number":38,"context_line":"                        \u0027user_domain_name\u0027:"},{"line_number":39,"context_line":"                            config_param.pop(\u0027user_domain_name\u0027, \u0027\u0027),"},{"line_number":40,"context_line":"                        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_a910ddac","line":39,"range":{"start_line":39,"start_character":65,"end_line":39,"end_character":69},"in_reply_to":"dada55a8_35402434","updated":"2016-07-22 06:53:41.000000000","message":"https://www.python.org/dev/peps/pep-0008/","commit_id":"7753dd1a482603a94cc375c3c21fc97577e2f47c"}],"tackerclient/tests/unit/nfvo/test_vim_utils.py":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"67a7248bd07695932b6f896a48c6c77b12ab3863","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class CLITestAuthNoAuth(testtools.TestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_args2body_vim(self):"},{"line_number":27,"context_line":"        config_param \u003d {\u0027project_id\u0027: sentinel.prj_id1,"},{"line_number":28,"context_line":"                        \u0027username\u0027: sentinel.usrname1,"},{"line_number":29,"context_line":"                        \u0027password\u0027: sentinel.password1,"},{"line_number":30,"context_line":"                        \u0027project_domain_name\u0027: sentinel.prj_domain_name1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_092ecaf9","line":27,"range":{"start_line":27,"start_character":25,"end_line":27,"end_character":35},"updated":"2016-07-26 02:12:15.000000000","message":"this should be project_name because project_domain_name is not required otherwise.","commit_id":"7753dd1a482603a94cc375c3c21fc97577e2f47c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9d81fbccd224c41d6beca3af8f921760d4181a27","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class CLITestAuthNoAuth(testtools.TestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_args2body_vim(self):"},{"line_number":27,"context_line":"        config_param \u003d {\u0027project_id\u0027: sentinel.prj_id1,"},{"line_number":28,"context_line":"                        \u0027username\u0027: sentinel.usrname1,"},{"line_number":29,"context_line":"                        \u0027password\u0027: sentinel.password1,"},{"line_number":30,"context_line":"                        \u0027project_domain_name\u0027: sentinel.prj_domain_name1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_229d9f66","line":27,"range":{"start_line":27,"start_character":25,"end_line":27,"end_character":35},"in_reply_to":"dada55a8_092ecaf9","updated":"2016-07-26 06:37:04.000000000","message":"https://github.com/openstack/python-tackerclient/blob/master/tackerclient/tacker/v1_0/nfvo/vim_utils.py#L27 will put the project_id and project_name into body","commit_id":"7753dd1a482603a94cc375c3c21fc97577e2f47c"}]}